-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809
Merged
akning-ms
merged 6 commits into
Azure:master
from
mrohera:dev-deviceprovisioningservices-Microsoft.Devices-2020-09-01-preview-1
Dec 12, 2020
Merged
[Hub Generated] Review request for Microsoft.Devices to add version preview/2020-09-01-preview #11809
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59d5e39
Support userassigned identities for the KEK
mrohera 913c77f
Address PR comments
mrohera 8d6108c
Update rev for breaking changes
mrohera 46d9c90
Add identity information to the DPS description
mrohera 431b62f
Revert back version
mrohera ecdb59a
Lint warnings
mrohera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...sioningservices/resource-manager/Microsoft.Devices/preview/2020-09-01-preview/iotdps.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it valid to change version like this?
cc: @akning-ms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was given f/b that this is the guideline in order to make changes to an API that is still in development. I am checking with the approver and sharing the failure seen below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this version change since I added more changes and wanted the validations to re-run. I do not have clarity on what direction to proceed since the tests fail if this requirement were to be enforced.