Updating WindowsIot Swagger Issues (S360 Swagger Linting) #12094

adithyaj · 2020-12-14T07:21:02Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
Used autorest to validate.

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…ionResponses)

openapi-pipeline-app · 2020-12-14T07:21:08Z

Swagger Validation Report

️❌BreakingChange: 12 Errors, 2 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2019-06-01/WindowsIotServices.json <---> new: stable/2019-06-01/WindowsIotServices.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L258:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L578:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L568:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L578:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L568:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'target' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L578:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L568:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'details' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L578:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L568:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'notes' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L442:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L407:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'startDate' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L442:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L407:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'quantity' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L442:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L407:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'billingDomainName' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L442:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L407:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'adminDomainName' renamed or removed? New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L442:7 Old: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L407:7

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- windowsiot/resource-manager/readme.md tag:package-2019-06
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- windowsiot/resource-manager/readme.md tag:package-2019-06

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.WindowsIoT/stable/2019-06-01/WindowsIotServices.json#L548

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-14T07:21:08Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from fc3091f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/windowsiot/resource-manager/readme.md

⚠️azure-mgmt-windowsiot [View full logs] [Release SDK Changes]

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-windowsiot
cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-windowsiot
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-windowsiot
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] Traceback (most recent call last):
cmderr	[changelogReport]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReport]     "__main__", mod_spec)
cmderr	[changelogReport]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReport]     exec(code, run_globals)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 399, in <module>
cmderr	[changelogReport]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 254, in main
cmderr	[changelogReport]     path_to_package = resolve_package_directory(package_name)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 133, in resolve_package_directory
cmderr	[changelogReport]     return packages[0]
cmderr	[changelogReport] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReportLatest]     "__main__", mod_spec)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReportLatest]     exec(code, run_globals)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 399, in <module>
cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 254, in main
cmderr	[changelogReportLatest]     path_to_package = resolve_package_directory(package_name)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 133, in resolve_package_directory
cmderr	[changelogReportLatest]     return packages[0]
cmderr	[changelogReportLatest] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
warn	Not exact 2 reports found:
warn	Not generating changelog.

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fc3091f. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/windowsiot/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Services/put/Service_Create
cmderr	[Autorest]     - name: /Services/get/Service_List
cmderr	[Autorest]     - name: /Services/get/Service_ListByResourceGroup
cmderr	[Autorest]     - name: /Services/get/Services_GetProperties
cmderr	[Autorest]     - name: /Services/patch/Service_Update
cmderr	[Autorest]     - name: /Services/post/Service_CheckNameAvailability
cmderr	[Autorest]     - name: /Services/delete/Service_Delete
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git

️✔️windowsiot [View full logs] [Release Azure CLI Changes]
- windowsiotservices-0.1.0-py3-none-any.whl
- windowsiotservices-0.1.0.zip

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fc3091f. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️windowsiot/mgmt/2019-06-01/windowsiot [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ## Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ServicesClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, DeviceServiceProperties, string)` to `(context.Context, string, string, DeviceService, string)`
info	[Changelog] - Function `ServicesClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, DeviceServiceProperties, string)` to `(context.Context, string, string, DeviceService, string)`
info	[Changelog] - Function `ServicesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, DeviceServiceProperties, string)` to `(context.Context, string, string, DeviceService, string)`
info	[Changelog] - Function `ServicesClient.Update` parameter(s) have been changed from `(context.Context, string, string, DeviceServiceProperties, string)` to `(context.Context, string, string, DeviceService, string)`
info	[Changelog] - Field `Code` of struct `ErrorDetails` has been removed
info	[Changelog] - Field `Message` of struct `ErrorDetails` has been removed
info	[Changelog] - Field `Target` of struct `ErrorDetails` has been removed
info	[Changelog] - Field `Details` of struct `ErrorDetails` has been removed
info	[Changelog]
info	[Changelog] ## New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorDetailsError`
info	[Changelog] - New field `IsDataAction` in struct `OperationEntity`
info	[Changelog] - New field `Error` in struct `ErrorDetails`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 4 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fc3091f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/windowsiot/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.WindowsIoT [View full logs] [Release SDK Changes]
```
warn	Skip artifact folder because it doesn't exist: artifacts/packages
```

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fc3091f. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/windowsiot/resource-manager/readme.md

️✔️windowsiot [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from fc3091f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-12 02:37:43 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-windowsiot"
cmderr	[generate.py] 2021-01-12 02:37:43 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-12 02:37:43 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.8 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/windowsiot/azure-resourcemanager-windowsiot --java.namespace=com.azure.resourcemanager.windowsiot  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/windowsiot/resource-manager/readme.md
cmderr	[generate.py] 2021-01-12 02:38:21 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-12 02:38:21 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-12 02:38:21 INFO [POM][Skip] pom already has module azure-resourcemanager-windowsiot
cmderr	[generate.py] 2021-01-12 02:38:21 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-12 02:38:21 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-12 02:38:21 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-windowsiot [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-12 02:40:56 DEBUG Got artifact_id: azure-resourcemanager-windowsiot
cmderr	[Inst] 2021-01-12 02:40:56 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-12 02:40:56 DEBUG Got artifact: azure-resourcemanager-windowsiot-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-12 02:40:56 DEBUG Got artifact: azure-resourcemanager-windowsiot-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-12 02:40:56 DEBUG Match jar package: azure-resourcemanager-windowsiot-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-12 02:40:56 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12094/azure-sdk-for-java/azure-resourcemanager-windowsiot/azure-resourcemanager-windowsiot-1.0.0-beta.1.jar\" -o azure-resourcemanager-windowsiot-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-windowsiot -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-windowsiot-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from fc3091f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/windowsiot/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-12-17T07:46:16Z

Hi @adithyaj, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

ghost · 2021-01-03T16:01:09Z

Hi, @adithyaj. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

openapi-workflow-bot · 2021-01-06T20:12:09Z

Hi @adithyaj, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

adithyaj · 2021-01-11T18:11:00Z

@xccc-msft This PR passes the checks and has been approved for breaking changes. Could you take a look at merge it?

…er Linting) (#1458) Create to sync Azure/azure-rest-api-specs#12094 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/windowsiot?expand=1)

Adithya Jayachandran added 3 commits November 25, 2020 15:54

Updating ErrorDetails to match DefaultErrorResponseSchema (R4007)

10a1b0c

Updated Schema for Delete to include 204 response (R4011 DeleteOperat…

eb19acb

…ionResponses)

OperationsApiResponseSchema (R4018): Adding isDataAction attribute

26b9b42

adithyaj requested review from bfjelds and jagadishmurugan December 14, 2020 07:21

openapi-assignment-bot bot assigned xseeseesee Dec 14, 2020

openapi-sdkautomation bot mentioned this pull request Dec 14, 2020

[AutoPR windowsiot] Updating WindowsIot Swagger Issues (S360 Swagger Linting) AzureSDKAutomation/azure-cli-extensions#499

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Dec 14, 2020

xseeseesee approved these changes Dec 17, 2020

View reviewed changes

xseeseesee added the BreakingChangeReviewRequired label Dec 17, 2020

ghost added the no-recent-activity label Jan 3, 2021

Create/Update examples

7c875e6

ghost removed the no-recent-activity label Jan 6, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 6, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 6, 2021

Fix Swagger Issue 8945 (jagamu)

f9d0e04

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 6, 2021

Adithya Jayachandran added 2 commits January 7, 2021 00:35

Model Validation Success

07cf088

prettier check, passing

a7d8d76

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 11, 2021

JeffreyRichter approved these changes Jan 11, 2021

View reviewed changes

xseeseesee merged commit fc3091f into Azure:master Jan 12, 2021

openapi-sdkautomation bot mentioned this pull request Jan 12, 2021

[ReleasePR azure-resourcemanager-windowsiot] Updating Swagger Correctness Azure/azure-sdk-for-java#18554

Closed

adithyaj mentioned this pull request Mar 18, 2021

WindowsIot Swagger needs to update "Create" operation with required location parameter #8945

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating WindowsIot Swagger Issues (S360 Swagger Linting) #12094

Updating WindowsIot Swagger Issues (S360 Swagger Linting) #12094

adithyaj commented Dec 14, 2020

openapi-pipeline-app bot commented Dec 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 14, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 17, 2020

ghost commented Jan 3, 2021

openapi-workflow-bot bot commented Jan 6, 2021

adithyaj commented Jan 11, 2021

Updating WindowsIot Swagger Issues (S360 Swagger Linting) #12094

Updating WindowsIot Swagger Issues (S360 Swagger Linting) #12094

Conversation

adithyaj commented Dec 14, 2020

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Dec 14, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 14, 2020 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Dec 17, 2020

ghost commented Jan 3, 2021

openapi-workflow-bot bot commented Jan 6, 2021

adithyaj commented Jan 11, 2021

openapi-pipeline-app bot commented Dec 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 14, 2020 •

edited

Loading