Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Insights to add version preview/2017-11-01-preview #12234

Merged
merged 8 commits into from
Jan 6, 2021
Merged

[Hub Generated] Review request for Microsoft.Insights to add version preview/2017-11-01-preview #12234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b372a91
Fixed swagger validations for version 2017-11-01
yashmuel Dec 24, 2020
7a9ed7b
reverted errorREsponse, suppession in another PR
yashmuel Dec 29, 2020
4acb87f
added suppression rule
yashmuel Jan 4, 2021
56ca19c
removed suppression as it exists in another PR
yashmuel Jan 4, 2021
89dc92a
added back suppressoin rule
yashmuel Jan 4, 2021
4f609b7
added missing timestamps
yashmuel Jan 4, 2021
6f110cf
fixed suppression
yashmuel Jan 5, 2021
2b08236
Merge branch 'master' into dev-monitor-Microsoft.Insights-2017-11-01-…
yashmuel Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .../monitor/resource-manager/Microsoft.Insights/preview/2017-11-01-preview/baseline_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}
},
"paths": {
"/{resourceUri}/providers/microsoft.insights/baseline/{metricName}": {
"/{resourceUri}/providers/Microsoft.Insights/baseline/{metricName}": {
"get": {
"tags": [
"Baseline"
Expand Down Expand Up @@ -238,6 +238,15 @@
"description": "A single high threshold value."
},
"description": "The high thresholds of the baseline."
},
"timestamps": {
"type": "array",
"items": {
"type": "string",
"format": "date-time",
"description": "the timestamp for the baseline value in ISO 8601 format."
},
"description": "the array of timestamps of the baselines."
}
},
"required": [
Expand Down
9 changes: 9 additions & 0 deletions ...resource-manager/Microsoft.Insights/preview/2017-11-01-preview/calculateBaseline_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,15 @@
"description": "A single high threshold value."
},
"description": "The high thresholds of the baseline."
},
"timestamps": {
"type": "array",
"items": {
"type": "string",
"format": "date-time",
"description": "the timestamp for the baseline value in ISO 8601 format."
},
"description": "the array of timestamps of the baselines."
}
},
"required": [
Expand Down
3 changes: 3 additions & 0 deletions specification/monitor/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@ directive:
from: dataCollectionRuleAssociations_API.json
where: $.paths
reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
- suppress: R4007
from: baseline_API.json
reason: 'Updating the error response to the new format would be a breaking change.'
- suppress: R4007
from: metricBaselines_API.json
reason: 'Updating the error response to the new format would be a breaking change.'
Expand Down