[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12270

mudit794 · 2021-01-04T04:58:44Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2021-01-04T04:58:46Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2020-01-01/advisor.json <---> new: stable/2020-01-01/advisor.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.Advisor/stable/2020-01-01/advisor.json#L487:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- advisor/resource-manager/readme.md tag:package-2020-01
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- advisor/resource-manager/readme.md tag:package-2020-01

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-04T04:58:46Z

Hi, @mudit794 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-04T04:58:47Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 718ed16. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-07 12:29:56 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-advisor"
cmderr	[generate.py] 2021-01-07 12:29:56 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-07 12:29:56 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.8 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/advisor/azure-resourcemanager-advisor --java.namespace=com.azure.resourcemanager.advisor  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md
cmderr	[generate.py] 2021-01-07 12:30:38 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-07 12:30:38 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-07 12:30:38 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-07 12:30:38 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-07 12:30:38 ERROR [POM][Skip] find more than one <modules> in pom
cmderr	[generate.py] 2021-01-07 12:30:50 ERROR [GENERATE] Maven build fail

️✔️azure-resourcemanager-advisor [View full logs] [Release SDK Changes]

pom.xml

cmderr	[Inst] 2021-01-07 12:31:37 DEBUG Got artifact_id: azure-resourcemanager-advisor
cmderr	[Inst] 2021-01-07 12:31:37 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-07 12:31:37 ERROR Unmatch any jar in artifacts

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 718ed16. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Advisor [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(65,58): error CS1061: 'object' does not contain a definition for 'Ttl' and no accessible extension method 'Ttl' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(69,38): error CS1061: 'object' does not contain a definition for 'Name' and no accessible extension method 'Name' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(70,38): error CS1061: 'object' does not contain a definition for 'Id' and no accessible extension method 'Id' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,21): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,38): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(32,62): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(33,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(35,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(38,65): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(39,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,46): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,63): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(55,46): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(57,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(60,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(65,58): error CS1061: 'object' does not contain a definition for 'Ttl' and no accessible extension method 'Ttl' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(69,38): error CS1061: 'object' does not contain a definition for 'Name' and no accessible extension method 'Name' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/SuppressionTests.cs(70,38): error CS1061: 'object' does not contain a definition for 'Id' and no accessible extension method 'Id' accepting a first argument of type 'object' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,21): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(25,38): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(32,62): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(33,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(35,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(38,65): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(39,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,46): error CS0117: 'ConfigData' does not contain a definition for 'Properties' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(49,63): error CS0246: The type or namespace name 'ConfigDataProperties' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(55,46): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(57,28): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/BasicTests/ConfigurationTests.cs(60,47): error CS1061: 'ConfigData' does not contain a definition for 'Properties' and no accessible extension method 'Properties' accepting a first argument of type 'ConfigData' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/advisor/Microsoft.Azure.Management.Advisor/tests/Microsoft.Azure.Management.Advisor.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 718ed16. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md

️✔️azure-mgmt-advisor [View full logs] [Release SDK Changes]

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-advisor
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-advisor
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.advisor
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.advisor
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.advisor
cmderr	[changelogReport] INFO:__main__:Report written to sdk/advisor/azure-mgmt-advisor/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-advisor on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '1.0.0', '1.0.1', '2.0.0', '2.0.1', '3.0.0', '4.0.0', '9.0.0b1', '9.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 4.0.0 of azure-mgmt-advisor in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.advisor
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.advisor
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.advisor
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/advisor/azure-mgmt-advisor/code_reports/4.0.0/report.json
cmdout	[Changelog] Size of delta 1.507% size of original (original: 12009 chars, delta: 181 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model SuppressionContract has a new parameter expiration_time_stamp

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 718ed16. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️advisor/mgmt/2020-01-01/advisor [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ## Breaking Changes
info	[Changelog]
info	[Changelog] - Function `SuppressionsClient.Create` return value(s) have been changed from `(SuppressionContract, error)` to `(SetObject, error)`
info	[Changelog] - Function `SuppressionsClient.CreateResponder` return value(s) have been changed from `(SuppressionContract, error)` to `(SetObject, error)`
info	[Changelog] - Field `autorest.Response` of struct `SuppressionContract` has been removed
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 0 additive change(s).
info	[Changelog]

️✔️advisor/mgmt/2017-04-19/advisor [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️advisor/mgmt/2017-03-31/advisor [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/advisor/mgmt/2016-07-12-preview/advisor [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 718ed16. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/advisor/resource-manager/readme.md

️✔️advisor [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 9
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 9
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager]  A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-07T12_30_53_997Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 9,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3018,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 718ed16. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/advisor/resource-manager/readme.md

️✔️@azure/arm-advisor [View full logs] [Release SDK Changes]

azure-arm-advisor-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/advisorManagementClient.js → ./dist/arm-advisor.js...
cmderr	[npmPack] created ./dist/arm-advisor.js in 287ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-04T05:01:12Z

Hi @mudit794, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

mudit794 · 2021-01-04T19:32:19Z

@raych1 Can you please help merge this PR.

raych1 · 2021-01-05T06:28:59Z

@raych1 Can you please help merge this PR.

@mudit794 , can you confirm if there's no need to refresh any SDK/CLI?

mudit794 · 2021-01-05T08:09:22Z

@raych1 Can you please help merge this PR.

@mudit794 , can you confirm if there's no need to refresh any SDK/CLI?

@raych1
no need to refresh sdk and cli

raych1 · 2021-01-06T00:43:00Z

@ArcturusZhang , can you check the breaking change for GO SDK? Thanks.

ArcturusZhang · 2021-01-07T04:09:22Z

/azp run

azure-pipelines · 2021-01-07T04:09:36Z

Azure Pipelines successfully started running 2 pipeline(s).

ArcturusZhang · 2021-01-07T04:20:20Z

@raych1 the breaking changes in go SDK are not introduced in this PR, therefore those are fine

Update advisor.json

03f38f8

mudit794 marked this pull request as ready for review January 4, 2021 05:00

openapi-assignment-bot bot assigned raych1 Jan 4, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 4, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 4, 2021

JeffreyRichter approved these changes Jan 4, 2021

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 4, 2021

mudit794 requested a review from raych1 January 4, 2021 19:31

raych1 approved these changes Jan 7, 2021

View reviewed changes

raych1 merged commit 718ed16 into Azure:master Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12270

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12270

mudit794 commented Jan 4, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 4, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 4, 2021

openapi-pipeline-app bot commented Jan 4, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 4, 2021

mudit794 commented Jan 4, 2021

raych1 commented Jan 5, 2021

mudit794 commented Jan 5, 2021

raych1 commented Jan 6, 2021

ArcturusZhang commented Jan 7, 2021

azure-pipelines bot commented Jan 7, 2021

ArcturusZhang commented Jan 7, 2021

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12270

[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 #12270

Conversation

mudit794 commented Jan 4, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jan 4, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Jan 4, 2021

openapi-pipeline-app bot commented Jan 4, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 4, 2021

mudit794 commented Jan 4, 2021

raych1 commented Jan 5, 2021

mudit794 commented Jan 5, 2021

raych1 commented Jan 6, 2021

ArcturusZhang commented Jan 7, 2021

azure-pipelines bot commented Jan 7, 2021

ArcturusZhang commented Jan 7, 2021

mudit794 commented Jan 4, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 4, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 4, 2021 •

edited

Loading