Swagger Correctness changes for Sentinel Bookmarks #12556

zhzhao8888 · 2021-01-21T22:30:29Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Issue list here:

SwaggerIssues.xlsx
@zhenglaizhang

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-21T22:30:32Z

Hi, @zhzhao8888 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-21T22:30:33Z

Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2019-01-01-preview/SecurityInsights.json <---> new: preview/2019-01-01-preview/SecurityInsights.json
- original: stable/2020-01-01/SecurityInsights.json <---> new: stable/2020-01-01/SecurityInsights.json

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'eventTime' in response that was not found in the old version. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5440:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5440:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'queryStartTime' in response that was not found in the old version. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5440:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5440:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'queryEndTime' in response that was not found in the old version. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5440:7 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5440:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'edges' in response that was not found in the old version. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5540:11 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5525:11
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'eventTime' in response that was not found in the old version. New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7 Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'queryStartTime' in response that was not found in the old version. New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7 Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'queryEndTime' in response that was not found in the old version. New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7 Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- securityinsights/resource-manager/readme.md tag:package-composite-v1
- securityinsights/resource-manager/readme.md tag:package-2019-01-preview-only
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- securityinsights/resource-manager/readme.md tag:package-composite-v1
- securityinsights/resource-manager/readme.md tag:package-2019-01-preview-only

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-21T22:30:33Z

Swagger Generation Artifacts

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 34405a7. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-teams' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Actions/put/Creates or updates an action of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
cmderr	[Autorest]     - name: /Actions/get/Get an action of alert rule.
cmderr	[Autorest]     - name: /Actions/delete/Delete an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
cmderr	[Autorest]     - name: /Bookmarks/put/Creates or updates a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get all bookmarks.
cmderr	[Autorest]     - name: /Bookmarks/delete/Delete a bookmark.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a ASC data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MCAS data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MDATP data connector
cmderr	[Autorest]     - name: /DataConnectors/get/Get a TI data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get all data connectors.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AAD data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AATP data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
cmderr	[Autorest]     - name: /IncidentComments/put/Creates an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git

️✔️securityinsight [View full logs] [Release Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 34405a7. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md

️✔️@azure/arm-securityinsight [View full logs] [Release SDK Changes]

azure-arm-securityinsight-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
cmderr	[npmPack] created ./dist/arm-securityinsight.js in 422ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 34405a7. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md

️✔️securityinsights [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 34405a7. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 34405a7. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `AlertRulesClient.GetActionPreparer` has been removed
info	[Changelog] - Function `AlertRulesClient.GetActionResponder` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteActionSender` has been removed
info	[Changelog] - Function `AlertRulesClient.GetActionSender` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionSender` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionResponder` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteActionResponder` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateAction` has been removed
info	[Changelog] - Function `AlertRulesClient.GetAction` has been removed
info	[Changelog] - Function `AlertRulesClient.CreateOrUpdateActionPreparer` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteActionPreparer` has been removed
info	[Changelog] - Function `AlertRulesClient.DeleteAction` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `ActionsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdatePreparer(context.Context, string, string, string, string, ActionRequest) (*http.Request, error)`
info	[Changelog] - New function `ActionsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdateResponder(*http.Response) (ActionResponse, error)`
info	[Changelog] - New function `ActionsClient.CreateOrUpdate(context.Context, string, string, string, string, ActionRequest) (ActionResponse, error)`
info	[Changelog] - New function `ActionsClient.DeletePreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ActionsClient.Get(context.Context, string, string, string, string) (ActionResponse, error)`
info	[Changelog] - New function `ActionsClient.GetPreparer(context.Context, string, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `ActionsClient.Delete(context.Context, string, string, string, string) (autorest.Response, error)`
info	[Changelog] - New function `ActionsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ActionsClient.DeleteResponder(*http.Response) (autorest.Response, error)`
info	[Changelog] - New function `ActionsClient.GetResponder(*http.Response) (ActionResponse, error)`
info	[Changelog] - New struct `OfficeDataConnectorDataTypesTeams`
info	[Changelog] - New field `Teams` in struct `OfficeDataConnectorDataTypes`
info	[Changelog] - New field `QueryStartTime` in struct `BookmarkProperties`
info	[Changelog] - New field `QueryEndTime` in struct `BookmarkProperties`
info	[Changelog] - New field `EventTime` in struct `BookmarkProperties`
info	[Changelog]
info	[Changelog] Total 12 breaking change(s), 16 additive change(s).
info	[Changelog]

️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - New const `KindBasicDataConnectorKindDataConnector`
info	[Changelog] - New const `KindBasicDataConnectorKindThreatIntelligenceTaxii`
info	[Changelog] - New const `KindBasicDataConnectorKindAzureSecurityCenter`
info	[Changelog] - New const `KindBasicDataConnectorKindAzureActiveDirectory`
info	[Changelog] - New const `KindBasicDataConnectorKindOffice365`
info	[Changelog] - New const `KindBasicDataConnectorKindThreatIntelligence`
info	[Changelog] - New const `KindBasicDataConnectorKindAzureAdvancedThreatProtection`
info	[Changelog] - New const `KindBasicDataConnectorKindMicrosoftCloudAppSecurity`
info	[Changelog] - New const `KindBasicDataConnectorKindDynamics365`
info	[Changelog] - New const `KindBasicDataConnectorKindOfficeATP`
info	[Changelog] - New const `KindBasicDataConnectorKindMicrosoftDefenderAdvancedThreatProtection`
info	[Changelog] - New const `KindBasicDataConnectorKindAmazonWebServicesCloudTrail`
info	[Changelog] - New function `*ThreatIntelligenceAlertRuleTemplate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `AlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
info	[Changelog] - New function `MicrosoftSecurityIncidentCreationAlertRuleTemplate.AsThreatIntelligenceAlertRuleTemplate() (*ThreatIntelligenceAlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsThreatIntelligenceAlertRuleTemplate() (*ThreatIntelligenceAlertRuleTemplate, bool)`
info	[Changelog] - New function `FusionAlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
info	[Changelog] - New function `FusionAlertRuleTemplate.AsThreatIntelligenceAlertRuleTemplate() (*ThreatIntelligenceAlertRuleTemplate, bool)`
info	[Changelog] - New function `MLBehaviorAnalyticsAlertRuleTemplate.AsThreatIntelligenceAlertRuleTemplate() (*ThreatIntelligenceAlertRuleTemplate, bool)`
info	[Changelog] - New function `MLBehaviorAnalyticsAlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
info	[Changelog] - New function `AlertRuleTemplate.AsThreatIntelligenceAlertRuleTemplate() (*ThreatIntelligenceAlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsMicrosoftSecurityIncidentCreationAlertRule() (*MicrosoftSecurityIncidentCreationAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsMLBehaviorAnalyticsAlertRuleTemplate() (*MLBehaviorAnalyticsAlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsMicrosoftSecurityIncidentCreationAlertRuleTemplate() (*MicrosoftSecurityIncidentCreationAlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplateProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsFusionAlertRule() (*FusionAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsScheduledAlertRule() (*ScheduledAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsFusionAlertRuleTemplate() (*FusionAlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsAlertRule() (*AlertRule, bool)`
info	[Changelog] - New function `ScheduledAlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsBasicAlertRuleTemplate() (BasicAlertRuleTemplate, bool)`
info	[Changelog] - New function `MicrosoftSecurityIncidentCreationAlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsBasicAlertRule() (BasicAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsMLBehaviorAnalyticsAlertRule() (*MLBehaviorAnalyticsAlertRule, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsScheduledAlertRuleTemplate() (*ScheduledAlertRuleTemplate, bool)`
info	[Changelog] - New function `ScheduledAlertRuleTemplate.AsThreatIntelligenceAlertRuleTemplate() (*ThreatIntelligenceAlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ThreatIntelligenceAlertRuleTemplate.AsAlertRuleTemplate() (*AlertRuleTemplate, bool)`
info	[Changelog] - New function `ThreatIntelligenceAlertRule.AsThreatIntelligenceAlertRule() (*ThreatIntelligenceAlertRule, bool)`
info	[Changelog] - New function `*ThreatIntelligenceAlertRule.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `ConnectedEntity`
info	[Changelog] - New struct `ThreatIntelligenceAlertRule`
info	[Changelog] - New struct `ThreatIntelligenceAlertRuleProperties`
info	[Changelog] - New struct `ThreatIntelligenceAlertRuleTemplate`
info	[Changelog] - New struct `ThreatIntelligenceAlertRuleTemplateProperties`
info	[Changelog] - New struct `ThreatIntelligenceParsedPattern`
info	[Changelog] - New struct `ThreatIntelligenceParsedPatternTypeValue`
info	[Changelog] - New field `Edges` in struct `BookmarkExpandResponseValue`
info	[Changelog] - New field `EventTime` in struct `BookmarkProperties`
info	[Changelog] - New field `QueryEndTime` in struct `BookmarkProperties`
info	[Changelog] - New field `QueryStartTime` in struct `BookmarkProperties`
info	[Changelog] - New field `ReceiveDate` in struct `MailMessageEntityProperties`
info	[Changelog] - New field `Language` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `ParsedPattern` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog] - New field `Extensions` in struct `ThreatIntelligenceIndicatorProperties`
info	[Changelog]
info	[Changelog] Total 15 breaking change(s), 63 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 34405a7. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityInsights.1.0.0-preview.2.nupkg
- Microsoft.Azure.Management.SecurityInsights.1.0.0-preview.2.snupkg

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-25T03:37:55Z

Hi @zhzhao8888, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

zhzhao8888 · 2021-01-27T00:28:21Z

Breaking change request was created:
https://msazure.visualstudio.com/One/_workitems/edit/9212340

openapi-workflow-bot · 2021-02-02T02:42:26Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

zhzhao8888 · 2021-02-03T17:25:01Z

WI for this:
Task 9259170: Swagger Correctness for Sentinel Bookmarks - Boards (visualstudio.com)
https://msazure.visualstudio.com/Swagger KPIs/_workitems/edit/9259170

Here is the original S360 item, which contains 57 entries, Bookmarks is part of it and has 11 in total.
Exploring Unified Platform for Microsoft Azure Sentinel (msftcloudes.com)
https://vnext.s360.msftcloudes.com/blades/unifiedplatform?blade=AssignedTo:All~KPI:cf751b97-2c95-420f-baa8-9a16e8643a5b~SLA:2~Forums:All~_loc:UnifiedPlatform&def=&peopleBasedNodes=mgladi_team;kobyk_team;ellevi_team;yafitc_team&tile=S360_ServiceId:f65a9d67-0855-4d81-b01f-5dab67fe0afd~_loc:__key__UnifiedPlatform__cf751b97-2c95-420f-baa8-9a16e8643a5b&global=4:f65a9d67-0855-4d81-b01f-5dab67fe0afd

@zhenglaizhang

Swagger Correctness changes for Sentinel Bookmarks

e770d72

openapi-assignment-bot bot assigned zhenglaizhang Jan 21, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 21, 2021

zhenglaizhang added the BreakingChangeReviewRequired label Jan 25, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2021

JeffreyRichter approved these changes Feb 1, 2021

View reviewed changes

openapi-workflow-bot bot added the FixS360 label Feb 2, 2021

zhenglaizhang merged commit 34405a7 into Azure:master Feb 4, 2021

dicolanl mentioned this pull request Mar 10, 2021

SecurityInsights[GA] Azure/azure-sdk-for-net#19359

Merged

10 tasks

dicolanl mentioned this pull request Apr 14, 2021

SecurityInsights 0.2.0 release Azure/azure-powershell#14750

Merged

8 tasks

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Swagger Correctness changes for Sentinel Bookmarks (Azure#12556)

17b193d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swagger Correctness changes for Sentinel Bookmarks #12556

Swagger Correctness changes for Sentinel Bookmarks #12556

zhzhao8888 commented Jan 21, 2021 •

edited by zhenglaizhang

Loading

openapi-workflow-bot bot commented Jan 21, 2021

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 25, 2021

zhzhao8888 commented Jan 27, 2021

openapi-workflow-bot bot commented Feb 2, 2021

zhzhao8888 commented Feb 3, 2021

Swagger Correctness changes for Sentinel Bookmarks #12556

Swagger Correctness changes for Sentinel Bookmarks #12556

Conversation

zhzhao8888 commented Jan 21, 2021 • edited by zhenglaizhang Loading

Changelog

Issue list here:

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 21, 2021

openapi-pipeline-app bot commented Jan 21, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 21, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 25, 2021

zhzhao8888 commented Jan 27, 2021

openapi-workflow-bot bot commented Feb 2, 2021

zhzhao8888 commented Feb 3, 2021

zhzhao8888 commented Jan 21, 2021 •

edited by zhenglaizhang

Loading

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2021 •

edited

Loading