-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new RP Microsoft.SecurityAndCompliance #12812
Add new RP Microsoft.SecurityAndCompliance #12812
Conversation
Hi, @sonalverm Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
Based on the response model schema, operation 'PrivateLinkResources_ListByService' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForEDMUpload.json#L536 |
|
Based on the response model schema, operation 'PrivateLinkResourcesComp_ListByService' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForM365ComplianceCenter.json#L536 |
|
Based on the response model schema, operation 'PrivateLinkResourcesSec_ListByService' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForM365SecurityCenter.json#L536 |
|
Based on the response model schema, operation 'PrivateLinkResourcesAdtAPI_ListByService' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForO365ManagementActivityAPI.json#L536 |
|
Based on the response model schema, operation 'PrivateLinkResourcesForSCCPowershell_ListByService' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForSCCPowershell.json#L536 |
|
The child tracked resource, 'privateEndpointConnections' with immediate parent 'PrivateLinkServicesForEDMUploadDescription', must have a list by immediate parent operation. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForSCCPowershell.json#L627 |
|
The child tracked resource, 'privateLinkResources' with immediate parent 'PrivateLinkServicesForEDMUploadDescription', must have a list by immediate parent operation. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForSCCPowershell.json#L627 |
|
The child tracked resource, 'privateEndpointConnections' with immediate parent 'PrivateLinkServicesForM365ComplianceCenterDescription', must have a list by immediate parent operation. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForSCCPowershell.json#L627 |
|
The child tracked resource, 'privateLinkResources' with immediate parent 'PrivateLinkServicesForM365ComplianceCenterDescription', must have a list by immediate parent operation. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForSCCPowershell.json#L627 |
|
The child tracked resource, 'privateEndpointConnections' with immediate parent 'PrivateLinkServicesForM365SecurityCenterDescription', must have a list by immediate parent operation. Location: Microsoft.SecurityAndCompliance/stable/2021-01-11/privateLinkServicesForSCCPowershell.json#L627 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 13 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'ServiceAccessPolicyEntry' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'ServicesResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateEndpoint' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateEndpointConnection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateEndpointConnectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateLinkServiceConnectionState' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateLinkResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateLinkResourceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateEndpointConnectionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"securityandcompliance/resource-manager/readme.md", "tag":"package-2021-01-11", "details":"The schema 'PrivateLinkResourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi @sonalverm, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @sonalverm your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @raych1 |
@jianyexi , could you have a look at lintDiff runtime errors? |
@raych1 , could you please help me with swagger lintdiff pipeline errors? |
@msyyc , can you check if this PR causes python sdk breaking change? |
For python, the PR is ok |
1 similar comment
For python, the PR is ok |
* add new RP Microsoft.SecurityAndCompliance * add resource types for security compliance auditing EDM Powershell * update json file names in readme * address review comments * fix errors * add privatelinks.json * add privatelinks.json in readme * prettfiy privatelinks.json * fix types.json path * fix pipeline issues * remove duplicate schema * refer privatelinks.json * rename resource types * fix pipeline errors * address review comments * address PR review comments * update readme * add reference to operationslist.json * update file name in readme * remove privatelinks.json ref * add readonly true * fix track validation errors * fix track validation errors * fix track validation errors * fix spell check * fix spell check * fix pipeline errors Co-authored-by: Sonal Verma <sonal.verma@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.