Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ssoContext and friendly name to match 2020-11-10 #13152

Merged
merged 2 commits into from
Feb 25, 2021
Merged

remove ssoContext and friendly name to match 2020-11-10 #13152

merged 2 commits into from
Feb 25, 2021

Conversation

datr93
Copy link
Contributor

@datr93 datr93 commented Feb 24, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 24, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'friendlyName' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L3576:7
    Old: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L3584:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ssoContext' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2713:7
    Old: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2713:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ssoContext' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2867:7
    Old: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2871:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'friendlyName' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L3633:7
    Old: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L3641:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ssoContext' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2755:7
    Old: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2755:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ssoContext' renamed or removed?
    New: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2924:7
    Old: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2928:7
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 14 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-01-14-preview",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"desktopvirtualization/resource-manager/readme.md",
    "tag":"package-2021-02-01-preview",
    "details":"The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 24, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cd4f2f8. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /HostPools/put/HostPool_Create
cmderr	[Autorest]     - name: /HostPools/get/HostPool_Get
cmderr	[Autorest]     - name: /HostPools/get/HostPool_List
cmderr	[Autorest]     - name: /HostPools/get/HostPool_ListByResourceGroup
cmderr	[Autorest]     - name: /HostPools/patch/HostPool_Update
cmderr	[Autorest]     - name: /HostPools/post/HostPools_RetrieveRegistrationToken_Post
cmderr	[Autorest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_List
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
cmderr	[Autorest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
cmderr	[Autorest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
cmderr	[Autorest]     - name: /MsixImages/post/MsixImage_Expand
cmderr	[Autorest]     - name: /MSIXPackages/put/MSIXPackage_Create
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_Get
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_List
cmderr	[Autorest]     - name: /MSIXPackages/patch/MSIXPackage_Update
cmderr	[Autorest]     - name: /MSIXPackages/delete/MSIXPackage_Delete
cmderr	[Autorest]     - name: /ScalingPlans/put/ScalingPlans_Create
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_Get
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListByResourceGroup
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListBySubscription
cmderr	[Autorest]     - name: /ScalingPlans/get/UserSession_SendMessage_Post
cmderr	[Autorest]     - name: /ScalingPlans/patch/ScalingPlans_Update
cmderr	[Autorest]     - name: /ScalingPlans/delete/ScalingPlans_Delete
cmderr	[Autorest]     - name: /HostPools/delete/HostPool_Delete
cmderr	[Autorest]     - name: /Workspaces/put/Workspace_Create
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_Get
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListBySubscription
cmderr	[Autorest]     - name: /Workspaces/patch/Workspace_Update
cmderr	[Autorest]     - name: /Workspaces/delete/Workspace_Delete
cmderr	[Autorest] --------------------------------------------------------
    • ️✔️desktopvirtualization [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cd4f2f8. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
    • ️✔️desktopvirtualization [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cd4f2f8. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cd4f2f8. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!
warn	File azure-sdk-for-python_tmp/generateOutput.json not found to read
    • ️✔️azure-mgmt-desktopvirtualization [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from cd4f2f8. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-25 02:21:53 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization"
cmderr	[generate.py] 2021-02-25 02:21:53 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-25 02:21:53 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmderr	[generate.py] 2021-02-25 02:22:41 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-25 02:22:41 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-25 02:22:41 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
cmderr	[generate.py] 2021-02-25 02:22:41 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-25 02:22:41 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-25 02:22:41 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-02-25 02:24:28 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-desktopvirtualization [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-02-25 02:25:39 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
cmderr	[Inst] 2021-02-25 02:25:39 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-25 02:25:39 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-25 02:25:39 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-25 02:25:39 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13152/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from cd4f2f8. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/desktopvirtualization/mgmt/2021-02-01-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

    @openapi-workflow-bot
    Copy link

    Hi @datr93, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Feb 24, 2021
    Closed
    Closed
    Closed
    Closed
    @datr93
    Copy link
    Contributor Author

    datr93 commented Feb 25, 2021

    @leni-msft can you take a look thanks

    @leni-msft leni-msft added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 25, 2021
    @leni-msft leni-msft merged commit cd4f2f8 into Azure:master Feb 25, 2021
    This was referenced Feb 25, 2021
    Closed
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    This was referenced Feb 25, 2021
    Closed
    Closed
    This was referenced Feb 25, 2021
    Merged
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @datr93 @mkarmark
    remove ssoContext and friendly name to match 2020-11-10 (Azure#13152)
    d12098b 
    * remove ssoContext and friendly name to match 2020-11-10

* name length was lost too
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @leni-msft leni-msft leni-msft approved these changes

    Assignees

    @leni-msft leni-msft

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @datr93 @JeffreyRichter @leni-msft