Datr/live validation correctness #13189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2517 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2517 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2513 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource Location: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2603 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource Location: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2736 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource Location: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L2975 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2513 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource Location: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2603 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource Location: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2736 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource Location: Microsoft.DesktopVirtualization/preview/2021-02-01-preview/desktopvirtualization.json#L2975 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 26 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceModelWithAllowedPropertySet' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceModelWithAllowedPropertySet-identity' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceModelWithAllowedPropertySet-sku' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'ResourceModelWithAllowedPropertySet-plan' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"desktopvirtualization/resource-manager/readme.md", "tag":"package-2021-01-14-preview", "details":"The schema 'Sku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
This was referenced Feb 26, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
NewApiVersionRequired reason: |
lirenhe
added
WaitForARMFeedback
|
Please complete PR checklist in the description. The ARM team won't start review it without this. |
|
Please resolve breaking changes flagged by the tool. If you have a justification, please follow the breaking change checklist to get approval. |
|
Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @lirenhe |
datr93
commented
Mar 9, 2021
There was a problem hiding this comment.
Please resolve breaking changes flagged by the tool. If you have a justification, please follow the breaking change checklist to get approval.
Please resolve breaking changes flagged by the tool. If you have a justification, please follow the breaking change checklist to get approval.
This pr was opened in feb and gets the breaking change protection from the February grace period. I updated the other checkboxes. @j5lim can you take another look.
j5lim
approved these changes
Mar 10, 2021
j5lim
added
ARMSignedOff
|
@lirenhe can you take a look thanks! |
lirenhe
added
the
Approved-BreakingChange
This was referenced Mar 11, 2021
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
* kind and objectid * migration requets properties * readonly objectid and enum * cloudPcResource * operation fix * fix comma * fix operation * unhide * serviceSpect try again * try again operation * add objectId * cloudPcResource example * add migration example * update doesn't have migration * migration changes * make 2021-01-14-preview match 2021-02-01-preview * custom word
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* kind and objectid * migration requets properties * readonly objectid and enum * cloudPcResource * operation fix * fix comma * fix operation * unhide * serviceSpect try again * try again operation * add objectId * cloudPcResource example * add migration example * update doesn't have migration * migration changes * make 2021-01-14-preview match 2021-02-01-preview * custom word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.