Fix Integer format: S360 swagger lint issues #13769

ericshape · 2021-04-02T05:44:38Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Fix Integer format: S360 swagger lint issues
R4013 IntegerTypeMustHaveFormat

All breaking changes are expected.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-04-02T05:44:40Z

Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-04-02T05:44:41Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-04-02T05:44:42Z

Swagger Validation Report

️❌BreakingChange: 50 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.8)
- original: preview/2017-03-01-preview/jobs.json <---> new: preview/2017-03-01-preview/jobs.json
- original: preview/2017-10-01-preview/elasticPools.json <---> new: preview/2017-10-01-preview/elasticPools.json
- original: preview/2020-02-02-preview/ElasticPools.json <---> new: preview/2020-02-02-preview/ElasticPools.json
- original: preview/2020-02-02-preview/JobExecutions.json <---> new: preview/2020-02-02-preview/JobExecutions.json
- original: preview/2020-02-02-preview/JobStepExecutions.json <---> new: preview/2020-02-02-preview/JobStepExecutions.json
- original: preview/2020-02-02-preview/JobTargetExecutions.json <---> new: preview/2020-02-02-preview/JobTargetExecutions.json
- original: preview/2020-02-02-preview/ManagedDatabaseSecurityEvents.json <---> new: preview/2020-02-02-preview/ManagedDatabaseSecurityEvents.json
- original: preview/2020-08-01-preview/ElasticPools.json <---> new: preview/2020-08-01-preview/ElasticPools.json
- original: preview/2020-08-01-preview/JobExecutions.json <---> new: preview/2020-08-01-preview/JobExecutions.json
- original: preview/2020-08-01-preview/JobStepExecutions.json <---> new: preview/2020-08-01-preview/JobStepExecutions.json
- original: preview/2020-08-01-preview/JobTargetExecutions.json <---> new: preview/2020-08-01-preview/JobTargetExecutions.json
- original: preview/2020-08-01-preview/ManagedDatabaseSecurityEvents.json <---> new: preview/2020-08-01-preview/ManagedDatabaseSecurityEvents.json
- original: preview/2020-11-01-preview/ElasticPools.json <---> new: preview/2020-11-01-preview/ElasticPools.json
- original: preview/2020-11-01-preview/JobExecutions.json <---> new: preview/2020-11-01-preview/JobExecutions.json
- original: preview/2020-11-01-preview/JobStepExecutions.json <---> new: preview/2020-11-01-preview/JobStepExecutions.json
- original: preview/2020-11-01-preview/JobTargetExecutions.json <---> new: preview/2020-11-01-preview/JobTargetExecutions.json
- original: preview/2020-11-01-preview/ManagedDatabaseSecurityEvents.json <---> new: preview/2020-11-01-preview/ManagedDatabaseSecurityEvents.json

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L557:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L557:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L565:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L564:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L786:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L784:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L794:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L791:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1257:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1253:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1265:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1260:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1826:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1820:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1834:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1827:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1952:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1944:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1960:11 Old: Microsoft.Sql/preview/2017-03-01-preview/jobs.json#L1951:11

️🔄LintDiff inProgress [Detail]

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]

The following tags are being changed in this PR

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"Error: Plugin pre-namer reported failure."
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Error: Plugin pre-namer reported failure."
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Error: Plugin pre-namer reported failure."
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Error: Plugin pre-namer reported failure."
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-2017-03-preview", "details":"Error: Plugin pre-namer reported failure."
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2020-11", "details":"Error: Plugin pre-namer reported failure."
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"Schema 'FirewallRule' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from FirewallRule"
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v4", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink"
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Schema 'FirewallRule' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from FirewallRule"
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Schema 'ReplicationLink' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ReplicationLink"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-02T05:44:43Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from ce7c73036cbafe456a33cd70fe4b597a9f9f77b9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-sql [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DatabaseUpdate has a new parameter current_backup_storage_redundancy
info	[Changelog]   - Model DatabaseUpdate has a new parameter requested_backup_storage_redundancy
info	[Changelog]   - Model LongTermRetentionBackup has a new parameter requested_backup_storage_redundancy
info	[Changelog]   - Model LongTermRetentionBackup has a new parameter backup_storage_redundancy
info	[Changelog]   - Model Database has a new parameter current_backup_storage_redundancy
info	[Changelog]   - Model Database has a new parameter requested_backup_storage_redundancy
info	[Changelog]   - Added operation ServersOperations.import_database
info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.copy
info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.update
info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.update_by_resource_group
info	[Changelog]   - Added operation LongTermRetentionBackupsOperations.copy_by_resource_group
info	[Changelog]   - Added operation group LongTermRetentionPoliciesOperations
info	[Changelog]   - Added operation group ImportExportOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model DatabaseUpdate no longer has parameter storage_account_type
info	[Changelog]   - Model Database no longer has parameter storage_account_type
info	[Changelog]   - Removed operation DatabasesOperations.import_method
info	[Changelog]   - Removed operation DatabasesOperations.import_database
info	[Changelog]   - Removed operation group BackupLongTermRetentionPoliciesOperations

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ce7c73036cbafe456a33cd70fe4b597a9f9f77b9. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.Sql/servers/firewallRules in scope ResourceGroup
cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.Sql/servers/firewallRules in scope ResourceGroup
cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.Sql/servers/firewallRules in scope ResourceGroup

️✔️sql [View full logs] [Preview Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs] Generate from ce7c73036cbafe456a33cd70fe4b597a9f9f77b9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Sql [View full logs] [Preview SDK Changes]

cmdout	[msbuild]      1>/home/vsts/work/1/s/azure-sdk-for-net/build.proj : error MSB4057: The target "CreateNugetPackage" does not exist in the project.
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/build.proj : error MSB4057: The target "CreateNugetPackage" does not exist in the project.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ce7c73036cbafe456a33cd70fe4b597a9f9f77b9. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md

️✔️@azure/arm-sql [View full logs] [Preview SDK Changes]

azure-arm-sql-7.0.2.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
cmderr	[npmPack] created ./dist/arm-sql.js in 2.3s

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from ce7c73036cbafe456a33cd70fe4b597a9f9f77b9. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-04-02 05:50:14 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-sql-generated"
cmderr	[generate.py] 2021-04-02 05:50:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-04-02 05:50:14 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.21 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated --java.namespace=com.azure.resourcemanager.sql.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
cmderr	[generate.py] 2021-04-02 05:53:59 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-04-02 05:53:59 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-04-02 05:53:59 INFO [POM][Skip] pom already has module azure-resourcemanager-sql-generated
cmderr	[generate.py] 2021-04-02 05:53:59 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-04-02 05:53:59 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-04-02 05:53:59 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-sql-generated [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-04-02 06:00:53 DEBUG Got artifact_id: azure-resourcemanager-sql-generated
cmderr	[Inst] 2021-04-02 06:00:53 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-04-02 06:00:53 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-04-02 06:00:53 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-04-02 06:00:53 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-02 06:00:53 DEBUG Match jar package: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-02 06:00:53 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13769/azure-sdk-for-java/azure-resourcemanager-sql-generated/azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-sql-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-sql-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ce7c73036cbafe456a33cd70fe4b597a9f9f77b9. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sql/mgmt/2014-04-01/sql [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/sql/mgmt/v4.0/sql [View full logs] [Preview SDK Changes] Breaking Change Detected