Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with missing filter documentation in Access Review APIs #13892

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Fixing issue with missing filter documentation in Access Review APIs #13892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...r/Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/AccessReviewsFilterParameter"
}
],
"responses": {
Expand Down Expand Up @@ -301,6 +304,9 @@
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/AccessReviewsFilterParameter"
}
],
"responses": {
Expand Down Expand Up @@ -592,6 +598,9 @@
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/AccessReviewsFilterParameter"
}
],
"responses": {
Expand Down Expand Up @@ -707,6 +716,9 @@
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/AccessReviewsFilterParameter"
}
],
"responses": {
Expand Down Expand Up @@ -750,6 +762,9 @@
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/AccessReviewsFilterParameter"
}
],
"responses": {
Expand Down Expand Up @@ -891,6 +906,9 @@
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/AccessReviewsFilterParameter"
}
],
"responses": {
Expand Down Expand Up @@ -1386,6 +1404,11 @@
"name": "AccessReviewScopePrincipalType",
"modelAsString": true
}
},
"inactiveDuration": {
"type": "string",
"format": "duration",
"description": "Duration users are inactive for. The value should be in ISO 8601 format (http://en.wikipedia.org/wiki/ISO_8601#Durations).This code can be used to convert TimeSpan to a valid interval string: XmlConvert.ToString(new TimeSpan(hours, minutes, seconds))"
}
},
"description": "Descriptor for what needs to be reviewed"
Expand Down Expand Up @@ -1824,6 +1847,15 @@
"required": true,
"type": "string",
"description": "The API version to be used with the HTTP request."
},
"AccessReviewsFilterParameter": {
"name": "$filter",
"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation. Other than standard filters, one custom filter option is supported : 'assignedToMeToReview()'. When one specified $filter=assignedToMeToReview(), only items that are assigned to the calling user to review are returned",
"x-ms-skip-url-encoding": true,
"x-ms-parameter-location": "method"
}
}
}
3 changes: 2 additions & 1 deletion ...ion/preview/2021-03-01-preview/examples/GetAccessReviewInstanceAssignedForMyApproval.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"parameters": {
"api-version": "2021-03-01-preview",
"scheduleDefinitionId": "488a6d0e-0a63-4946-86e3-1f5bbc934661",
"id": "4135f961-be78-4005-8101-c72a5af307a2"
"id": "4135f961-be78-4005-8101-c72a5af307a2",
"$filter": "assignedToMeToReview()"
},
"responses": {
"200": {
Expand Down
3 changes: 2 additions & 1 deletion ...on/preview/2021-03-01-preview/examples/GetAccessReviewInstancesAssignedForMyApproval.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"parameters": {
"api-version": "2021-03-01-preview",
"scheduleDefinitionId": "488a6d0e-0a63-4946-86e3-1f5bbc934661"
"scheduleDefinitionId": "488a6d0e-0a63-4946-86e3-1f5bbc934661",
"$filter": "assignedToMeToReview()"
},
"responses": {
"200": {
Expand Down
3 changes: 2 additions & 1 deletion .../2021-03-01-preview/examples/GetAccessReviewScheduleDefinitionsAssignedForMyApproval.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"parameters": {
"api-version": "2021-03-01-preview"
"api-version": "2021-03-01-preview",
"$filter": "assignedToMeToReview()"
},
"responses": {
"200": {
Expand Down
6 changes: 6 additions & 0 deletions specification/authorization/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ directive:
- suppress: XmsPathsMustOverloadPaths
from: authorization-RoleDefinitionsCalls.json
reason: x-ms-paths extension was previously required. Suppressing so that we don't have to make changes to existing APIs.
- suppress: AddedPropertyInResponse
from: authorization-AccessReviewCalls.json
reason: API documentation is not exposed yet. We're making some small changes before publishing documentation.
- suppress: AddingOptionalProperty
from: authorization-AccessReviewCalls.json
reason: API documentation is not exposed yet. We're making some small changes before publishing documentation.
```

### Tag: package-2021-03-01-preview-only
Expand Down