document tenantId query parameter for cross-tenant role assignment ge… #14080

jdhms · 2021-04-22T16:58:32Z

…t and delete calls

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…t and delete calls

openapi-workflow-bot · 2021-04-22T16:58:36Z

Hi, @jdhms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-04-22T16:58:37Z

Swagger Validation Report

️❌BreakingChange: 24 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L44:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L123:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L176:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L283:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L334:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L427:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L471:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-04-01-preview/authorization-RoleAssignmentsCalls.json#L521:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json#L44:9
`❌` 1043 - AddingOptionalParameter	The optional parameter 'tenantId' was added in the new version. New: Microsoft.Authorization/preview/2020-08-01-preview/authorization-RoleAssignmentsCalls.json#L90:9

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'EligibleChildResources_Get' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/preview/2020-10-01-preview/EligibleChildResources.json#L42
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isOrganizationDefault Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L249
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApprovalRequired Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L368
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApprovalRequiredForExtension Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L372
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRequestorJustificationRequired Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L376
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApproverJustificationRequired Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L412
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEscalationEnabled Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L428
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isBackup Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L457
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L480
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isExpirationRequired Location: Microsoft.Authorization/preview/2020-10-01-preview/RoleManagementPolicy.json#L527

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-10-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-10-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-10-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-08-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-08-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-04-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-04-01-preview-only",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"authorization/resource-manager/readme.md",
"tag":"package-2020-04-01-preview-only",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-22T16:58:37Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-04-22T16:58:37Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 0d3d635. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-authorization [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter created_on
info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter delegated_managed_identity_resource_id
info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter updated_on
info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter updated_by
info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter scope
info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter created_by
info	[Changelog]   - Model RoleAssignment has a new parameter created_on
info	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
info	[Changelog]   - Model RoleAssignment has a new parameter updated_on
info	[Changelog]   - Model RoleAssignment has a new parameter updated_by
info	[Changelog]   - Model RoleAssignment has a new parameter created_by
info	[Changelog]   - Added operation RoleAssignmentsOperations.list_for_subscription
info	[Changelog]   - Added operation RoleAssignmentsOperations.validate
info	[Changelog]   - Added operation RoleAssignmentsOperations.validate_by_id
info	[Changelog]   - Added operation RoleAssignmentsOperations.create_by_id
info	[Changelog]   - Added operation RoleAssignmentsOperations.delete_by_id
info	[Changelog]   - Added operation RoleAssignmentsOperations.get_by_id
info	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
info	[Changelog]   - Added operation group RoleAssignmentScheduleRequestsOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group Operations
info	[Changelog]   - Added operation group RoleEligibilitySchedulesOperations
info	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
info	[Changelog]   - Added operation group AccessReviewInstanceOperations
info	[Changelog]   - Added operation group EligibleChildResourcesOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group RoleEligibilityScheduleInstancesOperations
info	[Changelog]   - Added operation group RoleManagementPoliciesOperations
info	[Changelog]   - Added operation group RoleAssignmentScheduleInstancesOperations
info	[Changelog]   - Added operation group RoleAssignmentSchedulesOperations
info	[Changelog]   - Added operation group RoleEligibilityScheduleRequestsOperations
info	[Changelog]   - Added operation group RoleManagementPolicyAssignmentsOperations
info	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group AccessReviewInstancesOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter principal_id of model RoleAssignment is now required
info	[Changelog]   - Parameter role_definition_id of model RoleAssignment is now required
info	[Changelog]   - Operation RoleAssignmentsOperations.delete has a new signature
info	[Changelog]   - Operation RoleAssignmentsOperations.get has a new signature
info	[Changelog]   - Operation RoleAssignmentsOperations.list_for_resource has a new signature
info	[Changelog]   - Operation RoleAssignmentsOperations.list_for_resource_group has a new signature
info	[Changelog]   - Operation RoleAssignmentsOperations.list_for_scope has a new signature
info	[Changelog]   - Operation RoleAssignmentsOperations.list_for_resource has a new signature
info	[Changelog]   - Model RoleAssignmentCreateParameters no longer has parameter can_delegate
info	[Changelog]   - Model RoleAssignment no longer has parameter can_delegate
info	[Changelog]   - Model RoleAssignmentFilter no longer has parameter can_delegate
info	[Changelog]   - Removed operation RoleAssignmentsOperations.list
info	[Changelog]   - Model Principal has a new signature

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0d3d635. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️authorization/mgmt/2015-07-01/authorization [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2020-10-01-preview/authorization [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```

️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 18 items here, please refer to log for details.

info	[Changelog] - Function `RoleAssignmentsClient.DeletePreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.ListForResource` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string)` to `(context.Context, string, string, string, string, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.ListForScope` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.GetByIDPreparer` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.ListForResourcePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string)` to `(context.Context, string, string, string, string, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.Get` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.List` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.ListForResourceComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string)` to `(context.Context, string, string, string, string, string, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.ListComplete` parameter(s) have been changed from `(context.Context, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `RoleAssignmentsClient.ListForScopePreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string, string, string)`
info	[Changelog] - Struct `CustomErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog]
info	[Changelog] Total 22 breaking change(s), 0 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]

️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 0d3d635. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0d3d635. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-11 07:18:41 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
cmderr	[generate.py] 2021-05-11 07:18:41 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-05-11 07:18:41 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.27 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[generate.py] 2021-05-11 07:19:20 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-05-11 07:19:20 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-11 07:19:20 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-11 07:19:20 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-11 07:19:20 INFO [POM][Skip] pom already has module sdk/authorization
cmderr	[generate.py] 2021-05-11 07:19:20 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-authorization-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-05-11 07:23:23 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
cmderr	[Inst] 2021-05-11 07:23:23 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-11 07:23:23 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-11 07:23:23 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-11 07:23:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14080/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️🔄 azure-sdk-for-net inProgress [Detail]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0d3d635. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md

️✔️@azure/arm-authorization [View full logs] [Release SDK Changes]

azure-arm-authorization-8.3.3.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
cmderr	[npmPack] created ./dist/arm-authorization.js in 253ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-22T17:01:14Z

Hi @jdhms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-04-22T17:01:14Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

ghost · 2021-05-09T16:00:31Z

Hi, @jdhms. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Azure#14080) * document tenantId query parameter for cross-tenant role assignment get and delete calls * parameter order

document tenantId query parameter for cross-tenant role assignment ge…

b0c935f

…t and delete calls

jdhms requested a review from stankovski as a code owner April 22, 2021 16:58

openapi-assignment-bot bot assigned qianwens Apr 22, 2021

openapi-workflow-bot bot added the FixS360 label Apr 22, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Apr 22, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Apr 22, 2021

parameter order

f8f290d

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 22, 2021

openapi-pipeline-app bot removed the BreakingChangeReviewRequired label Apr 22, 2021

ghost added the no-recent-activity label May 9, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 10, 2021

ghost removed the no-recent-activity label May 10, 2021

JeffreyRichter approved these changes May 10, 2021

View reviewed changes

qianwens merged commit 0d3d635 into Azure:master May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

document tenantId query parameter for cross-tenant role assignment ge… #14080

document tenantId query parameter for cross-tenant role assignment ge… #14080

jdhms commented Apr 22, 2021

openapi-workflow-bot bot commented Apr 22, 2021

openapi-pipeline-app bot commented Apr 22, 2021 •

edited

Loading

openapi-workflow-bot bot commented Apr 22, 2021

openapi-pipeline-app bot commented Apr 22, 2021 •

edited

Loading

openapi-workflow-bot bot commented Apr 22, 2021

openapi-workflow-bot bot commented Apr 22, 2021

ghost commented May 9, 2021

document tenantId query parameter for cross-tenant role assignment ge… #14080

document tenantId query parameter for cross-tenant role assignment ge… #14080

Conversation

jdhms commented Apr 22, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 22, 2021

openapi-pipeline-app bot commented Apr 22, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Apr 22, 2021

openapi-pipeline-app bot commented Apr 22, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Apr 22, 2021

openapi-workflow-bot bot commented Apr 22, 2021

ghost commented May 9, 2021

openapi-pipeline-app bot commented Apr 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 22, 2021 •

edited

Loading