Update V5 SDK tag with latest request #14341

ericshape · 2021-05-10T17:18:50Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

add LedgerDigestUploads.json, OutboundFirewallRules.json, RestorableDroppedDatabases.json, RestorableDroppedManagedDatabases.json to V5 SDK
add ReplicaitonLinks 2017 Read APIs into V5 SDK (- ./Microsoft.Sql/preview/2020-11-01-preview/ReplicationLinks.json)
create a legacy ReplicationLinks legacy file. and remove ReplicationLinks Read APIs from 2014-04-01 stable APIs (- Microsoft.Sql/stable/2014-04-01/replicationLinks_legacy.json). This action is same as revert this PR Use 2014-04-01 replication link specs in V5 SDK #14058

The ARMFeedback changes might not be a correct tag.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-05-10T17:18:53Z

Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-05-10T17:18:53Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-10T17:18:54Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 15 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- sql/resource-manager/readme.md tag:package-composite-v5
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- sql/resource-manager/readme.md tag:package-composite-v5

The following errors/warnings are introduced by current PR:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'LedgerDigestUploads_CreateOrUpdate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L73
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'LedgerDigestUploads_Disable' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L184
⚠️ R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Property name: backupStorageRedundancy Location: Microsoft.Sql/preview/2021-02-01-preview/RestorableDroppedDatabases.json#L165
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LedgerDigestUploadsModel'. Consider using the plural form of 'LedgerDigestUploads' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L25
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LedgerDigestUploadsModel'. Consider using the plural form of 'LedgerDigestUploads' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L78
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LedgerDigestUploadsModel'. Consider using the plural form of 'LedgerDigestUploads' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L144
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LedgerDigestUploadsModel'. Consider using the plural form of 'LedgerDigestUploads' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L189
⚠️ R4000 - ParameterDescriptionRequired	'ledgerDigestUploads' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L36
⚠️ R4000 - ParameterDescriptionRequired	'ledgerDigestUploads' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L89
⚠️ R4000 - ParameterDescriptionRequired	'parameters' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.Sql/preview/2021-02-01-preview/LedgerDigestUploads.json#L102

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R2020 - RequiredPropertiesMissingInResourceModel	Model definition 'FirewallRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json#L308
`❌` R2020 - RequiredPropertiesMissingInResourceModel	Model definition 'ProxyResourceWithWritableName' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Sql/preview/2020-11-01-preview/FirewallRules.json#L298
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/backups_legacy.json#L52
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/backups_legacy.json#L88
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/connectionPolicies.json#L57
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/connectionPolicies.json#L100
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/dataMasking.json#L63
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/dataMasking.json#L103
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/dataMasking.json#L170
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Sql/stable/2014-04-01/dataMasking.json#L218

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail]

The following tags are being changed in this PR

sql/resource-manager/readme.md#package-composite-v5

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"sql/resource-manager/readme.md",
"tag":"package-composite-v5",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"sql/resource-manager/readme.md",
"tag":"package-composite-v5",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v5", "details":"Error: Plugin pre-namer reported failure."
💬 AutorestCore/Exception	"readme":"sql/resource-manager/readme.md", "tag":"package-composite-v5", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-05-10T17:18:54Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c42a52a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md

️✔️@azure/arm-sql [View full logs] [Release SDK Changes]

azure-arm-sql-7.0.2.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
cmderr	[npmPack] created ./dist/arm-sql.js in 2.6s

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c42a52a. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sql/mgmt/2014-04-01/sql [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/sql/mgmt/v4.0/sql [View full logs] [Release SDK Changes] Breaking Change Detected