Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving swagger to stable #15530

Closed
wants to merge 4 commits into from
Closed

moving swagger to stable #15530

wants to merge 4 commits into from

Conversation

banggaurav
Copy link
Member

@banggaurav banggaurav commented Aug 5, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @banggaurav Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 5, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L35
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2044
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2091
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2197
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2274
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'TagRules_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L572
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'SubAccountTagRules_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1242
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'tagRules' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2172
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'singleSignOnConfigurations' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2252
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'accounts' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2017
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'tagRules' with immediate parent 'LogzMonitorResource', must have a list by immediate parent operation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2172
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendingMetrics
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1727
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendingLogs
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1735
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1795
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2136
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2140
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendActivityLogs
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L2144
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L268
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L327
    ⚠️ R4000 - ParameterDescriptionRequired 'ruleSetName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L486
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L492
    ⚠️ R4000 - ParameterDescriptionRequired 'ruleSetName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L542
    ⚠️ R4000 - ParameterDescriptionRequired 'ruleSetName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L591
    ⚠️ R4000 - ParameterDescriptionRequired 'configurationName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L706
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L712
    ⚠️ R4000 - ParameterDescriptionRequired 'configurationName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L768
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L877
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1044
    ⚠️ R4000 - ParameterDescriptionRequired 'ruleSetName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1153
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Logz/stable/2020-10-01/logz.json#L1159
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
    "tag":"package-2020-10-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
    "tag":"package-2020-10-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"logz/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 5, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-logz - 1.0.0b1
    ️✔️azure-sdk-for-go - logz/mgmt/2020-10-01/logz - v56.1.0
    ️✔️azure-sdk-for-go - preview/logz/mgmt/2020-10-01-preview/logz - v56.1.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 247f9697f627df7376398bc878ab8ba8415eccf8. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-logz [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 247f9697f627df7376398bc878ab8ba8415eccf8. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-08-10 09:45:32 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-logz"
cmderr	[generate.py] 2021-08-10 09:45:32 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-08-10 09:45:32 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.34 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/logz/azure-resourcemanager-logz --java.namespace=com.azure.resourcemanager.logz   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/logz/resource-manager/readme.md
cmderr	[generate.py] 2021-08-10 09:45:57 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-08-10 09:45:57 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-08-10 09:45:57 INFO [POM][Skip] pom already has module azure-resourcemanager-logz
cmderr	[generate.py] 2021-08-10 09:45:57 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-08-10 09:45:57 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-08-10 09:45:57 INFO [POM][Success] Write to root pom
cmderr	[generate.py] Traceback (most recent call last):
cmderr	[generate.py]   File "eng/versioning/update_versions.py", line 126, in update_versions
cmderr	[generate.py]     raise ValueError('Invalid version type: {} for module: {}.\nFile={}\nLine={}'.format(version_type, module_name, target_file, line))
cmderr	[generate.py] ValueError: Invalid version type: external for module: org.apache.maven:maven-core.
cmderr	[generate.py] File=./eng/bomgenerator/pom.xml
cmderr	[generate.py] Line=      <version>3.5.4</version> <!-- {x-version-update;org.apache.maven:maven-core;external} -->
cmderr	[generate.py] 2021-08-10 09:47:16 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-logz [View full logs]  [Preview SDK Changes] 
      cmderr	[Inst] 2021-08-10 09:47:23 DEBUG Got artifact_id: azure-resourcemanager-logz
cmderr	[Inst] 2021-08-10 09:47:23 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-08-10 09:47:23 DEBUG Got artifact: azure-resourcemanager-logz-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-08-10 09:47:23 DEBUG Got artifact: azure-resourcemanager-logz-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-08-10 09:47:23 DEBUG Got artifact: azure-resourcemanager-logz-1.0.0-beta.1.jar
cmderr	[Inst] 2021-08-10 09:47:23 DEBUG Match jar package: azure-resourcemanager-logz-1.0.0-beta.1.jar
cmderr	[Inst] 2021-08-10 09:47:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15530/azure-sdk-for-java/azure-resourcemanager-logz/azure-resourcemanager-logz-1.0.0-beta.1.jar\" -o azure-resourcemanager-logz-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-logz -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-logz-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 247f9697f627df7376398bc878ab8ba8415eccf8. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️logz/mgmt/2020-10-01/logz [View full logs]  [Preview SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️preview/logz/mgmt/2020-10-01-preview/logz [View full logs]  
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 247f9697f627df7376398bc878ab8ba8415eccf8. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/logz/resource-manager/readme.md
    • ️✔️@azure/arm-logz [View full logs]  [Preview SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/microsoftLogz.js → ./dist/arm-logz.js...
cmderr	[npmPack] created ./dist/arm-logz.js in 312ms
    ️❌ azure-resource-manager-schemas failed [Detail]
    • ❌Failed [Logs] Generate from 247f9697f627df7376398bc878ab8ba8415eccf8. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /home/vsts/work/1/s/azure-resource-manager-schemas/generator/specs.ts:29
cmderr	[generateScript.sh]         throw new Error(`Unable to find readme '${readme}' in specs repo`);
cmderr	[generateScript.sh]               ^
cmderr	[generateScript.sh] Error: Unable to find readme '/home/vsts/work/1/s/azure-resource-manager-schemas_tmp/schm_azspc/specification/EnterpriseKnowledgeGraph/resource-manager/readme.md' in specs repo
cmderr	[generateScript.sh]     at Object.validateAndReturnReadmePath (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/specs.ts:29:15)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/cmd/generateall.ts:48:24
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 247f9697f627df7376398bc878ab8ba8415eccf8. Azure CLI Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/logz/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Monitors/put/Monitors_Create
cmderr	[Autorest]     - name: /Monitors/get/Monitors_Get
cmderr	[Autorest]     - name: /Monitors/get/Monitors_List
cmderr	[Autorest]     - name: /Monitors/get/Monitors_ListByResourceGroup
cmderr	[Autorest]     - name: /Monitors/patch/Monitors_Update
cmderr	[Autorest]     - name: /Monitors/post/MainAccount_VMHosts_Update
cmderr	[Autorest]     - name: /Monitors/post/MonitoredResources_List
cmderr	[Autorest]     - name: /Monitor/post/MainAccount_VMHosts_List
cmderr	[Autorest]     - name: /Monitor/post/MainAccount_VMHosts_Payload
cmderr	[Autorest]     - name: /Monitor/post/MainAccount_VMHosts_Update
cmderr	[Autorest]     - name: /SingleSignOn/put/SingleSignOnConfigurations_CreateOrUpdate
cmderr	[Autorest]     - name: /SingleSignOn/get/SingleSignOnConfigurations_Get
cmderr	[Autorest]     - name: /SingleSignOn/get/SingleSignOnConfigurations_List
cmderr	[Autorest]     - name: /SubAccount/put/subAccount_Create
cmderr	[Autorest]     - name: /SubAccount/get/SubAccount_Get
cmderr	[Autorest]     - name: /SubAccount/get/SubAccount_List
cmderr	[Autorest]     - name: /SubAccount/patch/SubAccount_Update
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_MonitoredResources_List
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_VMHosts_List
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_VMHosts_Payload
cmderr	[Autorest]     - name: /SubAccount/post/SubAccount_VMHosts_Update
cmderr	[Autorest]     - name: /SubAccountTagRules/put/SubAccountTagRules_CreateOrUpdate
cmderr	[Autorest]     - name: /SubAccountTagRules/get/SubAccountTagRules_Get
cmderr	[Autorest]     - name: /SubAccountTagRules/get/SubAccountTagRules_List
cmderr	[Autorest]     - name: /SubAccountTagRules/delete/TagRules_Delete
cmderr	[Autorest]     - name: /SubAccount/delete/SubAccount_Delete
cmderr	[Autorest]     - name: /TagRules/put/TagRules_CreateOrUpdate
cmderr	[Autorest]     - name: /TagRules/get/TagRules_Get
cmderr	[Autorest]     - name: /TagRules/get/TagRules_List
cmderr	[Autorest]     - name: /TagRules/delete/TagRules_Delete
cmderr	[Autorest]     - name: /Monitors/delete/Monitors_Delete
cmderr	[Autorest] --------------------------------------------------------
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @banggaurav, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    This was referenced Aug 5, 2021
    Draft
    Draft
    Draft
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 5, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @banggaurav your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    This was referenced Aug 5, 2021
    Draft
    Draft
    @raych1 raych1 assigned jianyexi and unassigned raych1 Aug 6, 2021
    @openapi-workflow-bot
    Copy link

    Hi @banggaurav, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @jianyexi jianyexi removed their assignment Aug 10, 2021
    @banggaurav
    Copy link
    Member Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ruowan
    Copy link
    Member

    ruowan commented Aug 11, 2021

    You could ignore azure resource schema validation. It doesn't block your PR review and merge

    @ArcturusZhang
    Copy link
    Member

    Closed this in favor of #15598 since they are identical and ARM review has been started on that.

    @JackTn
    Copy link
    Member

    JackTn commented Jun 16, 2022

    Hi, @banggaurav. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn JackTn deleted the logz/movelogztostable branch July 5, 2022 01:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @00Kai0 00Kai0 Awaiting requested review from 00Kai0

    @ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

    @jsntcy jsntcy Awaiting requested review from jsntcy

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    @RAY-316 RAY-316 Awaiting requested review from RAY-316

    Assignees

    @ruowan ruowan

    Labels
    WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @banggaurav @ruowan @ArcturusZhang @JackTn @raych1 @jianyexi