-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API preview version 2021-06-01-preview changes #15646
New API preview version 2021-06-01-preview changes #15646
Conversation
Hi, @sameerpatro Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L4388 |
R4037 - MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L4398 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L2841 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L3087 |
The child tracked resource, 'jobs' with immediate parent 'DataBoxEdgeDevice', must have a list by immediate parent operation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L5682 |
|
The child tracked resource, 'operationsStatus' with immediate parent 'DataBoxEdgeDevice', must have a list by immediate parent operation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L5682 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L6346 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L6411 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L6898 |
|
The resource 'Node' does not have get operation, please add it. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L6761 |
|
'SubscriptionProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8049 |
|
'SubscriptionRegisteredFeatures' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8073 |
|
'state' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L5215 |
|
'registrationDate' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L5229 |
|
'subscriptionId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L5232 |
|
'tenantId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8052 |
|
'locationPlacementId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8055 |
|
'quotaId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8058 |
|
'serializedDetails' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8061 |
|
'registeredFeatures' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8064 |
|
'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8076 |
|
'state' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DataBoxEdge/preview/2021-06-01-preview/databoxedge.json#L8079 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌
Cross-Version Breaking Changes: 19 Errors, 75 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2021-06-01-preview/databoxedge.json compared with base:stable/2021-02-01/databoxedge.json
- current:preview/2021-06-01-preview/databoxedge.json compared with base:preview/2021-02-01-preview/databoxedge.json
Only 30 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 24 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'ArcAddon' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from ArcAddon" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'ArcAddon' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from ArcAddon" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'ArcAddon' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from ArcAddon" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'CloudEdgeManagementRole' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from CloudEdgeManagementRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'CloudEdgeManagementRole' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from CloudEdgeManagementRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'CloudEdgeManagementRole' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from CloudEdgeManagementRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'FileEventTrigger' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from FileEventTrigger" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'FileEventTrigger' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from FileEventTrigger" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'FileEventTrigger' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from FileEventTrigger" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'IoTAddon' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTAddon" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'IoTAddon' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTAddon" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'IoTAddon' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTAddon" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'IoTRole' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'IoTRole' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'IoTRole' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'KubernetesRole' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from KubernetesRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'KubernetesRole' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from KubernetesRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'KubernetesRole' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from KubernetesRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'MECRole' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from MECRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'MECRole' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from MECRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'MECRole' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from MECRole" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'PeriodicTimerEventTrigger' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from PeriodicTimerEventTrigger" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'PeriodicTimerEventTrigger' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from PeriodicTimerEventTrigger" |
|
"readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Schema 'PeriodicTimerEventTrigger' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from PeriodicTimerEventTrigger" |
|
💬 AutorestCore/Exception | "readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"databoxedge/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Thank you for your contribution sameerpatro! We will review the pull request and get back to you soon. |
Swagger Generation Artifacts
|
Hi @sameerpatro, Your PR has some issues. Please fix the CI sequentially by following the order of
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.