Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Microsoft.security insights 2021 09 01 preview with main #15766

Conversation

anat-gilenson
Copy link
Contributor

@anat-gilenson anat-gilenson commented Aug 24, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

RAY-316 and others added 30 commits August 2, 2021 15:17
* add the missing $

* remove one useless directive

* fix

* remove the hack for track 2 and add comments for reasons

* add one of the directive back to readme.go.md

* add some comment to explain this more

* fix
…1 to master (Azure#15370)

* Adds base for updating Microsoft.ContainerService from version stable/2021-05-01 to version 2021-07-01

* Updates readme

* Updates API version in new specs and examples

* Modify Swagger to fix the problem of automatically generating ugly names in track 2 (Azure#14758)

* update swagger to fix track 2 autogenerated naming issue

* fix

* update readme for sdk generation

* fix lint error

* Trigger Build

* update readme

* Improve AKS Swagger documentation (Azure#14957)

* Improve AKS Swagger documentation

  - This change has already been merged in master
    for the 2021-05-01 API version.

* Fix up custom words

* aks: replace CloudError with ManagedClusterPodIdentityProvisioningError for AAD pod identity provisioning spec (Azure#15033)

* fix: decouple pod identity provisioning error from cloud error

* drop extra external mark

* fix linting issue

* fix reference

* Dev containerservice microsoft.container service 2021 07 01: add SecurityProfile (Azure#15035)

* Add SecurityProfile to ManagedClusters

* spaces

* Space

* spaces

* json formatting

* move from params to defs

* :)

* just another

* now with npm

* Descriptions update for AKS July API (Azure#15074)

* allow disabling of runcommand (Azure#15092)

* allow disabling of runcommand

* format error

* format with example

* change enable to disable

* Revert "allow disabling of runcommand (Azure#15092)" (Azure#15147)

This reverts commit ec3e241.

* [AKS] Add NATGatewayProfile to 2021-07-01 API (Azure#15154)

* [AKS] Add NATGatewayProfile to 2021-07-01 API

* Fix linter errors

Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com>

* Add scaleDownMode to agent pool properties (Azure#15124)

* add scale down mode

* address comments

* fix markdown link

* update proper api version

* Resolve python markdown conflict & fix typo (Azure#15402)

* resolve python conflict & fix typo

* resolve conflict

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Co-authored-by: hbc <bcxxxxxx@gmail.com>
Co-authored-by: Or Parnes <orparnes@gmail.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
Co-authored-by: Kaiqi Zhang <kaiqzhan@microsoft.com>
Co-authored-by: Marwan Ahmed <marwanad@microsoft.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Azure#15399)

* removing business rules(a feature for the future) which was added by mistake.

* fixing style issues and a typo
…esInsights/preview directory (Azure#15394)

- Removing Azure Time Series Insights Preview API from docs as we have GA API since July 2021 and preview API will be depreciated.
…ents for cleaner codegen with datetime types (Azure#15454)

* add missing format date-time across map clients

* drop date-time format from quarter forecast date which comes with time but doesn't supply timezone info
…re#14982)

* Make value required for RandomBytes response

* format
* Update to use unique resource names to avoid collisions; Add SubscriptionId to ScaleUnits route

* Reverting use of common type apiversion to avoid breaking changes.

* Moving ApiVersion back to use common type
…gAlerts_API.json) (Azure#15163)

* Fix go/terraform package

* remove incompatible definitions

* Force trigger checks

* fix on go package-2021-07

* fix condition
* adding 05-preview for diff

* adding 06 preview

* Add SystemData support in ProviderHub 2021-06-01-preview version

* Tab to spaces + address comment

* fixing validation errors

* add properties back

* Fix readme

* Fix swagger

* prettier check

* Fix json

Co-authored-by: Sanjai Ganesh Jeenagiri <sanjaiganesh@users.noreply.github.com>
Co-authored-by: REDMOND\lakshv <lakshv@microsoft.com>
Co-authored-by: shenshengkafei <wudiadi1111@gmail.com>
* add missing types

* change reference to resource and resourceWithEtag

* extract userInfo to common file

* .

* add composite tag

* add missing dataConnectorsCheckRequirements

* add dataConnectorsCheckRequirements to readme

* fix readme

* .

* fix errors in readme

* add missing type

* add missing types

* .

* .

* remove changes with resource, resourceWithEtag, new tag

* .

* remove object

* revert userInfo changes

* fix true
* Update web readme and readme.python

* Update readme
Co-authored-by: Orel Kayam <orkayam@microsoft.com>
…e#15480)

* [Maps] Add Creator v1 deprecation notice.

* [Maps] 'dataSharingLevel' is not available - remove text reference for UDI

* Add missing notices

* [Maps] Update the v1 creator service deprecation notice link

* [Maps] Update Creator v1 deprecation notice's hyperlink title.
* Add Threat Intellingence to Stable swagger

* Fix validation error for sharing parameters

* Fix validation

* Fix Validation

* Fix CloudError in ThreatIntelligence to fix linted error

* Resolve Conflict
* added properties.minorVersion for 2020-02-14-preview API swagger and examples

* add geoRedundantBackup and earliestRestoreDate

* add geoRedundantBackup and earliestRestoreDate 2

* Updated MaintenanceWindow standbyCount logBackupStorageSku availabilityZone
…RM RPC (Azure#15410)

* Change PATCH async response from 201 to 202 according to ARM RPC

* Add schema

Co-authored-by: Amit Elran <amelran@microsoft.com>
…rties with readOnly (Azure#15255)

* Microsoft.BareMetalInfrastructure: correctly annotate read-only properties with readOnly

* Use multi-api and namespace formats for Go SDK like hanaonazure does
This was referenced Aug 24, 2021
@anat-gilenson anat-gilenson deleted the Microsoft.SecurityInsights-2021-09-01-preview branch August 24, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.