add new version 2021-09-01-preview for signalr #15864

wanlwanl · 2021-08-31T07:16:25Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-08-31T07:16:27Z

Hi, @wanlwanl Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-08-31T07:16:28Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-08-31T07:16:29Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 2 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- signalr/resource-manager/readme.md tag:package-2021-09-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- signalr/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'SignalR_ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L1030
⚠️ R2057 - InvalidSkuModel	Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties. Location: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L2173

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L2009
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableAadAuth Location: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L2014
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L1456

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌Cross-Version Breaking Changes: 13 Errors, 2 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2021-09-01-preview/signalr.json compared with base:stable/2020-05-01/signalr.json
- current:preview/2021-09-01-preview/signalr.json compared with base:preview/2021-06-01-preview/signalr.json

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SignalRServiceName' removed or renamed? New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L2349:3 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L1696:3
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L651:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L751:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L355:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L70:11 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L70:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L581:11 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L250:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L728:11 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L436:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L282:11 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L531:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L385:11 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L631:11
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v2/types.json#L289:9 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L963:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v2/types.json#L294:9 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L967:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v2/types.json#L299:9 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L971:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: common-types/resource-management/v2/types.json#L304:9 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L975:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L2048:9 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L1050:9
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.SignalRService/preview/2021-09-01-preview/signalr.json#L1924:5 Old: Microsoft.SignalRService/stable/2020-05-01/signalr.json#L1171:5

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

signalr/resource-manager/readme.md#package-2021-09-01-preview

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-31T07:16:29Z

Hi, @wanlwanl your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-pipeline-app · 2021-08-31T07:16:29Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - signalr/mgmt/2020-05-01/signalr - v57.2.0
️✔️azure-sdk-for-go - signalr/mgmt/2018-10-01/signalr - v57.2.0
️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-09-01-preview/signalr - v57.2.0
️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-06-01-preview/signalr - v57.2.0
️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-04-01-preview/signalr - v57.2.0
️✔️azure-sdk-for-go - preview/signalr/mgmt/2020-07-01-preview/signalr - v57.2.0
️✔️azure-sdk-for-go - preview/signalr/mgmt/2018-03-01-preview/signalr - v57.2.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-signalr - 1.0.0b2

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 88f48ab. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/signalr/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SignalR [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.SignalR.1.1.3-preview.nupkg
- Microsoft.Azure.Management.SignalR.1.1.3-preview.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 88f48ab. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-signalr [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model SignalRResource has a new parameter disable_aad_auth
info	[Changelog]   - Model SignalRResource has a new parameter host_name_prefix
info	[Changelog]   - Model SignalRResource has a new parameter public_network_access
info	[Changelog]   - Model SignalRResource has a new parameter disable_local_auth
info	[Changelog]   - Added operation SignalROperations.list_skus

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 88f48ab. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-09-15 06:52:37 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-signalr;1.0.0-beta.2;1.0.0-beta.3"
cmderr	[generate.py] 2021-09-15 06:52:37 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
cmderr	[generate.py] 2021-09-15 06:52:37 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/signalr/azure-resourcemanager-signalr --java.namespace=com.azure.resourcemanager.signalr   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/signalr/resource-manager/readme.md
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-signalr
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [POM][Skip] pom already has module azure-resourcemanager-signalr
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [POM][Skip] pom already has module sdk/signalr
cmderr	[generate.py] 2021-09-15 06:53:10 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-signalr [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-09-15 06:54:44 DEBUG Got artifact_id: azure-resourcemanager-signalr
cmderr	[Inst] 2021-09-15 06:54:44 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-09-15 06:54:44 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.3-javadoc.jar
cmderr	[Inst] 2021-09-15 06:54:44 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.3-sources.jar
cmderr	[Inst] 2021-09-15 06:54:44 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.3.jar
cmderr	[Inst] 2021-09-15 06:54:44 DEBUG Match jar package: azure-resourcemanager-signalr-1.0.0-beta.3.jar
cmderr	[Inst] 2021-09-15 06:54:44 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15864/azure-sdk-for-java/azure-resourcemanager-signalr/azure-resourcemanager-signalr-1.0.0-beta.3.jar\" -o azure-resourcemanager-signalr-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-signalr -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-signalr-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 88f48ab. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/signalr/resource-manager/readme.md

️✔️@azure/arm-signalr [View full logs] [Release SDK Changes]

azure-arm-signalr-4.2.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/signalRManagementClient.js → ./dist/arm-signalr.js...
cmderr	[npmPack] created ./dist/arm-signalr.js in 408ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 88f48ab. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️signalr/mgmt/2020-05-01/signalr [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Trace`
info	[Changelog] - New function `ResourceSku.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `CreateOrUpdateProperties.MarshalJSON() ([]byte, error)`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]

️✔️signalr/mgmt/2018-10-01/signalr [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/signalr/mgmt/2021-09-01-preview/signalr [View full logs]
```
info	[Changelog] This is a new package
```
️✔️preview/signalr/mgmt/2021-06-01-preview/signalr [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/signalr/mgmt/2021-04-01-preview/signalr [View full logs]
```
info	[Changelog] No exported changes
```

️✔️preview/signalr/mgmt/2020-07-01-preview/signalr [View full logs]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `ResourceSku.MarshalJSON() ([]byte, error)`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️✔️preview/signalr/mgmt/2018-03-01-preview/signalr [View full logs]
```
info	[Changelog] No exported changes
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 88f48ab. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️signalr [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-31T07:18:18Z

Hi @wanlwanl, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

wanlwanl · 2021-09-01T10:27:32Z

WaitingForARMFeedback

majastrz · 2021-09-09T03:29:13Z

You haven't done this part, which makes it hard to review:

Can you provide a link to the previously approved API version, so I can see the delta more easily?

majastrz

Signed off from ARM side.

openapi-workflow-bot · 2021-09-09T05:13:27Z

Hi @wanlwanl, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

ArcturusZhang

Changes in readme.go.md LGTM

…1910) Create to sync Azure/azure-rest-api-specs#15864 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/signalr?expand=1)

* add new version 2021-09-01-preview for signalr * fix style * remove webpubsub * fix breaking change

add new version 2021-09-01-preview for signalr

0220a2c

wanlwanl requested review from juniwang and bjqian August 31, 2021 07:16

wanlwanl requested a review from ArcturusZhang as a code owner August 31, 2021 07:16

openapi-assignment-bot bot assigned leni-msft Aug 31, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 31, 2021

wanlwanl removed the request for review from bjqian August 31, 2021 07:18

This was referenced Aug 31, 2021

[AutoPR @azure/arm-signalr] add new version 2021-09-01-preview for signalr AzureSDKAutomation/azure-sdk-for-js#5984

Closed

[AutoPR signalr] add new version 2021-09-01-preview for signalr AzureSDKAutomation/azure-resource-manager-schemas#4608

Closed

fix style

9c45d03

remove webpubsub

ddf67ea

openapi-sdkautomation bot mentioned this pull request Sep 1, 2021

[AutoPR track2_azure-mgmt-signalr] add new version 2021-09-01-preview for signalr AzureSDKAutomation/azure-sdk-for-python#7175

Closed

juniwang approved these changes Sep 6, 2021

View reviewed changes

leni-msft assigned jianyexi and unassigned leni-msft Sep 7, 2021

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 9, 2021

majastrz approved these changes Sep 9, 2021

View reviewed changes

jianyexi added the BreakingChangeReviewRequired label Sep 9, 2021

ArcturusZhang reviewed Sep 9, 2021

View reviewed changes

fix breaking change

7a3ef8b

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Sep 14, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 14, 2021

jianyexi merged commit 88f48ab into Azure:main Sep 15, 2021

LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022

add new version 2021-09-01-preview for signalr (Azure#15864)

7ae0556

* add new version 2021-09-01-preview for signalr * fix style * remove webpubsub * fix breaking change

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new version 2021-09-01-preview for signalr #15864

add new version 2021-09-01-preview for signalr #15864

wanlwanl commented Aug 31, 2021

openapi-workflow-bot bot commented Aug 31, 2021

openapi-workflow-bot bot commented Aug 31, 2021

openapi-pipeline-app bot commented Aug 31, 2021 •

edited

Loading

openapi-workflow-bot bot commented Aug 31, 2021

openapi-pipeline-app bot commented Aug 31, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 31, 2021

wanlwanl commented Sep 1, 2021

majastrz commented Sep 9, 2021

majastrz left a comment

openapi-workflow-bot bot commented Sep 9, 2021

ArcturusZhang left a comment

add new version 2021-09-01-preview for signalr #15864

add new version 2021-09-01-preview for signalr #15864

Conversation

wanlwanl commented Aug 31, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Aug 31, 2021

openapi-workflow-bot bot commented Aug 31, 2021

openapi-pipeline-app bot commented Aug 31, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Aug 31, 2021

openapi-pipeline-app bot commented Aug 31, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 31, 2021

wanlwanl commented Sep 1, 2021

majastrz commented Sep 9, 2021

majastrz left a comment

Choose a reason for hiding this comment

openapi-workflow-bot bot commented Sep 9, 2021

ArcturusZhang left a comment

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Aug 31, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 31, 2021 •

edited

Loading