Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new property for MetricSpecification #15926

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Add new property for MetricSpecification #15926

merged 1 commit into from
Sep 23, 2021

Conversation

gavinfish
Copy link
Contributor

@gavinfish gavinfish commented Sep 6, 2021 •
edited by raych1
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Add a new property sourceMdmNamespace for MetricSpecification definition. The definition is only for response and only used by Azure Monitor, not directly consumed by customer.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

9/6/2021

  1. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

9/6/2021

  1. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @gavinfish Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 6, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'sourceMdmNamespace' in response that was not found in the old version.
    New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3611:7
    Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3611:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'sourceMdmNamespace' in response that was not found in the old version.
    New: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L4195:7
    Old: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L4195:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'sourceMdmNamespace' in response that was not found in the old version.
    New: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L4275:7
    Old: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L4275:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'sourceMdmNamespace' in response that was not found in the old version.
    New: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L4166:7
    Old: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L4166:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Services_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L20
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L407
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L628
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Apps_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L788
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1110
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Certificates_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1395
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1655
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1994
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Services_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L60
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L447
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_UpdatePut' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L668
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Apps_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L838
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1156
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Certificates_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1438
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1701
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L2043
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Services_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L172
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_UpdatePatch' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L506
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_UpdatePatch' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L727
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Apps_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L956
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1280
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L1825
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Deployments_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2021-06-01-preview/appplatform.json#L2170
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Services_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L20
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ConfigServers_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L407
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'MonitoringSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L628
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Apps_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L788
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Bindings_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L1110
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'Certificates_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L1395
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'CustomDomains_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json#L1655
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-preview-2021-06",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-preview-2020-11",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-preview-2020-11",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-2020-07",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-2020-07",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-2019-05-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"appplatform/resource-manager/readme.md",
    "tag":"package-2019-05-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 6, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - appplatform/mgmt/2020-07-01/appplatform - v57.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2021-06-01-preview/appplatform - v57.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2020-11-01-preview/appplatform - v57.1.0
    ️✔️azure-sdk-for-go - preview/appplatform/mgmt/2019-05-01-preview/appplatform - v57.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-appplatform - 6.1.0
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from b8dba05. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
Resource not accessible by integration
HttpError: Resource not accessible by integration
    at /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@octokit/request@5.6.0/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async workflowPkgUpdatePR (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:346:21)
    at async Object.exports.workflowPkgMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:41:5)
    at async workflowHandleReadmeMd (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
    at async Object.exports.workflowMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
    at async Object.exports.sdkAutoMain (/home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:152:13)
    at async /home/vsts/work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.AppPlatform [View full logs]  
      error	Fatal error: Resource not accessible by integration
error	The following packages are still pending:
error		Az.AppPlatform
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b8dba05. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-appplatform [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model MetricSpecification has a new parameter source_mdm_namespace
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b8dba05. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-09-23 03:07:25 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-appplatform-generated"
cmderr	[generate.py] 2021-09-23 03:07:25 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-09-23 03:07:25 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appplatform/azure-resourcemanager-appplatform-generated --java.namespace=com.azure.resourcemanager.appplatform.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
cmderr	[generate.py] 2021-09-23 03:08:03 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-09-23 03:08:03 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-09-23 03:08:03 INFO [POM][Skip] pom already has module azure-resourcemanager-appplatform-generated
cmderr	[generate.py] 2021-09-23 03:08:03 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-09-23 03:08:03 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-09-23 03:08:03 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-appplatform-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-09-23 03:09:59 DEBUG Got artifact_id: azure-resourcemanager-appplatform-generated
cmderr	[Inst] 2021-09-23 03:09:59 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-09-23 03:09:59 DEBUG Got artifact: azure-resourcemanager-appplatform-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-09-23 03:09:59 DEBUG Got artifact: azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-09-23 03:09:59 DEBUG Match jar package: azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-09-23 03:09:59 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15926/azure-sdk-for-java/azure-resourcemanager-appplatform-generated/azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-appplatform-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-appplatform-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b8dba05. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.AppPlatform [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b8dba05. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
    • ️✔️@azure/arm-appplatform [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
cmderr	[npmPack] created ./dist/arm-appplatform.js in 538ms
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b8dba05. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️appplatform/mgmt/2020-07-01/appplatform [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Inbound`
info	[Changelog] - New const `Outbound`
info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
info	[Changelog] - New function `RequiredTraffic.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `RequiredTraffic`
info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️preview/appplatform/mgmt/2021-06-01-preview/appplatform [View full logs]  
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️preview/appplatform/mgmt/2020-11-01-preview/appplatform [View full logs]  
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
info	[Changelog]
    • ️✔️preview/appplatform/mgmt/2019-05-01-preview/appplatform [View full logs]  
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Outbound`
info	[Changelog] - New const `DeploymentResourceProvisioningStateDeleting`
info	[Changelog] - New const `Inbound`
info	[Changelog] - New const `Deleting`
info	[Changelog] - New function `RequiredTraffic.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleTrafficDirectionValues() []TrafficDirection`
info	[Changelog] - New struct `RequiredTraffic`
info	[Changelog] - New field `SourceMdmNamespace` in struct `MetricSpecification`
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog] - New field `RequiredTraffics` in struct `NetworkProfile`
info	[Changelog] - New field `Sku` in struct `DeploymentResource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 12 additive change(s).
info	[Changelog]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b8dba05. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️appplatform [View full logs] 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added FixS360 WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @gavinfish your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    This was referenced Sep 6, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @gavinfish
    Copy link
    Contributor Author

    Created work item https://msazure.visualstudio.com/One/_workitems/edit/10791904 for breaking change review.

    @Caoxuyang awareness for new API version

    @raych1 raych1 added BreakingChangeReviewRequired and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2021
    @openapi-workflow-bot
    Copy link

    Hi @gavinfish, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 13, 2021
    @gavinfish
    Copy link
    Contributor Author

    @raych1 please take a look, breaking change review is done.

    @raych1 raych1 merged commit b8dba05 into Azure:main Sep 23, 2021
    This was referenced Sep 23, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    @gavinfish gavinfish mentioned this pull request Sep 24, 2021
    Merged
    25 tasks
    Hardell pushed a commit to Hardell/azure-rest-api-specs that referenced this pull request Sep 27, 2021
    @gavinfish
    Add new property for MetricSpecification (Azure#15926)
    843589b
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @gavinfish @LeiWang3
    Add new property for MetricSpecification (Azure#15926)
    eecba11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raych1 raych1 raych1 approved these changes

    Assignees

    @raych1 raych1

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @gavinfish @raych1 @JeffreyRichter