Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] Add maxMessageSizeInKilobytes to swagger #16125

Conversation

yunhaoling
Copy link

@openapi-workflow-bot
Copy link

Hi, @yunhaoling Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 22, 2021

    Swagger Validation Report

    ️⌛BreakingChange pending [Detail]
    ️⌛LintDiff pending [Detail]
    ️⌛Avocado pending [Detail]
    ️⌛ModelValidation pending [Detail]
    ️⌛SemanticValidation pending [Detail]
    ️⌛Cross-Version Breaking Changes pending [Detail]
    ️⌛[Staging] SDK Track2 Validation pending [Detail]
    ️⌛[Staging] PrettierCheck pending [Detail]
    ️⌛[Staging] SpellCheck pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 22, 2021

    Swagger Generation Artifacts

    ️⌛[Staging] ApiDocPreview pending [Detail]
    ️⌛[Staging] SDK Breaking Change Tracking pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @yunhaoling yunhaoling marked this pull request as ready for review September 28, 2021 18:07
    @yunhaoling yunhaoling merged commit 78feacc into Azure:sb_dataplane_namespace Sep 28, 2021
    @yunhaoling yunhaoling deleted the yuling/sb/max-message-size-in-kilo-bytes branch September 28, 2021 18:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants