Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.LabServices to add version preview/2021-11-15-preview #16557

Conversation

nickdepinet
Copy link
Member

@nickdepinet nickdepinet commented Oct 26, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    2021-11
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    2021-11
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @nickdepinet Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: common-types/resource-management/v2/types.json#L359
    ⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.LabServices/preview/2021-11-15-preview/LabServices.json#L7
    ⚠️ R4006 - DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.LabServices/preview/2021-11-15-preview/OperationResults.json#L7
    ⚠️ R4021 - DescriptionAndTitleMissing 'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: common-types/resource-management/v2/types.json#L163
    ⚠️ R4021 - DescriptionAndTitleMissing 'sku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: common-types/resource-management/v2/types.json#L170
    ⚠️ R4021 - DescriptionAndTitleMissing 'plan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: common-types/resource-management/v2/types.json#L177
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-java inProgress [Detail]
    ️🔄 azure-sdk-for-go inProgress [Detail]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 663222efac7091340f39f8af82398d04ac33f43d. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/labservices/resource-manager/readme.md
    • ️✔️@azure/arm-labservices [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/labServicesClient.js → ./dist/arm-labservices.js...
      cmderr	[npmPack] created ./dist/arm-labservices.js in 404ms
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot
    Copy link

    Hi @nickdepinet, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-labservices - 1.0.0
    ️✔️azure-sdk-for-go - labservices/mgmt/2018-10-15/labservices - v58.3.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8fa31bd. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/labservices/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.LabServices [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8fa31bd. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-labservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model OperationResult has a new parameter name
      info	[Changelog]   - Model OperationResult has a new parameter end_time
      info	[Changelog]   - Model OperationResult has a new parameter percent_complete
      info	[Changelog]   - Model OperationResult has a new parameter id
      info	[Changelog]   - Model OperationResult has a new parameter start_time
      info	[Changelog]   - Model Lab has a new parameter security_profile
      info	[Changelog]   - Model Lab has a new parameter description
      info	[Changelog]   - Model Lab has a new parameter auto_shutdown_profile
      info	[Changelog]   - Model Lab has a new parameter title
      info	[Changelog]   - Model Lab has a new parameter lab_plan_id
      info	[Changelog]   - Model Lab has a new parameter system_data
      info	[Changelog]   - Model Lab has a new parameter connection_profile
      info	[Changelog]   - Model Lab has a new parameter virtual_machine_profile
      info	[Changelog]   - Model Lab has a new parameter roster_profile
      info	[Changelog]   - Model Lab has a new parameter state
      info	[Changelog]   - Model Lab has a new parameter network_profile
      info	[Changelog]   - Model User has a new parameter additional_usage_quota
      info	[Changelog]   - Model User has a new parameter system_data
      info	[Changelog]   - Model User has a new parameter display_name
      info	[Changelog]   - Model User has a new parameter registration_state
      info	[Changelog]   - Model User has a new parameter invitation_sent
      info	[Changelog]   - Model User has a new parameter invitation_state
      info	[Changelog]   - Added operation LabsOperations.begin_update
      info	[Changelog]   - Added operation LabsOperations.begin_create_or_update
      info	[Changelog]   - Added operation LabsOperations.begin_sync_group
      info	[Changelog]   - Added operation LabsOperations.list_by_resource_group
      info	[Changelog]   - Added operation LabsOperations.begin_publish
      info	[Changelog]   - Added operation LabsOperations.list_by_subscription
      info	[Changelog]   - Added operation Operations.list
      info	[Changelog]   - Added operation UsersOperations.begin_update
      info	[Changelog]   - Added operation UsersOperations.begin_invite
      info	[Changelog]   - Added operation UsersOperations.begin_create_or_update
      info	[Changelog]   - Added operation UsersOperations.list_by_lab
      info	[Changelog]   - Added operation group LabPlansOperations
      info	[Changelog]   - Added operation group SkusOperations
      info	[Changelog]   - Added operation group ImagesOperations
      info	[Changelog]   - Added operation group SchedulesOperations
      info	[Changelog]   - Added operation group UsagesOperations
      info	[Changelog]   - Added operation group OperationResultsOperations
      info	[Changelog]   - Added operation group VirtualMachinesOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter status of model OperationResult is now required
      info	[Changelog]   - Parameter location of model Lab is now required
      info	[Changelog]   - Parameter email of model User is now required
      info	[Changelog]   - Parameter email of model User is now required
      info	[Changelog]   - Operation UsersOperations.get has a new signature
      info	[Changelog]   - Operation UsersOperations.get has a new signature
      info	[Changelog]   - Operation UsersOperations.begin_delete has a new signature
      info	[Changelog]   - Operation LabsOperations.get has a new signature
      info	[Changelog]   - Operation LabsOperations.get has a new signature
      info	[Changelog]   - Operation LabsOperations.begin_delete has a new signature
      info	[Changelog]   - Model Resource no longer has parameter tags
      info	[Changelog]   - Model Resource no longer has parameter location
      info	[Changelog]   - Model Lab no longer has parameter user_quota
      info	[Changelog]   - Model Lab no longer has parameter unique_identifier
      info	[Changelog]   - Model Lab no longer has parameter created_date
      info	[Changelog]   - Model Lab no longer has parameter created_by_object_id
      info	[Changelog]   - Model Lab no longer has parameter invitation_code
      info	[Changelog]   - Model Lab no longer has parameter usage_quota
      info	[Changelog]   - Model Lab no longer has parameter user_access_mode
      info	[Changelog]   - Model Lab no longer has parameter max_users_in_lab
      info	[Changelog]   - Model Lab no longer has parameter created_by_user_principal_name
      info	[Changelog]   - Model Lab no longer has parameter latest_operation_result
      info	[Changelog]   - Model User no longer has parameter tags
      info	[Changelog]   - Model User no longer has parameter tenant_id
      info	[Changelog]   - Model User no longer has parameter unique_identifier
      info	[Changelog]   - Model User no longer has parameter given_name
      info	[Changelog]   - Model User no longer has parameter family_name
      info	[Changelog]   - Model User no longer has parameter latest_operation_result
      info	[Changelog]   - Model User no longer has parameter location
      info	[Changelog]   - Removed operation LabsOperations.update
      info	[Changelog]   - Removed operation LabsOperations.list
      info	[Changelog]   - Removed operation LabsOperations.register
      info	[Changelog]   - Removed operation LabsOperations.add_users
      info	[Changelog]   - Removed operation LabsOperations.create_or_update
      info	[Changelog]   - Removed operation Operations.get
      info	[Changelog]   - Removed operation UsersOperations.create_or_update
      info	[Changelog]   - Removed operation UsersOperations.update
      info	[Changelog]   - Removed operation UsersOperations.list
      info	[Changelog]   - Removed operation group ProviderOperationsOperations
      info	[Changelog]   - Removed operation group EnvironmentsOperations
      info	[Changelog]   - Removed operation group GlobalUsersOperations
      info	[Changelog]   - Removed operation group LabAccountsOperations
      info	[Changelog]   - Removed operation group GalleryImagesOperations
      info	[Changelog]   - Removed operation group EnvironmentSettingsOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8fa31bd. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-11-12 10:19:18 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-labservices;1.0.0-beta.1;1.0.0-beta.2"
      cmderr	[generate.py] 2021-11-12 10:19:18 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
      cmderr	[generate.py] 2021-11-12 10:19:18 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.40 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/labservices/azure-resourcemanager-labservices --java.namespace=com.azure.resourcemanager.labservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/labservices/resource-manager/readme.md
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-labservices
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [POM][Skip] pom already has module azure-resourcemanager-labservices
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [POM][Skip] pom already has module sdk/labservices
      cmderr	[generate.py] 2021-11-12 10:19:56 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-labservices [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-11-12 10:21:58 DEBUG Got artifact_id: azure-resourcemanager-labservices
      cmderr	[Inst] 2021-11-12 10:21:58 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-11-12 10:21:58 DEBUG Got artifact: azure-resourcemanager-labservices-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-11-12 10:21:58 DEBUG Match jar package: azure-resourcemanager-labservices-1.0.0-beta.2.jar
      cmderr	[Inst] 2021-11-12 10:21:58 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16557/azure-sdk-for-java/azure-resourcemanager-labservices/azure-resourcemanager-labservices-1.0.0-beta.2.jar\" -o azure-resourcemanager-labservices-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-labservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-labservices-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8fa31bd. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️labservices/mgmt/2018-10-15/labservices [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8fa31bd. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/labservices/resource-manager/readme.md
    • ️✔️@azure/arm-labservices [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/labServicesClient.js → ./dist/arm-labservices.js...
      cmderr	[npmPack] created ./dist/arm-labservices.js in 490ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8fa31bd. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2817) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
      cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
      cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:176:17)
      cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:293:21)
      cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:300:29
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2817) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2817) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️labservices [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @nickdepinet your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi, @nickdepinet your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @nickdepinet nickdepinet marked this pull request as ready for review October 26, 2021 20:49
    @nickdepinet nickdepinet added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 26, 2021
    @nickdepinet
    Copy link
    Member Author

    nickdepinet commented Oct 26, 2021

    Waiting on skus resource addition before review/merge
    update: added

    @nickdepinet nickdepinet removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 27, 2021
    @nickdepinet
    Copy link
    Member Author

    ready for review

    @j5lim j5lim self-requested a review October 27, 2021 17:09
    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved from ARM side.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 27, 2021
    @weidongxu-microsoft
    Copy link
    Member

    Let me know when you need it merged.

    @weidongxu-microsoft weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Oct 28, 2021
    @nickdepinet
    Copy link
    Member Author

    @weidongxu-microsoft - the manifest changes have rolled out, can you please merge this now? Thanks!

    @weidongxu-microsoft weidongxu-microsoft merged commit 8fa31bd into Azure:main Nov 12, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Nov 12, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …on preview/2021-11-15-preview (Azure#16557)
    
    * Adds base for updating Microsoft.LabServices from version preview/2021-10-01-preview to version 2021-11-15-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add locations/usages resource
    
    * fix usages id constraint to allow for empty string
    
    * add skus resource and examples
    
    * add integer format, fix quantity type from string to number
    
    * fix readonly property per arm feedback
    
    Co-authored-by: Nick Depinet <ndepinet@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants