Fix S360 items for FSPG swagger #16727

xunsun-commits · 2021-11-10T01:31:52Z

S360 items:
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=0219BFDB-C067-47C6-820C-1CA1EEBA406E
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=B9AD5DBC-61EA-4026-9F4A-71E5E8599121
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=1D576149-7BA8-4FC1-B9FD-3EFADF8D02F3
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=C39B35F6-8502-43A1-AA1B-600020A90B3D
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=1DFDD69E-13BB-4F3E-93E1-7F61DD2F1784
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=0A625C05-2A91-4205-BF8E-7FA90F63144A
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=61BAF9D5-A927-4DD2-A2DE-A25A1D94DEF9

Breaking change intake:
https://msazure.visualstudio.com/One/_workitems/edit/12564731

The fix are:

Add default value to many properties.
Remove the server.properties.tags property. The correct position is server.tags, but no need to explicitly add it, because TrackedResource already contains tags.
Change ServerPropertiesForUpdate.administratorLoginPassword to be secret type.
Add new properties to configuration.properties.
Add new properties to nameAvailability.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…I 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

… and 2021-06-01 APIs

…tenanceWindow

openapi-workflow-bot · 2021-11-10T01:31:54Z

Hi, @xunsun-commits Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-11-10T01:31:55Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-11-10T01:31:57Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-11-10T01:31:57Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️⌛SDK Breaking Change Tracking pending [Detail]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 1e3988d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.3.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-rdbms [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Configuration has a new parameter documentation_link
info	[Changelog]   - Model Configuration has a new parameter is_config_pending_restart
info	[Changelog]   - Model Configuration has a new parameter is_dynamic_config
info	[Changelog]   - Model Configuration has a new parameter is_read_only
info	[Changelog]   - Model Configuration has a new parameter unit
info	[Changelog]   - Model NameAvailability has a new parameter reason
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Server no longer has parameter tags_properties_tags

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 1e3988d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-01-05 08:53:53 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-postgresqlflexibleserver;1.0.0-beta.4;1.0.0-beta.5"
cmderr	[generate.py] 2022-01-05 08:53:53 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.5"
cmderr	[generate.py] 2022-01-05 08:53:53 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.44 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/postgresqlflexibleserver/azure-resourcemanager-postgresqlflexibleserver --java.namespace=com.azure.resourcemanager.postgresqlflexibleserver   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-postgresqlflexibleserver
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [POM][Skip] pom already has module azure-resourcemanager-postgresqlflexibleserver
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [POM][Skip] pom already has module sdk/postgresqlflexibleserver
cmderr	[generate.py] 2022-01-05 08:54:36 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-postgresqlflexibleserver [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-01-05 08:56:09 DEBUG Got artifact_id: azure-resourcemanager-postgresqlflexibleserver
cmderr	[Inst] 2022-01-05 08:56:09 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-01-05 08:56:09 DEBUG Got artifact: azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.5-javadoc.jar
cmderr	[Inst] 2022-01-05 08:56:09 DEBUG Got artifact: azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.5.jar
cmderr	[Inst] 2022-01-05 08:56:09 DEBUG Match jar package: azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.5.jar
cmderr	[Inst] 2022-01-05 08:56:09 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16727/azure-sdk-for-java/azure-resourcemanager-postgresqlflexibleserver/azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.5.jar\" -o azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.5.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresqlflexibleserver -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresqlflexibleserver-1.0.0-beta.5.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1e3988d. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️postgresql/mgmt/2021-06-01/postgresqlflexibleservers [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Tags` of struct `ServerProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ReasonAlreadyExists`
info	[Changelog] - New const `ReasonInvalid`
info	[Changelog] - New function `PossibleReasonValues() []Reason`
info	[Changelog] - New function `NameAvailability.MarshalJSON() ([]byte, error)`
info	[Changelog] - New field `Unit` in struct `ConfigurationProperties`
info	[Changelog] - New field `DocumentationLink` in struct `ConfigurationProperties`
info	[Changelog] - New field `IsDynamicConfig` in struct `ConfigurationProperties`
info	[Changelog] - New field `IsReadOnly` in struct `ConfigurationProperties`
info	[Changelog] - New field `IsConfigPendingRestart` in struct `ConfigurationProperties`
info	[Changelog] - New field `Reason` in struct `NameAvailability`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 6 additive change(s).

️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs]

Only show 18 items here, please refer to log for details.

info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 60 additive change(s).

️✔️preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs]

Only show 18 items here, please refer to log for details.

info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `HAEnabledEnumDisabled`
info	[Changelog] - New const `HAEnabledEnumEnabled`
info	[Changelog] - New function `PossibleGeoRedundantBackupEnumValues() []GeoRedundantBackupEnum`
info	[Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments`
info	[Changelog] - New field `GeoRedundantBackup` in struct `StorageProfile`
info	[Changelog] - New field `SourceResourceGroupName` in struct `ServerProperties`
info	[Changelog] - New field `MinorVersion` in struct `ServerProperties`
info	[Changelog] - New field `EarliestRestoreDate` in struct `ServerProperties`
info	[Changelog] - New field `StandbyCount` in struct `ServerProperties`
info	[Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties`
info	[Changelog] - New field `LogBackupStorageSku` in struct `ServerProperties`
info	[Changelog] - New field `SourceSubscriptionID` in struct `ServerProperties`
info	[Changelog] - New field `StandbyCount` in struct `ServerPropertiesForUpdate`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 8 additive change(s).

️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `Disabled` type has been changed from `HAEnabledEnum` to `GeoRedundantBackupEnum`
info	[Changelog] - Const `Enabled` type has been changed from `HAEnabledEnum` to `GeoRedundantBackupEnum`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `HAEnabledEnumEnabled`
info	[Changelog] - New const `HAEnabledEnumDisabled`
info	[Changelog] - New function `PossibleGeoRedundantBackupEnumValues() []GeoRedundantBackupEnum`
info	[Changelog] - New field `GeoRedundantBackup` in struct `StorageProfile`
info	[Changelog] - New field `StandbyCount` in struct `ServerProperties`
info	[Changelog] - New field `MinorVersion` in struct `ServerProperties`
info	[Changelog] - New field `LogBackupStorageSku` in struct `ServerProperties`
info	[Changelog] - New field `EarliestRestoreDate` in struct `ServerProperties`
info	[Changelog] - New field `StandbyCount` in struct `ServerPropertiesForUpdate`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 6 additive change(s).

️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs]

Only show 18 items here, please refer to log for details.

info	[Changelog] - New function `RecoverableServersClient.GetResponder(*http.Response) (RecoverableServerResource, error)`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 60 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1e3988d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armpostgresql [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️armpostgresqlflexibleservers [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `Tags` of struct `ServerProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ReasonAlreadyExists`
info	[Changelog] - New const `ReasonInvalid`
info	[Changelog] - New function `Reason.ToPtr() *Reason`
info	[Changelog] - New function `PossibleReasonValues() []Reason`
info	[Changelog] - New field `Reason` in struct `NameAvailability`
info	[Changelog] - New field `DocumentationLink` in struct `ConfigurationProperties`
info	[Changelog] - New field `IsDynamicConfig` in struct `ConfigurationProperties`
info	[Changelog] - New field `IsReadOnly` in struct `ConfigurationProperties`
info	[Changelog] - New field `Unit` in struct `ConfigurationProperties`
info	[Changelog] - New field `IsConfigPendingRestart` in struct `ConfigurationProperties`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 6 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 1e3988d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 1e3988d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️postgresql [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-11-10T01:34:10Z

Hi @xunsun-commits, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

...gresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json

openapi-workflow-bot · 2021-11-12T00:04:11Z

Hi @xunsun-commits, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-11-12T00:04:11Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

msyyc · 2022-01-05T03:51:18Z

/azp run

* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview * Change enum first letter to lower case * Change to upper case * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs * Fix S360 item by adding default value to backupRetentionDays and maintenanceWindow * Fix s360 bugs * Undo supportedIops change, will change in RP side * Fix NameAvailability and ConfigurationProperties s360 bugs * Fix s360 bug for CloudError * Undo CloudError fix * Fix string default value * Remove server.tags because TrackedResource already has tags

xunsun-commits and others added 9 commits August 23, 2021 11:31

Changed FSPG RestartParameter.failoverMode from string to enum for AP…

93c9a9a

…I 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

Change enum first letter to lower case

51127e6

Change to upper case

0e57051

Merge branch 'Azure:main' into main

1edbd71

Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview…

6cc3100

… and 2021-06-01 APIs

Merge branch 'Azure:main' into main

4c2ea90

Fix S360 item by adding default value to backupRetentionDays and main…

504ada6

…tenanceWindow

Merge branch 'Azure:main' into main

c11ec59

Fix s360 bugs

496db9f

openapi-assignment-bot bot assigned changlong-liu Nov 10, 2021

openapi-workflow-bot bot added the FixS360 label Nov 10, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Nov 10, 2021

openapi-sdkautomation bot mentioned this pull request Nov 10, 2021

[AutoPR postgresql/resource-manager] Fix S360 items for FSPG swagger AzureSDKAutomation/azure-resource-manager-schemas#5085

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Nov 10, 2021

openapi-sdkautomation bot mentioned this pull request Nov 10, 2021

[AutoPR track2_azure-mgmt-rdbms] Fix S360 items for FSPG swagger AzureSDKAutomation/azure-sdk-for-python#8054

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Nov 10, 2021

openapi-sdkautomation bot mentioned this pull request Nov 10, 2021

[AutoPR azure-resourcemanager-postgresqlflexibleserver] Fix S360 items for FSPG swagger AzureSDKAutomation/azure-sdk-for-java#11378

Closed

xunsun-commits added 3 commits November 10, 2021 11:35

Undo supportedIops change, will change in RP side

6831b88

Fix NameAvailability and ConfigurationProperties s360 bugs

056b3ff

Fix s360 bug for CloudError

f34c171

openapi-pipeline-app bot removed CI-BreakingChange-Go-V2 CI-BreakingChange-Python-Track2 labels Nov 10, 2021

Undo CloudError fix

22f9982

openapi-pipeline-app bot added CI-BreakingChange-Go-V2 CI-BreakingChange-Python-Track2 labels Nov 10, 2021

Fix string default value

c490554

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Nov 10, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 11, 2021

changlong-liu approved these changes Nov 11, 2021

View reviewed changes

jorgecotillo added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 11, 2021

leni-msft suggested changes Nov 11, 2021

View reviewed changes

...gresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json Outdated Show resolved Hide resolved

Remove server.tags because TrackedResource already has tags

07a0feb

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Nov 12, 2021

This was referenced Nov 12, 2021

[AutoPR @azure/arm-postgresql-flexible] Fix S360 items for FSPG swagger AzureSDKAutomation/azure-sdk-for-js#6626

Closed

[AutoPR postgresql] Fix S360 items for FSPG swagger AzureSDKAutomation/azure-resource-manager-schemas#5104

Closed

xunsun-commits requested a review from leni-msft November 12, 2021 00:08

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 12, 2021

leni-msft approved these changes Nov 13, 2021

View reviewed changes

leni-msft merged commit 1e3988d into Azure:main Nov 13, 2021

openapi-pipeline-app bot removed BreakingChangeReviewRequired CI-BreakingChange-Go labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix S360 items for FSPG swagger #16727

Fix S360 items for FSPG swagger #16727

xunsun-commits commented Nov 10, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 10, 2021

openapi-workflow-bot bot commented Nov 10, 2021

openapi-pipeline-app bot commented Nov 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2021 •

edited

Loading

openapi-workflow-bot bot commented Nov 10, 2021

openapi-workflow-bot bot commented Nov 12, 2021

openapi-workflow-bot bot commented Nov 12, 2021

msyyc commented Jan 5, 2022

Fix S360 items for FSPG swagger #16727

Fix S360 items for FSPG swagger #16727

Conversation

xunsun-commits commented Nov 10, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Nov 10, 2021

openapi-workflow-bot bot commented Nov 10, 2021

openapi-pipeline-app bot commented Nov 10, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 10, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Nov 10, 2021

openapi-workflow-bot bot commented Nov 12, 2021

openapi-workflow-bot bot commented Nov 12, 2021

msyyc commented Jan 5, 2022

xunsun-commits commented Nov 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2021 •

edited

Loading