[NetAppFiles] Anf 17315 net app files 2021 10 01 #17296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceDelete Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L1064 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response of operation:'Snapshots_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L1577 |
|
The response of operation:'AccountBackups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L2289 |
|
The response of operation:'Backups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L2429 |
|
The response of operation:'Snapshots_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L1624 |
|
The response of operation:'Backups_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L2476 |
|
The response of operation:'Snapshots_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L1687 |
|
The response of operation:'Backups_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L2545 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L489 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L797 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L1073 |
|
The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L40 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L3489 |
|
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L3509 |
|
The schema 'OperationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L3541 |
|
The schema 'ServiceSpecification' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L3550 |
|
The schema 'MetricSpecification' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L3569 |
|
The schema 'Dimension' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L3669 |
|
The schema 'dataProtection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L4705 |
|
The schema 'exportPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L4565 |
|
The schema 'dataProtection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L5210 |
|
The schema 'exportPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L5190 |
|
The schema 'cloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L6315 |
|
The schema 'cloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L6325 |
| 'GET' operation 'Volumes_ReplicationStatus' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L1220 |
|
| Based on the response model schema, operation 'SnapshotPolicies_ListVolumes' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L2111 |
|
| The child tracked resource, 'capacityPools' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L4191 |
|
| The child tracked resource, 'volumes' with immediate parent 'capacityPool', must have a list by immediate parent operation. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L4443 |
|
| The child tracked resource, 'snapshots' with immediate parent 'volume', must have a list by immediate parent operation. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L5350 |
|
| The child tracked resource, 'snapshotPolicies' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L5462 |
|
| The child tracked resource, 'accountBackups' with immediate parent 'netAppAccount', must have a list by immediate parent operation. Location: Microsoft.NetApp/stable/2021-10-01/netapp.json#L5785 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 19 Errors, 88 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-10-01/netapp.json compared with base:stable/2021-08-01/netapp.json
- current:stable/2021-10-01/netapp.json compared with base:preview/2021-04-01-preview/netapp.json
The following breaking changes are detected by comparison with latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
This was referenced Jan 10, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This should use POST. Refers to: specification/netapp/resource-manager/Microsoft.NetApp/stable/2021-10-01/netapp.json:1259 in 1aade10. [](commit_id = 1aade10, deletion_comment = False) |
j5lim
added
the
ARMChangesRequested
|
@audunn Got it. I think it's fine to keep them, but please request breaking change review following Action in #17296 (comment) because there're quite several other "Cross-Version Breaking Changes" |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-BreakingChange-Go-V2
CI-BreakingChange-Python-Track2
labels
|
@audunn looks some required parameters (which are present at path level in the previous version) were removed from below 'path' , please confirm it: |
openapi-pipeline-app
bot
added
CI-BreakingChange-Go-V2
CI-BreakingChange-Python-Track2
and removed
CI-FixRequiredOnFailure
labels
JeffreyRichter
added
the
Approved-BreakingChange
This was referenced Feb 9, 2022
Closed
Closed
Closed
Closed
Closed
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
* Add folder for api-version 2021-10-01 * Apply 2021-10-01 Changes * Remove snapshotSingleFile restore example * Revert vs code change to settings * Add unixPermissions to volumePatchProperties * Remove volume Relocation from 2021-10-01 * Remove zones from this api-version * Add Snapshot restoreFiles * Fix newly added validation issue MISSING_PATH_PARAMETER_DEFINITION * Remodel list Replications * Remove listReplication for api-version 2021-10-01 * Fix quotaLimits in examples * Add subvolumes api * Add subvolumes to custom words * Add parentpath custom word * Revert operationId to Volumes_ReplicationStatus * subvolumeProperties size write-only * Revert "subvolumeProperties size write-only" This reverts commit 243bb48. * subvolumeProperties size write-only take2 * prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds api-version 2021-10-01 for ANF
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.