Fixing billing RP promotions S360 swagger issues #17451

rkapso · 2022-01-21T17:47:36Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…pecs

openapi-workflow-bot · 2022-01-21T17:47:38Z

Hi, @rkapso Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2022-01-21T17:47:39Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-01-21T17:47:40Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 4 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:Microsoft.Billing/preview/2020-09-01-preview compared with base:Microsoft.Billing/preview/2020-09-01-preview
- current:Microsoft.Billing/preview/2020-11-01-preview compared with base:Microsoft.Billing/preview/2020-11-01-preview
- current:Microsoft.Billing/stable/2020-05-01 compared with base:Microsoft.Billing/stable/2020-05-01

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'details' renamed or removed? New: Microsoft.Billing/stable/2020-05-01/billingOperations.json#L129:7 Old: Microsoft.Billing/stable/2020-05-01/billing.json#L4933:7
`❌` Runtime Exception	"new":"https://github.com/Azure/azure-rest-api-specs/blob/bc3817ebda1befe36385d1fd496c9de527b9a6a2/specification/billing/resource-manager/Microsoft.Billing/preview/2020-09-01-preview", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/billing/resource-manager/Microsoft.Billing/preview/2020-09-01-preview", "details":"Command failed: node /home/vsts/work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.25/common/temp/node_modules/.pnpm/@Azure+oad@0.9.3/node_modules/autorest/dist/app.js /tmp/readme.oad.new.md --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nFATAL: swagger-document/compose - FAILED\nFATAL: Error: '$.parameters.apiVersionParameter.description' has incompatible values (---\n -\n The version of the API to be used with the client request. The current version\n is 2020-05-01.\n, ---\n -\n The version of the API to be used with the client request. The current version\n is 2019-10-01-preview.\n).\n Error: '$.parameters.apiVersionParameter.description' has incompatible values (---\n -\n The version of the API to be used with the client request. The current version\n is 2020-05-01.\n, ---\n -\n The version of the API to be used with the client request. The current version\n is 2019-10-01-preview.\n).\n"
`❌` Runtime Exception	"new":"https://github.com/Azure/azure-rest-api-specs/blob/bc3817ebda1befe36385d1fd496c9de527b9a6a2/specification/billing/resource-manager/Microsoft.Billing/preview/2020-11-01-preview", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/billing/resource-manager/Microsoft.Billing/preview/2020-11-01-preview", "details":"Command failed: node /home/vsts/work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.25/common/temp/node_modules/.pnpm/@Azure+oad@0.9.3/node_modules/autorest/dist/app.js /tmp/readme.oad.new.md --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nFATAL: swagger-document/compose - FAILED\nFATAL: Error: '$.parameters.apiVersionParameter.description' has incompatible values (---\n -\n The version of the API to be used with the client request. The current version\n is 2020-05-01.\n, ---\n -\n The version of the API to be used with the client request. The current version\n is 2019-10-01-preview.\n).\n Error: '$.parameters.apiVersionParameter.description' has incompatible values (---\n -\n The version of the API to be used with the client request. The current version\n is 2020-05-01.\n, ---\n -\n The version of the API to be used with the client request. The current version\n is 2019-10-01-preview.\n).\n"
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Billing/stable/2020-05-01/billingOperations.json#L37:13 Old: Microsoft.Billing/stable/2020-05-01/billing.json#L2656:13
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Billing/stable/2020-05-01/billingOperations.json#L88:9 Old: Microsoft.Billing/stable/2020-05-01/billing.json#L6137:9
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Billing/stable/2020-05-01/billingOperations.json#L120:9 Old: Microsoft.Billing/stable/2020-05-01/billing.json#L4960:9
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Billing/stable/2020-05-01/billingOperations.json#L55:5 Old: Microsoft.Billing/stable/2020-05-01/billing.json#L6164:5

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3106
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3106
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3106
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3197
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3197
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3197
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3282
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3282
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3282
`❌` R4037 - MissingTypeObject	The schema 'CustomerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3670
`❌` R4037 - MissingTypeObject	The schema 'CustomerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3670
`❌` R4037 - MissingTypeObject	The schema 'CustomerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3670
`❌` R4037 - MissingTypeObject	The schema 'CustomerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3710
`❌` R4037 - MissingTypeObject	The schema 'CustomerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3710
`❌` R4037 - MissingTypeObject	The schema 'CustomerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3710
`❌` R4037 - MissingTypeObject	The schema 'TransferProductRequestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3776
`❌` R4037 - MissingTypeObject	The schema 'TransferProductRequestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3776
`❌` R4037 - MissingTypeObject	The schema 'TransferProductRequestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3776
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3861
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3861
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3861
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3895
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3895
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3895
`❌` R4037 - MissingTypeObject	The schema 'BillingProfilesOnExpand' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3987
`❌` R4037 - MissingTypeObject	The schema 'BillingProfilesOnExpand' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3987
`❌` R4037 - MissingTypeObject	The schema 'BillingProfilesOnExpand' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L3987
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountUpdateRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4004
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountUpdateRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4004
`❌` R4037 - MissingTypeObject	The schema 'BillingAccountUpdateRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Billing/stable/2020-05-01/billing.json#L4004

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/billing/resource-manager/readme.md tag: specification/billing/resource-manager/readme.md#tag-package-2020-05

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 10 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Billing/preview/2020-09-01-preview/billingOperations.json#L20:14
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Billing/preview/2020-11-01-preview/billingOperations.json#L20:14
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Billing/stable/2020-05-01/billingOperations.json#L20:14
`❌` INVALID_TYPE	Expected type object but found type array Url: Microsoft.Billing/preview/2020-11-01-preview/billingPromotions.json#L218:22 ExampleUrl: preview/2020-11-01-preview/examples/GetPromotions.json#L7:15
`❌` INVALID_FORMAT	Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2 Url: Microsoft.Billing/stable/2020-05-01/billing.json#L5590:27 ExampleUrl: stable/2020-05-01/examples/BillingSubscriptionsListByCustomer.json#L44:33
`❌` INVALID_FORMAT	Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2 Url: Microsoft.Billing/stable/2020-05-01/billing.json#L5590:27 ExampleUrl: stable/2020-05-01/examples/BillingSubscriptionsListByBillingAccount.json#L41:33
`❌` INVALID_FORMAT	Object didn't pass validation for format date-time: 2018-02-30T17:32:28Z Url: Microsoft.Billing/stable/2020-05-01/billing.json#L5107:33 ExampleUrl: stable/2020-05-01/examples/BillingSubscriptionInvoicesList.json#L48:39
`❌` INVALID_FORMAT	Object didn't pass validation for format date-time: 2018-02-30T17:32:28Z Url: Microsoft.Billing/stable/2020-05-01/billing.json#L5107:33 ExampleUrl: stable/2020-05-01/examples/BillingSubscriptionInvoice.json#L26:35
`❌` INVALID_FORMAT	Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2 Url: Microsoft.Billing/stable/2020-05-01/billing.json#L5590:27 ExampleUrl: stable/2020-05-01/examples/BillingSubscriptionsListByBillingProfile.json#L42:33
`❌` INVALID_FORMAT	Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2 Url: Microsoft.Billing/stable/2020-05-01/billing.json#L5590:27 ExampleUrl: stable/2020-05-01/examples/BillingSubscriptionsListByInvoiceSection.json#L43:33

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-01-21T17:47:41Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - billing/mgmt/2021-10-01/billing - v61.5.0
❌azure-sdk-for-go - preview/billing/mgmt/2020-05-01-preview/billing - v61.5.0

+	Const `All` has been removed
+	Const `Reservation` has been removed
+	Field `MarketplacesEnabled` of struct `EnrollmentPolicies` has been removed

️✔️azure-sdk-for-go - preview/billing/mgmt/2018-11-01-preview/billing - v61.5.0
️✔️azure-sdk-for-go - preview/billing/mgmt/2018-03-01-preview/billing - v61.5.0
️✔️azure-sdk-for-go - preview/billing/mgmt/2017-04-24-preview/billing - v61.5.0
❌azure-sdk-for-go - preview/billing/mgmt/2017-02-27-preview/billing - v61.5.0

+	Package was removed

❌azure-sdk-for-go-track2 - armbilling - 0.3.0

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-billing - 6.0.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cdc8706. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Billing [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Billing.4.1.0.nupkg
- Microsoft.Azure.Management.Billing.4.1.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from cdc8706. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-billing [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Agreement has a new parameter billing_profiles_info
info	[Changelog]   - Model BillingSubscription has a new parameter suspension_reasons
info	[Changelog]   - Model InvoiceListResult has a new parameter total_count
info	[Changelog]   - Model InvoiceSection has a new parameter tags
info	[Changelog]   - Model ProductsListResult has a new parameter total_count
info	[Changelog]   - Model TransactionListResult has a new parameter total_count

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from cdc8706. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-15 05:42:25 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-billing;1.0.0-beta.2;1.0.0-beta.3"
cmderr	[generate.py] 2022-02-15 05:42:25 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
cmderr	[generate.py] 2022-02-15 05:42:25 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/billing/azure-resourcemanager-billing --java.namespace=com.azure.resourcemanager.billing   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-billing
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [POM][Skip] pom already has module azure-resourcemanager-billing
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [POM][Skip] pom already has module sdk/billing
cmderr	[generate.py] 2022-02-15 05:43:03 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-billing [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-02-15 05:44:42 DEBUG Got artifact_id: azure-resourcemanager-billing
cmderr	[Inst] 2022-02-15 05:44:42 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-15 05:44:42 DEBUG Got artifact: azure-resourcemanager-billing-1.0.0-beta.3-sources.jar
cmderr	[Inst] 2022-02-15 05:44:42 DEBUG Got artifact: azure-resourcemanager-billing-1.0.0-beta.3.jar
cmderr	[Inst] 2022-02-15 05:44:42 DEBUG Match jar package: azure-resourcemanager-billing-1.0.0-beta.3.jar
cmderr	[Inst] 2022-02-15 05:44:42 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17451/azure-sdk-for-java/azure-resourcemanager-billing/azure-resourcemanager-billing-1.0.0-beta.3.jar\" -o azure-resourcemanager-billing-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-billing -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-billing-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cdc8706. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️billing/mgmt/2021-10-01/billing [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️preview/billing/mgmt/2020-05-01-preview/billing [View full logs]

Only show 20 items here, please refer to log for details.

info	[Changelog] - New struct `ReservationsListResultIterator`
info	[Changelog] - New struct `ReservationsListResultPage`
info	[Changelog] - New field `BillingProfilesInfo` in struct `AgreementProperties`
info	[Changelog] - New field `Description` in struct `OperationDisplay`
info	[Changelog] - New field `MarketplaceEnabled` in struct `EnrollmentPolicies`
info	[Changelog] - New field `AccountOwnerEmail` in struct `EnrollmentAccountProperties`
info	[Changelog] - New field `TotalCount` in struct `TransactionListResult`
info	[Changelog] - New field `NotificationEmailAddress` in struct `AccountProperties`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `TotalCount` in struct `InvoiceSectionListResult`
info	[Changelog] - New field `TotalCount` in struct `InvoiceListResult`
info	[Changelog] - New field `Tags` in struct `InvoiceSectionProperties`
info	[Changelog] - New field `Tags` in struct `ProfileProperties`
info	[Changelog] - New field `TotalCount` in struct `ProductsListResult`
info	[Changelog] - New field `TotalCount` in struct `SubscriptionsListResult`
info	[Changelog] - New field `SuspensionReasons` in struct `SubscriptionProperties`
info	[Changelog] - New field `MiddleName` in struct `AddressDetails`
info	[Changelog] - New field `TotalCount` in struct `CustomerListResult`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 90 additive change(s).

️✔️preview/billing/mgmt/2018-11-01-preview/billing [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/billing/mgmt/2018-03-01-preview/billing [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/billing/mgmt/2017-04-24-preview/billing [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/billing/mgmt/2017-02-27-preview/billing [View full logs]
```
info	[Changelog] This package was removed
info	[Changelog]
```

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from cdc8706. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armbilling [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*EnrollmentAccountContext.UnmarshalJSON` has been removed
info	[Changelog] - Function `ProfileCreationRequest.MarshalJSON` has been removed
info	[Changelog] - Function `EnrollmentAccountContext.MarshalJSON` has been removed
info	[Changelog] - Function `ErrorDetails.MarshalJSON` has been removed
info	[Changelog] - Struct `EnrollmentAccountContext` has been removed
info	[Changelog] - Struct `ErrorDetails` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog] - Struct `ErrorSubDetailsItem` has been removed
info	[Changelog] - Struct `InvoiceSectionCreationRequest` has been removed
info	[Changelog] - Struct `ProfileCreationRequest` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `ProfileInfo`
info	[Changelog] - New field `BillingProfilesInfo` in struct `AgreementProperties`
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 3 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from cdc8706. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-billing [View full logs] [Release SDK Changes]

azure-arm-billing-4.1.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface BillingProfileInfo
info	[Changelog]   - Added Interface OperationsErrorDetails
info	[Changelog]   - Added Interface OperationsErrorResponse
info	[Changelog]   - Type Alias Agreement has a new parameter billingProfilesInfo
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from cdc8706. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️billing [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-01-21T17:49:54Z

Hi @rkapso, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

jianyexi · 2022-02-15T02:04:49Z

/azp run

azure-pipelines · 2022-02-15T02:04:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jianyexi · 2022-02-15T03:34:44Z

/azp run

azure-pipelines · 2022-02-15T03:34:53Z

Azure Pipelines successfully started running 1 pipeline(s).

ruowan · 2022-02-15T05:09:51Z

/azp run

azure-pipelines · 2022-02-15T05:10:00Z

Azure Pipelines successfully started running 1 pipeline(s).

* Adding 2020-09-Preview same as 11-preview * fixing lint issue * fixing model * fixing model * fixing model * pretify fix * fixing linting * more linting fix * fixing swagger correctness * Fixing swagger * fixing swagger * Adding operations API * fixing validation error * fixing version param * Fixing the operations API * fixing missing reference * fixing swagger model * fixing object type * fixing more swagge validations * removing operations * removing operations * fixing model * fixing path * fxing swagger

rkapso added 19 commits June 25, 2021 13:04

Adding 2020-09-Preview same as 11-preview

04ecc20

fixing lint issue

bcfcd50

fixing model

d4d13d6

fixing model

5dd5a0b

fixing model

547ae53

pretify fix

511b61c

fixing linting

05b7ffc

more linting fix

567b0ee

Merge branch 'Azure:master' into master

16a23d3

fixing swagger correctness

04154e5

Merge branch 'Azure:main' into master

d44c373

Fixing swagger

76c3bcf

fixing swagger

b0cfbc9

Adding operations API

a658172

Merge branch 'Azure:main' into master

7465635

fixing validation error

b77cdb7

Merge branch 'master' of https://github.com/KapsoGit/azure-rest-api-s…

10f804d

…pecs

fixing version param

6952a09

Fixing the operations API

f0454ff

rkapso requested review from asarkar84 and wilcobmsft as code owners January 21, 2022 17:47

openapi-assignment-bot bot assigned changlong-liu Jan 21, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 21, 2022

rkapso added 2 commits January 28, 2022 09:19

fixing path

dd65f0d

fxing swagger

bc3817e

openapi-pipeline-app bot added CI-BreakingChange-Go-V2 and removed NewApiVersionRequired labels Jan 31, 2022

openapi-workflow-bot bot added the FixS360 label Feb 1, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 14, 2022

jianyexi added the Approved-ModelValidation label Feb 15, 2022

jianyexi approved these changes Feb 15, 2022

View reviewed changes

jianyexi closed this Feb 15, 2022

jianyexi reopened this Feb 15, 2022

jianyexi merged commit cdc8706 into Azure:main Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing billing RP promotions S360 swagger issues #17451

Fixing billing RP promotions S360 swagger issues #17451

rkapso commented Jan 21, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jan 21, 2022

openapi-workflow-bot bot commented Jan 21, 2022

openapi-pipeline-app bot commented Jan 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jan 21, 2022

jianyexi commented Feb 15, 2022

azure-pipelines bot commented Feb 15, 2022

jianyexi commented Feb 15, 2022

azure-pipelines bot commented Feb 15, 2022

ruowan commented Feb 15, 2022

azure-pipelines bot commented Feb 15, 2022

Fixing billing RP promotions S360 swagger issues #17451

Fixing billing RP promotions S360 swagger issues #17451

Conversation

rkapso commented Jan 21, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 21, 2022

openapi-workflow-bot bot commented Jan 21, 2022

openapi-pipeline-app bot commented Jan 21, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 21, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jan 21, 2022

jianyexi commented Feb 15, 2022

azure-pipelines bot commented Feb 15, 2022

jianyexi commented Feb 15, 2022

azure-pipelines bot commented Feb 15, 2022

ruowan commented Feb 15, 2022

azure-pipelines bot commented Feb 15, 2022

rkapso commented Jan 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 21, 2022 •

edited

Loading