Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SubscriptionIdParameter to client instead of method #17952

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Change SubscriptionIdParameter to client instead of method #17952

merged 1 commit into from
Feb 23, 2022

Conversation

jinghzhu-msft
Copy link
Member

@jinghzhu-msft jinghzhu-msft commented Feb 23, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @jinghzhu-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 23, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L398
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L592
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L204
    ⚠️ R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L267
    ⚠️ R4021 - DescriptionAndTitleMissing 'GrafanaResourceListResponse' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L432
    ⚠️ R4021 - DescriptionAndTitleMissing 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L435
    ⚠️ R4021 - DescriptionAndTitleMissing 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L441
    ⚠️ R4021 - DescriptionAndTitleMissing 'LastModifiedByType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L486
    ⚠️ R4021 - DescriptionAndTitleMissing 'ProvisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L622
    ⚠️ R4021 - DescriptionAndTitleMissing 'ResourceSku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L640
    ⚠️ R4021 - DescriptionAndTitleMissing 'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L646
    ⚠️ R4021 - DescriptionAndTitleMissing 'SystemData' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L651
    ⚠️ R4021 - DescriptionAndTitleMissing 'createdBy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L655
    ⚠️ R4021 - DescriptionAndTitleMissing 'createdAt' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L661
    ⚠️ R4021 - DescriptionAndTitleMissing 'lastModifiedBy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L665
    ⚠️ R4021 - DescriptionAndTitleMissing 'lastModifiedAt' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L671
    ⚠️ R4021 - DescriptionAndTitleMissing 'ZoneRedundancy' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L677
    ⚠️ R4021 - DescriptionAndTitleMissing 'UserAssignedIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Dashboard/preview/2021-09-01-preview/grafana.json#L689
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 23, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armdashboard - 0.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-dashboard - first release
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 00b51d2. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/dashboard/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Dashboard [View full logs]  [Release SDK Changes] 
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 00b51d2. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-dashboard [View full logs]  [Release SDK Changes] 
      info	[Changelog]   - Initial Release
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 00b51d2. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armdashboard [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New const `CreatedByTypeManagedIdentity`
info	[Changelog] - New const `IdentityTypeSystemAssigned`
info	[Changelog] - New const `ProvisioningStateUpdating`
info	[Changelog] - New const `CreatedByTypeUser`
info	[Changelog] - New const `OriginUser`
info	[Changelog] - New const `ProvisioningStateDeleting`
info	[Changelog] - New const `LastModifiedByTypeUser`
info	[Changelog] - New const `ProvisioningStateCanceled`
info	[Changelog] - New const `ProvisioningStateFailed`
info	[Changelog] - New const `ZoneRedundancyEnabled`
info	[Changelog] - New const `LastModifiedByTypeKey`
info	[Changelog] - New const `ZoneRedundancyDisabled`
info	[Changelog] - New const `LastModifiedByTypeApplication`
info	[Changelog] - New const `LastModifiedByTypeManagedIdentity`
info	[Changelog] - New const `CreatedByTypeApplication`
info	[Changelog] - New const `ProvisioningStateAccepted`
info	[Changelog] - New const `ProvisioningStateDeleted`
info	[Changelog] - New const `ActionTypeInternal`
info	[Changelog] - New const `IdentityTypeNone`
info	[Changelog] - New const `ProvisioningStateCreating`
info	[Changelog] - New const `OriginUserSystem`
info	[Changelog] - New const `ProvisioningStateSucceeded`
info	[Changelog] - New function `PossibleProvisioningStateValues() []ProvisioningState`
info	[Changelog] - New function `OperationListResult.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ZoneRedundancy.ToPtr() *ZoneRedundancy`
info	[Changelog] - New function `NewOperationsClient(azcore.TokenCredential, *arm.ClientOptions) *OperationsClient`
info	[Changelog] - New function `*GrafanaClientListByResourceGroupPager.PageResponse() GrafanaClientListByResourceGroupResponse`
info	[Changelog] - New function `*GrafanaClientCreatePoller.FinalResponse(context.Context) (GrafanaClientCreateResponse, error)`
info	[Changelog] - New function `*timeRFC3339.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `GrafanaResourceListResponse.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*OperationsClientListPager.Err() error`
info	[Changelog] - New function `*OperationsClientListPager.PageResponse() OperationsClientListResponse`
info	[Changelog] - New function `*SystemData.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `GrafanaClientCreatePollerResponse.PollUntilDone(context.Context, time.Duration) (GrafanaClientCreateResponse, error)`
info	[Changelog] - New function `*GrafanaClientCreatePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `PossibleOriginValues() []Origin`
info	[Changelog] - New function `ActionType.ToPtr() *ActionType`
info	[Changelog] - New function `ManagedIdentity.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleIdentityTypeValues() []IdentityType`
info	[Changelog] - New function `*GrafanaClient.Update(context.Context, string, string, *GrafanaClientUpdateOptions) (GrafanaClientUpdateResponse, error)`
info	[Changelog] - New function `*GrafanaClientCreatePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `LastModifiedByType.ToPtr() *LastModifiedByType`
info	[Changelog] - New function `GrafanaResourceUpdateParameters.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*GrafanaClientListByResourceGroupPager.NextPage(context.Context) bool`
info	[Changelog] - New function `IdentityType.ToPtr() *IdentityType`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `GrafanaResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `CreatedByType.ToPtr() *CreatedByType`
info	[Changelog] - New function `*GrafanaClientDeletePoller.Done() bool`
info	[Changelog] - New function `*GrafanaClient.BeginDelete(context.Context, string, string, *GrafanaClientBeginDeleteOptions) (GrafanaClientDeletePollerResponse, error)`
info	[Changelog] - New function `*OperationsClient.List(*OperationsClientListOptions) *OperationsClientListPager`
info	[Changelog] - New function `*GrafanaClientCreatePollerResponse.Resume(context.Context, *GrafanaClient, string) error`
info	[Changelog] - New function `ProvisioningState.ToPtr() *ProvisioningState`
info	[Changelog] - New function `*GrafanaClient.BeginCreate(context.Context, string, string, *GrafanaClientBeginCreateOptions) (GrafanaClientCreatePollerResponse, error)`
info	[Changelog] - New function `*GrafanaClientListPager.PageResponse() GrafanaClientListResponse`
info	[Changelog] - New function `*GrafanaClientDeletePoller.FinalResponse(context.Context) (GrafanaClientDeleteResponse, error)`
info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
info	[Changelog] - New function `NewGrafanaClient(string, azcore.TokenCredential, *arm.ClientOptions) *GrafanaClient`
info	[Changelog] - New function `*GrafanaClient.ListByResourceGroup(string, *GrafanaClientListByResourceGroupOptions) *GrafanaClientListByResourceGroupPager`
info	[Changelog] - New function `*OperationsClientListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New function `*GrafanaClientListByResourceGroupPager.Err() error`
info	[Changelog] - New function `*GrafanaClientDeletePoller.ResumeToken() (string, error)`
info	[Changelog] - New function `*GrafanaClientDeletePollerResponse.Resume(context.Context, *GrafanaClient, string) error`
info	[Changelog] - New function `PossibleLastModifiedByTypeValues() []LastModifiedByType`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `*GrafanaClientCreatePoller.Done() bool`
info	[Changelog] - New function `*GrafanaClient.Get(context.Context, string, string, *GrafanaClientGetOptions) (GrafanaClientGetResponse, error)`
info	[Changelog] - New function `*GrafanaClientListPager.Err() error`
info	[Changelog] - New function `Origin.ToPtr() *Origin`
info	[Changelog] - New function `PossibleZoneRedundancyValues() []ZoneRedundancy`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `*GrafanaClient.List(*GrafanaClientListOptions) *GrafanaClientListPager`
info	[Changelog] - New function `*GrafanaClientListPager.NextPage(context.Context) bool`
info	[Changelog] - New function `GrafanaClientDeletePollerResponse.PollUntilDone(context.Context, time.Duration) (GrafanaClientDeleteResponse, error)`
info	[Changelog] - New function `*GrafanaClientDeletePoller.Poll(context.Context) (*http.Response, error)`
info	[Changelog] - New function `timeRFC3339.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `GrafanaClient`
info	[Changelog] - New struct `GrafanaClientBeginCreateOptions`
info	[Changelog] - New struct `GrafanaClientBeginDeleteOptions`
info	[Changelog] - New struct `GrafanaClientCreatePoller`
info	[Changelog] - New struct `GrafanaClientCreatePollerResponse`
info	[Changelog] - New struct `GrafanaClientCreateResponse`
info	[Changelog] - New struct `GrafanaClientCreateResult`
info	[Changelog] - New struct `GrafanaClientDeletePoller`
info	[Changelog] - New struct `GrafanaClientDeletePollerResponse`
info	[Changelog] - New struct `GrafanaClientDeleteResponse`
info	[Changelog] - New struct `GrafanaClientGetOptions`
info	[Changelog] - New struct `GrafanaClientGetResponse`
info	[Changelog] - New struct `GrafanaClientGetResult`
info	[Changelog] - New struct `GrafanaClientListByResourceGroupOptions`
info	[Changelog] - New struct `GrafanaClientListByResourceGroupPager`
info	[Changelog] - New struct `GrafanaClientListByResourceGroupResponse`
info	[Changelog] - New struct `GrafanaClientListByResourceGroupResult`
info	[Changelog] - New struct `GrafanaClientListOptions`
info	[Changelog] - New struct `GrafanaClientListPager`
info	[Changelog] - New struct `GrafanaClientListResponse`
info	[Changelog] - New struct `GrafanaClientListResult`
info	[Changelog] - New struct `GrafanaClientUpdateOptions`
info	[Changelog] - New struct `GrafanaClientUpdateResponse`
info	[Changelog] - New struct `GrafanaClientUpdateResult`
info	[Changelog] - New struct `GrafanaResource`
info	[Changelog] - New struct `GrafanaResourceListResponse`
info	[Changelog] - New struct `GrafanaResourceProperties`
info	[Changelog] - New struct `GrafanaResourceUpdateParameters`
info	[Changelog] - New struct `ManagedIdentity`
info	[Changelog] - New struct `OperationDisplay`
info	[Changelog] - New struct `OperationListResult`
info	[Changelog] - New struct `OperationResult`
info	[Changelog] - New struct `OperationsClient`
info	[Changelog] - New struct `OperationsClientListOptions`
info	[Changelog] - New struct `OperationsClientListPager`
info	[Changelog] - New struct `OperationsClientListResponse`
info	[Changelog] - New struct `OperationsClientListResult`
info	[Changelog] - New struct `ResourceSKU`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 161 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 00b51d2. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️dashboard [View full logs] 
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 00b51d2. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-dashboard [View full logs]  [Release SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 00b51d2. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-23 05:11:54 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-dashboard"
cmderr	[generate.py] 2022-02-23 05:11:54 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2022-02-23 05:11:54 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.50 --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/dashboard/azure-resourcemanager-dashboard --java.namespace=com.azure.resourcemanager.dashboard   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/dashboard/resource-manager/readme.md
cmderr	[generate.py] 2022-02-23 05:12:21 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-02-23 05:12:21 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-23 05:12:21 INFO [POM][Skip] pom already has module azure-resourcemanager-dashboard
cmderr	[generate.py] 2022-02-23 05:12:21 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-23 05:12:21 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-23 05:12:21 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-dashboard [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2022-02-23 05:13:41 DEBUG Got artifact_id: azure-resourcemanager-dashboard
cmderr	[Inst] 2022-02-23 05:13:41 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-23 05:13:41 DEBUG Got artifact: azure-resourcemanager-dashboard-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2022-02-23 05:13:41 DEBUG Got artifact: azure-resourcemanager-dashboard-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-23 05:13:41 DEBUG Match jar package: azure-resourcemanager-dashboard-1.0.0-beta.1.jar
cmderr	[Inst] 2022-02-23 05:13:41 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17952/azure-sdk-for-java/azure-resourcemanager-dashboard/azure-resourcemanager-dashboard-1.0.0-beta.1.jar\" -o azure-resourcemanager-dashboard-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-dashboard -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-dashboard-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    Posted by Swagger Pipeline | How to fix these errors?

    @jinghzhu-msft
    Copy link
    Member Author

    The goal of this change it we hope the parameter SubscirptionID to be in client instead of method.

    As we are still in Private Preview, there should be no breaking change.

    This was referenced Feb 23, 2022
    Closed
    Closed
    Closed
    Closed
    weidongxu-microsoft
    weidongxu-microsoft approved these changes Feb 23, 2022
    View reviewed changes
    Copy link
    Member

    @weidongxu-microsoft weidongxu-microsoft left a comment •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Do you need to loop in service for review (or you are service)?

    @weidongxu-microsoft weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 23, 2022
    @jinghzhu-msft
    Copy link
    Member Author

    Do you need to loop in service for review (or you are service)?

    @weidongxu-microsoft Thanks for looking into it. I am the service (MICROSOFT.DASHBOARD).

    @weidongxu-microsoft weidongxu-microsoft merged commit 00b51d2 into Azure:main Feb 23, 2022
    This was referenced Feb 23, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @jinghzhu-msft jinghzhu-msft deleted the parameter_client branch February 23, 2022 10:46
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    @jinghzhu-msft @FredericHeem
    Change SubscriptionIdParameter to client instead of method (Azure#17952)
    cecfbbf
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

    Assignees

    @weidongxu-microsoft weidongxu-microsoft

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @jinghzhu-msft @weidongxu-microsoft