-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Patch operations. Expose missing provider level operations #1816
Conversation
…vice and gateway API
@sergey-shandar - Can you confirm the behavior on #1 above and if SDK team is fine with this? |
@sergey-shandar, @ravbhatnagar I generated the SDK and indeed x-ms-mutability does not affect whether property is required. So for now the location will not be required. This is not necessarily breaking but calls from client without location could make it to service, where they will fail with the appropriate message. The validation would move to service instead of client. |
The proposal by @naveedaz sounds good to me. @sergey-shandar - please confirm fro SDK side. |
@shawns1 another PR where CI is not shown. Could you have a look? |
@@ -1341,7 +1465,11 @@ | |||
}, | |||
"location": { | |||
"description": "Resource Location.", | |||
"type": "string" | |||
"type": "string", | |||
"x-ms-mutability": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, we recommend to use x-ms-mutability
. AutoRest SDK code generation doesn't use the extension for now but it may use it in the future. It's not an SDK breaking change. In the same time, removing required
field may change an order of constructor parameters.
@@ -1130,9 +1191,6 @@ | |||
}, | |||
"Resource": { | |||
"description": "Azure resource. This resource is tracked in Azure Resource Manager", | |||
"required": [ | |||
"location" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, it's a potential SDK breaking change.
@@ -451,9 +452,6 @@ | |||
}, | |||
"Resource": { | |||
"description": "Azure resource. This resource is tracked in Azure Resource Manager", | |||
"required": [ | |||
"location" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potential SDK breaking change.
@@ -32,7 +32,7 @@ | |||
"200": { | |||
"description": "OK", | |||
"schema": { | |||
"$ref": "#/definitions/Object" | |||
"type": "object" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an SDK breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from #/definitions/Object is SDK but recommended by Azure SDK/ARM
@@ -92,7 +92,7 @@ | |||
"200": { | |||
"description": "OK", | |||
"schema": { | |||
"$ref": "#/definitions/Object" | |||
"type": "object" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an SDK breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change from #/definitions/Object is SDK but recommended by Azure SDK/ARM
@@ -18256,11 +18558,6 @@ | |||
"format": "double", | |||
"description": "Value of counter at a certain time.", | |||
"type": "number" | |||
}, | |||
"coreCount": { | |||
"format": "int32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property was removed.
@@ -18958,9 +19256,6 @@ | |||
}, | |||
"Resource": { | |||
"description": "Azure resource. This resource is tracked in Azure Resource Manager", | |||
"required": [ | |||
"location" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potential SDK breaking change.
"x-ms-pageable": { | ||
"nextLinkName": "nextLink" | ||
} | ||
"swagger": "2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing formatting of the document is unnecessary changes and it's really hard to review. Could you format the document as it was before?
@@ -3214,7 +3433,8 @@ | |||
"readOnly": true | |||
}, | |||
"certBlob": { | |||
"description": "A certificate file (.cer) blob containing the public key of the private key used to authenticate a \n Point-To-Site VPN connection.", | |||
"format": "byte", | |||
"description": "A certificate file (.cer) blob containing the public key of the private key used to authenticate a \nPoint-To-Site VPN connection.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potential SDK breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client validation for (uuid, byte ) will cause SDK breaks, but is acceptable and actually a good change.
@@ -2074,9 +2288,6 @@ | |||
}, | |||
"Resource": { | |||
"description": "Azure resource. This resource is tracked in Azure Resource Manager", | |||
"required": [ | |||
"location" | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potential SDK breaking changes.
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There a lot of SDK breaking changes but otherwise the changes are really good.
No modification for AutorestCI/azure-sdk-for-node |
MSI is supported only for the site resource. It was intentional to remove it from all tracked resources except for Site. Comments from above |
@naveedaz Yes, I saw afterward and removed my comment (not fast enough :)). Thanks for the confirmation :) I see ContinuousWebJob.settings has changed type, I guess it's on purpose as well. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger