Update properties for VMApps, CAPS and CRP #18560

D1v38om83r · 2022-04-05T22:08:56Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

June

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

April

If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-04-05T22:08:58Z

Hi, @D1v38om83r Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-04-05T22:08:58Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-04-05T22:08:58Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 1 Errors, 3 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.2 , classic-openapi-validator v1.2.3 )
- compute/resource-manager/readme.md tag:package-2022-03-01
Linted configuring files (Based on target branch, openapi-validator v1.12.2 , classic-openapi-validator v1.2.3 )
- compute/resource-manager/readme.md tag:package-2022-03-01

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'UserArtifactSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/gallery.json#L2162
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: treatFailureAsDeploymentFailure Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L1117
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAutomaticUpgrade Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L1121
⚠️ R4021 - DescriptionAndTitleMissing	'UserArtifactSettings' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: stable/2022-03-01/ComputeRP/gallery.json#L2162

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: stable/2022-03-01/ComputeRP/gallery.json#L1772
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: stable/2022-03-01/ComputeRP/gallery.json#L2069
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: stable/2022-03-01/ComputeRP/gallery.json#L2273
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: stable/2022-03-01/ComputeRP/gallery.json#L2428
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Compute/operations' does not match the ARM specification. Please standardize the schema. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L37
`❌` R4037 - MissingTypeObject	The schema 'ComputeOperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L178
`❌` R4037 - MissingTypeObject	The schema 'ComputeOperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L194
`❌` R4037 - MissingTypeObject	The schema 'ComputeOperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L213
`❌` R4037 - MissingTypeObject	The schema 'UsageName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L238
`❌` R4037 - MissingTypeObject	The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L251
`❌` R4037 - MissingTypeObject	The schema 'ListUsagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L287
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L319
`❌` R4037 - MissingTypeObject	The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L354
`❌` R4037 - MissingTypeObject	The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L354
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L367
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L367
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L367
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L401
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L401
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L401
`❌` R4037 - MissingTypeObject	The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L416
`❌` R4037 - MissingTypeObject	The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2022-03-01/ComputeRP/computeRPCommon.json#L416

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-01

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌Cross-Version Breaking Changes: 1 Errors, 2 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:2022-03-01/ComputeRP/gallery.json compared with base:stable/2021-10-01/gallery.json
- current:2022-03-01/ComputeRP/gallery.json compared with base:preview/2020-09-30/gallery.json

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'architecture' renamed or removed? New: stable/2022-03-01/ComputeRP/gallery.json#L2203:7 Old: Microsoft.Compute/stable/2021-10-01/gallery.json#L2181:7

The following breaking changes are detected by comparison with latest preview version:

Rule	Message
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: stable/2022-03-01/ComputeRP/gallery.json#L2618:9 Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L2358:9
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: stable/2022-03-01/ComputeRP/gallery.json#L2634:5 Old: Microsoft.Compute/preview/2020-09-30/gallery.json#L2371:5

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-04-05T22:08:59Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armcompute - 0.6.0

️✔️azure-sdk-for-js - @azure/arm-compute - 18.0.0

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 26.1.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Compute [View full logs] [Preview SDK Changes]

cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DiskUpdate.cs(90,16): error CS0111: Type 'DiskUpdate' already defines a member called 'DiskUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/SnapshotUpdate.cs(63,16): error CS0111: Type 'SnapshotUpdate' already defines a member called 'SnapshotUpdate' with the same parameter types [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.6.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-compute [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model GalleryImage no longer has parameter architecture
info	[Changelog]   - Model GalleryImageUpdate no longer has parameter architecture
info	[Changelog]   - Model VirtualMachineImage no longer has parameter architecture

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-compute-18.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface DedicatedHostGroupPropertiesAdditionalCapabilities
info	[Changelog]   - Added Interface UserArtifactSettings
info	[Changelog]   - Interface VMGalleryApplication has a new optional parameter enableAutomaticUpgrade
info	[Changelog]   - Interface VMGalleryApplication has a new optional parameter treatFailureAsDeploymentFailure
info	[Changelog]   - Type Alias DedicatedHostGroup has a new parameter additionalCapabilities
info	[Changelog]   - Type Alias DedicatedHostGroupUpdate has a new parameter additionalCapabilities
info	[Changelog]   - Type Alias GalleryApplicationVersionPublishingProfile has a new parameter settings
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface DiskUpdate no longer has parameter dataAccessAuthMode
info	[Changelog]   - Interface SnapshotUpdate no longer has parameter dataAccessAuthMode
info	[Changelog]   - Interface SupportedCapabilities no longer has parameter architecture
info	[Changelog]   - Type Alias Disk no longer has parameter dataAccessAuthMode
info	[Changelog]   - Type Alias GalleryImage no longer has parameter architecture
info	[Changelog]   - Type Alias GalleryImageUpdate no longer has parameter architecture
info	[Changelog]   - Type Alias Snapshot no longer has parameter dataAccessAuthMode
info	[Changelog]   - Type Alias VirtualMachineImage no longer has parameter architecture
info	[Changelog]   - Removed Enum KnownArchitecture
info	[Changelog]   - Removed Enum KnownArchitectureTypes
info	[Changelog]   - Removed Enum KnownDataAccessAuthMode

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[generator automation] [AUTOREST]
cmderr	[generator automation] [AUTOREST] ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
cmderr	[generator automation] [AUTOREST]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/gallery.json:2732:4 ($.definitions.ApiError)
cmderr	[generator automation] [AUTOREST]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json:3619:4 ($.definitions.ApiError)
cmderr	[generator automation] [AUTOREST]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/runCommands.json:1346:4 ($.definitions.ApiError)
cmderr	[generator automation] [AUTOREST]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json:14558:4 ($.definitions.ApiError)
cmderr	[generator automation] [AUTOREST]   Cancellation requested.
cmderr	[generator automation] [ERROR] total 1 error(s):
cmderr	[generator automation] [ERROR] failed to execute autorest: autorest error with arguments '--use=@microsoft.azure/autorest.go@2.1.187, --go, --verbose, --go-sdk-folder=., --use-onever, --version=2.0.4421, --go.license-header=MICROSOFT_MIT_NO_VERSION, --pass-thru:schema-validator-swagger, --enum-prefix, --tag=package-2021-08-01, --metadata-output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go_tmp/generation-metadata-1649206703/package-2021-08-01, ../../../../../azure-rest-api-specs/specification/compute/resource-manager/readme.md':
cmderr	[generator automation] [ERROR] exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armcompute [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `ArchitectureTypesArm64` has been removed
info	[Changelog] - Const `ArchitectureTypesX64` has been removed
info	[Changelog] - Const `ArchitectureX64` has been removed
info	[Changelog] - Const `DataAccessAuthModeNone` has been removed
info	[Changelog] - Const `DataAccessAuthModeAzureActiveDirectory` has been removed
info	[Changelog] - Const `ArchitectureArm64` has been removed
info	[Changelog] - Function `Architecture.ToPtr` has been removed
info	[Changelog] - Function `PossibleArchitectureTypesValues` has been removed
info	[Changelog] - Function `ArchitectureTypes.ToPtr` has been removed
info	[Changelog] - Function `PossibleDataAccessAuthModeValues` has been removed
info	[Changelog] - Function `DataAccessAuthMode.ToPtr` has been removed
info	[Changelog] - Function `PossibleArchitectureValues` has been removed
info	[Changelog] - Field `Architecture` of struct `VirtualMachineImageProperties` has been removed
info	[Changelog] - Field `DataAccessAuthMode` of struct `SnapshotProperties` has been removed
info	[Changelog] - Field `DataAccessAuthMode` of struct `SnapshotUpdateProperties` has been removed
info	[Changelog] - Field `Architecture` of struct `SupportedCapabilities` has been removed
info	[Changelog] - Field `DataAccessAuthMode` of struct `DiskUpdateProperties` has been removed
info	[Changelog] - Field `Architecture` of struct `GalleryImageProperties` has been removed
info	[Changelog] - Field `DataAccessAuthMode` of struct `DiskProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `DedicatedHostGroupPropertiesAdditionalCapabilities`
info	[Changelog] - New struct `UserArtifactSettings`
info	[Changelog] - New field `TreatFailureAsDeploymentFailure` in struct `VMGalleryApplication`
info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `VMGalleryApplication`
info	[Changelog] - New field `AdvancedSettings` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog] - New field `Settings` in struct `GalleryApplicationVersionPublishingProfile`
info	[Changelog] - New field `AdditionalCapabilities` in struct `DedicatedHostGroupProperties`
info	[Changelog]
info	[Changelog] Total 19 breaking change(s), 7 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from e5dfb499199a803ab1a098325b3cd64a43aeeb62. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️compute [View full logs] [Preview Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-04-05T22:26:19Z

Hi @D1v38om83r, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2022-04-05T22:26:19Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-04-05T22:32:19Z

Hi @D1v38om83r, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

D1v38om83r · 2022-04-07T20:46:54Z

CAPS (gallery) doesn't support API version 2022-03-01 yet. Please see #18609 that updates the properties in API version 2021-10-01 for CAPS.

D1v38om83r added 2 commits April 5, 2022 14:13

saving work

af731c7

ran prettier

f830443

D1v38om83r requested review from Sandido, dkulkarni-ms, haagha, madewithsmiles, MS-syh2qs, grizzlytheodore and hyonholee as code owners April 5, 2022 22:08

openapi-assignment-bot bot assigned ArcturusZhang Apr 5, 2022

ghost added the Compute label Apr 5, 2022

D1v38om83r changed the title ~~Feature/cplat 2022 03 01~~ Update properties for VMApps, CAPS and CRP Apr 5, 2022

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Apr 5, 2022

D1v38om83r marked this pull request as draft April 5, 2022 22:30

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 5, 2022

D1v38om83r added 2 commits April 5, 2022 15:43

made a new API version for gallery.json

c6db7de

Fixed spelling errors in description

b2c3b38

openapi-sdkautomation bot mentioned this pull request Apr 5, 2022

[AutoPR compute/resource-manager] Update properties for VMApps, CAPS and CRP AzureSDKAutomation/azure-resource-manager-schemas#6139

Draft

D1v38om83r marked this pull request as ready for review April 5, 2022 23:13

openapi-sdkautomation bot mentioned this pull request Apr 5, 2022

[AutoPR track2_azure-mgmt-compute] Update properties for VMApps, CAPS and CRP AzureSDKAutomation/azure-sdk-for-python#9905

Draft

openapi-pipeline-app bot removed BreakingChangeReviewRequired labels Apr 5, 2022

D1v38om83r added 2 commits April 5, 2022 16:32

fixed path for gallery.json for 2022-03-01 in readme.md

fa4f38d

fixed readme.md

87e9c47

openapi-pipeline-app bot added CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-BreakingChange-Python-Track2 labels Apr 6, 2022

D1v38om83r marked this pull request as draft April 7, 2022 19:32

D1v38om83r mentioned this pull request Apr 7, 2022

Update properties for VMApps, CRP #18609

Merged

25 tasks

grizzlytheodore closed this Apr 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update properties for VMApps, CAPS and CRP #18560

Update properties for VMApps, CAPS and CRP #18560

D1v38om83r commented Apr 5, 2022 •

edited

Loading

openapi-workflow-bot bot commented Apr 5, 2022

openapi-workflow-bot bot commented Apr 5, 2022

openapi-pipeline-app bot commented Apr 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Apr 5, 2022

openapi-workflow-bot bot commented Apr 5, 2022

openapi-workflow-bot bot commented Apr 5, 2022

D1v38om83r commented Apr 7, 2022 •

edited

Loading

Update properties for VMApps, CAPS and CRP #18560

Update properties for VMApps, CAPS and CRP #18560

Conversation

D1v38om83r commented Apr 5, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 5, 2022

openapi-workflow-bot bot commented Apr 5, 2022

openapi-pipeline-app bot commented Apr 5, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 5, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Apr 5, 2022

openapi-workflow-bot bot commented Apr 5, 2022

openapi-workflow-bot bot commented Apr 5, 2022

D1v38om83r commented Apr 7, 2022 • edited Loading

D1v38om83r commented Apr 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2022 •

edited

Loading

openapi-pipeline-app bot commented Apr 5, 2022 •

edited

Loading

D1v38om83r commented Apr 7, 2022 •

edited

Loading