-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory]Add support for running staging on multiple sources in parallel #18825
[DataFactory]Add support for running staging on multiple sources in parallel #18825
Conversation
Hi, @kesharma Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L43 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L43 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L230 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L230 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5225 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5225 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6037 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6037 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6431 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6431 |
R4037 - MissingTypeObject |
The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L189 |
R4037 - MissingTypeObject |
The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L189 |
R4037 - MissingTypeObject |
The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L199 |
R4037 - MissingTypeObject |
The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L199 |
R4037 - MissingTypeObject |
The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1520 |
R4037 - MissingTypeObject |
The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1520 |
R4037 - MissingTypeObject |
The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1553 |
R4037 - MissingTypeObject |
The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1553 |
R4037 - MissingTypeObject |
The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5160 |
R4037 - MissingTypeObject |
The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5160 |
R4037 - MissingTypeObject |
The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5179 |
R4037 - MissingTypeObject |
The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5179 |
R4037 - MissingTypeObject |
The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5244 |
R4037 - MissingTypeObject |
The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5244 |
R4037 - MissingTypeObject |
The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263 |
R4037 - MissingTypeObject |
The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263 |
R4037 - MissingTypeObject |
The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5299 |
R4037 - MissingTypeObject |
The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5299 |
R4037 - MissingTypeObject |
The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5318 |
R4037 - MissingTypeObject |
The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5318 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
|
"readme":"datafactory/resource-manager/readme.md", "tag":"package-2018-06", "details":"Error: Plugin prechecker reported failure." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @kesharma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
NewApiVersionRequired reason: |
...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
* Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * adding Services APIs * more changes * updated examples * Defining the APIs for the new NSP resource * IoT Central Public API 1.1-preview Oct Release (#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * test * SecuritySolution test * 2 * org * 1 * [DataFactory]Add support for running staging on multiple sources in parallel (#18825) * Add support for running staging on multiple sources in parallel * update * Add default accountid (#19417) Similar PR was merged into Main. s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here. * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Removed api docs except dataset * Dataset 2022-09-01-preview changes * Readme changes * Merge Commit * Minor changes * Change in readme.md * Merging from main * Merging from main * Udids in List Response * small changes * small change * Wrong update * outputOntology * outputOntology * Append Example Co-authored-by: Arik Riklin <arik.riklin@microsoft.com> Co-authored-by: ariklin <ariklin@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com> Co-authored-by: Meha Kaushik <mekaushi@microsoft.com> Co-authored-by: Amit Singh <31076927+amisi01@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: REDMOND\amisi <amisi@microsoft.com> Co-authored-by: Johnson Yang <hayang@microsoft.com> Co-authored-by: kesharma <74746991+kesharma@users.noreply.github.com> Co-authored-by: Tal Shoham <87926500+tshoham@users.noreply.github.com> Co-authored-by: tejitpabari <tejitpabari@microsoft.com>
* Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * adding Services APIs * more changes * updated examples * Defining the APIs for the new NSP resource * IoT Central Public API 1.1-preview Oct Release (Azure#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * test * SecuritySolution test * 2 * org * 1 * [DataFactory]Add support for running staging on multiple sources in parallel (Azure#18825) * Add support for running staging on multiple sources in parallel * update * Add default accountid (Azure#19417) Similar PR was merged into Main. s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here. * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Removed api docs except dataset * Dataset 2022-09-01-preview changes * Readme changes * Merge Commit * Minor changes * Change in readme.md * Merging from main * Merging from main * Udids in List Response * small changes * small change * Wrong update * outputOntology * outputOntology * Append Example Co-authored-by: Arik Riklin <arik.riklin@microsoft.com> Co-authored-by: ariklin <ariklin@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Meha Kaushik <kaushik.meha@gmail.com> Co-authored-by: Meha Kaushik <mekaushi@microsoft.com> Co-authored-by: Amit Singh <31076927+amisi01@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: REDMOND\amisi <amisi@microsoft.com> Co-authored-by: Johnson Yang <hayang@microsoft.com> Co-authored-by: kesharma <74746991+kesharma@users.noreply.github.com> Co-authored-by: Tal Shoham <87926500+tshoham@users.noreply.github.com> Co-authored-by: tejitpabari <tejitpabari@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.