Add RoleManagementAlerts resource for PIM #19296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @juliawelborn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2021-12-01-preview-only | package-2021-12-01-preview-only(0905ab1) | package-2021-12-01-preview-only(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Based on the response model schema, operation 'AlertOperation_ListForScope' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Authorization/preview/2022-08-01-preview/RoleManagementAlerts.json#L749 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/authorization/resource-manager/readme.md tag: specification/authorization/resource-manager/readme.md#tag-package-2021-12-01-preview-only |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 158 Errors, 0 Warnings failed [Detail]
Tag package-2021-12-01-preview-only; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 69, untested: 0, failed: 67, passed: 2
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 503, errorCode: undefined, errorMessage: undefined" |
|
"expected response code to be 2XX but found 503" |
|
"Invalid Content-Type (application/octet-stream). These are supported: application/json" |
|
"Body is required in response but not provided" |
|
"statusCode: 400, errorCode: undefined, errorMessage: undefined" |
|
"expected response code to be 2XX but found 400" |
|
"Additional properties not allowed: Message" |
|
"statusCode: 400, errorCode: undefined, errorMessage: undefined" |
|
"expected response code to be 2XX but found 400" |
|
"Additional properties not allowed: Message" |
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: MissingSubscription, errorMessage: The request did not have a subscription or a valid tenant level resource provider." |
|
"expected response code to be 2XX but found 404" |
|
"statusCode: 405, errorCode: undefined, errorMessage: undefined" |
|
"expected response code to be 2XX but found 405" |
|
"Additional properties not allowed: Message" |
|
"statusCode: 400, errorCode: undefined, errorMessage: undefined" |
|
"expected response code to be 2XX but found 400" |
|
"Additional properties not allowed: Message" |
️❌~[Staging] TrafficValidation: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 3 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/0905ab1dfabddb4de0f8076a06e9aa46a17a35fa/specification/authorization/resource-manager/readme.md#tag-package-2021-12-01-preview-only">authorization/resource-manager/readme.md#package-2021-12-01-preview-only
- "https://github.com/Azure/azure-rest-api-specs/blob/0905ab1dfabddb4de0f8076a06e9aa46a17a35fa/specification/authorization/resource-manager/readme.md#tag-package-2022-08-01-preview-only">authorization/resource-manager/readme.md#package-2022-08-01-preview-only
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-12-01-preview-only", "details":"The schema 'AccessReviewDecisionInsightProperties-insightCreatedDateTime' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2021-12-01-preview/authorization-AccessReviewCalls.json#/components/schemas/AccessReviewDecisionInsightProperties-insightCreatedDateTime" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-12-01-preview-only", "details":"The schema 'AccessReviewDecisionUserSignInInsightProperties-lastSignInDateTime' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2021-12-01-preview/authorization-AccessReviewCalls.json#/components/schemas/AccessReviewDecisionUserSignInInsightProperties-lastSignInDateTime" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2022-08-01-preview-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-12-01-preview-only", "details":"Schema 'AccessReviewDecisionUserSignInInsightProperties' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-12-01-preview-only", "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-12-01-preview-only", "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-12-01-preview-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
|
|
|
Hi @juliawelborn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jun 1, 2022
Closed
Closed
|
NewApiVersionRequired reason: |
Generated ApiView
|
Swagger Generation Artifacts
|
openapi-pipeline-app
bot
added
NewApiVersionRequired
and removed
NewApiVersionRequired
labels
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @juliawelborn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Is roleManagementAlerts the only resource in this new API version? Does the new API support older resources? If anything is copied from older version, you need to follow this: The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Let me know and I can continue the review. Thanks. |
zizw123
added
the
ARMChangesRequested
AzureRestAPISpecReview
added
the
ReadyForApiTest
juliawelborn
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This new api version is only for roleManagementAlerts, so I did not copy from the previous api version |
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
ruowan
approved these changes
Sep 28, 2022
This was referenced Sep 29, 2022
[ReleasePR track2_azure-mgmt-authorization] Update readme.python.md
Azure/azure-sdk-for-python#24660
Closed
11 tasks
11 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.