Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Cache to add aof-backup-enabled and authnotrequired configs in version stable/2020-12-01 and stable/2021-06-01 #19566

Merged
merged 3 commits into from
Jul 1, 2022
Merged

[Hub Generated] Review request for Microsoft.Cache to add aof-backup-enabled and authnotrequired configs in version stable/2020-12-01 and stable/2021-06-01 #19566

merged 3 commits into from
Jul 1, 2022

Conversation

samsaha-ms
Copy link
Contributor

@samsaha-ms samsaha-ms commented Jun 23, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @samsaha-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 23, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    redis.json 2020-12-01(fd4da8f) 2020-12-01(main)
    redis.json 2021-06-01(fd4da8f) 2021-06-01(main)
    Rule Message
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'aof-backup-enabled' in response that was not found in the old version.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1833:11
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1828:11
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'authnotrequired' in response that was not found in the old version.
    New: Microsoft.Cache/stable/2020-12-01/redis.json#L1833:11
    Old: Microsoft.Cache/stable/2020-12-01/redis.json#L1828:11
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'aof-backup-enabled' in response that was not found in the old version.
    New: Microsoft.Cache/stable/2021-06-01/redis.json#L1880:11
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1875:11
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'authnotrequired' in response that was not found in the old version.
    New: Microsoft.Cache/stable/2021-06-01/redis.json#L1880:11
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1875:11
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-06 package-2021-06(fd4da8f) package-2021-06(main)
    package-2020-12 package-2020-12(fd4da8f) package-2020-12(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L73
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2021-06-01/redis.json#L73
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2336
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2406
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L37
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2021-06-01/redis.json#L37
    ❌ R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1789
    ❌ R4037 - MissingTypeObject The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1829
    ❌ R4037 - MissingTypeObject The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1959
    ❌ R4037 - MissingTypeObject The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L1991
    ❌ R4037 - MissingTypeObject The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2006
    ❌ R4037 - MissingTypeObject The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2086
    ❌ R4037 - MissingTypeObject The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2122
    ❌ R4037 - MissingTypeObject The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2139
    ❌ R4037 - MissingTypeObject The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2154
    ❌ R4037 - MissingTypeObject The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2180
    ❌ R4037 - MissingTypeObject The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2197
    ❌ R4037 - MissingTypeObject The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2214
    ❌ R4037 - MissingTypeObject The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2239
    ❌ R4037 - MissingTypeObject The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2277
    ❌ R4037 - MissingTypeObject The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2294
    ❌ R4037 - MissingTypeObject The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2314
    ❌ R4037 - MissingTypeObject The schema 'ExportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2344
    ❌ R4037 - MissingTypeObject The schema 'ImportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2365
    ❌ R4037 - MissingTypeObject The schema 'ScheduleEntry' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2384
    ❌ R4037 - MissingTypeObject The schema 'ScheduleEntries' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2423
    ❌ R4037 - MissingTypeObject The schema 'RedisPatchSchedule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2439
    ❌ R4037 - MissingTypeObject The schema 'RedisPatchScheduleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2462
    ❌ R4037 - MissingTypeObject The schema 'RedisForceRebootResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2479
    ❌ R4037 - MissingTypeObject The schema 'RedisLinkedServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2489
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: |"readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"|
    |:speech_balloon: |"readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"|
    |:speech_balloon: |"readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"|
    |:speech_balloon: |"readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Process() cancelled due to failure "
    ❌ "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"!Error: Plugin prechecker reported failure."
    ❌ "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Autorest completed with an error. If you think the error message is unclear,
    or is a bug,
    please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.2.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.3.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.4.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.5.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Using directive.6.suppress which is deprecated and will be removed in the future."
    ⚠️ IgnoredPropertyNextToRef "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > Resource > properties > systemData)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.2.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.3.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.4.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.5.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Using directive.6.suppress which is deprecated and will be removed in the future."
    💬 "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    💬 "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    💬 "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    💬 "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    💬 "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Autorest completed in 4.13s. 0 files generated."
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 23, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armredis - 1.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-redis - 13.1.0
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 7d77097. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7d77097. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-redis [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group AsyncOperationStatusOperations
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter aof_backup_enabled
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter authnotrequired
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter zonal_configuration
info	[Changelog]   - Model RedisPatchSchedule has a new parameter location
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7d77097. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armredis [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Authnotrequired` in struct `CommonPropertiesRedisConfiguration`
info	[Changelog] - New field `AofBackupEnabled` in struct `CommonPropertiesRedisConfiguration`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7d77097. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-rediscache [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter aofBackupEnabled
info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter authnotrequired
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 7d77097. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 7d77097. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Redis [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @samsaha-ms samsaha-ms changed the title [Hub Generated] Review request for Microsoft.Cache to add version stable/2020-12-01 [Hub Generated] Review request for Microsoft.Cache to add aof-backup-enabled and authnotrequired configs in version stable/2020-12-01 and stable/2021-06-01 Jun 23, 2022
    @openapi-workflow-bot
    Copy link

    Hi @samsaha-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @samsaha-ms samsaha-ms requested a review from gorandom June 23, 2022 07:53
    This was referenced Jun 23, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @samsaha-ms samsaha-ms force-pushed the dev1-redis-Microsoft.Cache-2020-12-01 branch from 2bc2030 to 50e685f Compare June 23, 2022 09:31
    @samsaha-ms samsaha-ms force-pushed the dev1-redis-Microsoft.Cache-2020-12-01 branch from 50e685f to 1d17afe Compare June 23, 2022 09:34
    @samsaha-ms
    Copy link
    Contributor Author

    @ruowan, Could you please help in merging the PR, in case we need breaking change review, then please help in adding the tag, we will initiate the process for the same. Thanks in advance!

    @openapi-workflow-bot
    Copy link

    Hi @samsaha-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @TimLovellSmith
    Copy link
    Member

    Adding the tag as I think breaking change review may technically be required here. I don't think it was really a breaking change in service behavior, the values were already being sent and received on the wire in these versions, right?

    @samsaha-ms
    Copy link
    Contributor Author

    Adding the tag as I think breaking change review may technically be required here. I don't think it was really a breaking change in service behavior, the values were already being sent and received on the wire in these versions, right?

    Yes, we have received s360 violations for the version 2020-12-01. Hence, adding in latest one also along with 2020-12-01.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 26, 2022
    @samsaha-ms
    Copy link
    Contributor Author

    @ruowan, could you please help in merging the PR?

    @ruowan ruowan merged commit 7d77097 into Azure:main Jul 1, 2022
    This was referenced Jul 1, 2022
    Merged
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Jul 1, 2022
    [ReleasePR redis] [Hub Generated] Review request for Microsoft.Cache …
    bddb999 
    …to add aof-backup-enabled and authnotrequired configs in version stable/2020-12-01 and stable/2021-06-01 (#2449)

Create to sync Azure/azure-rest-api-specs#19566
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/redis?expand=1)
    @azure-sdk azure-sdk mentioned this pull request Jul 1, 2022
    Closed
    @samsaha-ms samsaha-ms deleted the dev1-redis-Microsoft.Cache-2020-12-01 branch July 1, 2022 05:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ruowan ruowan ruowan approved these changes

    @gorandom gorandom gorandom approved these changes

    @TimLovellSmith TimLovellSmith Awaiting requested review from TimLovellSmith TimLovellSmith is a code owner

    Assignees

    @ruowan ruowan

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @samsaha-ms @TimLovellSmith @ruowan @gorandom @JeffreyRichter