Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/v sparatala/merge allx ms mutability #20749

Merged
Merged
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
de3fcd0
Remove "keyVaultUrl" in PUT schema reponse
sparatala Aug 30, 2022
8b6d8c2
Revert "Remove "keyVaultUrl" in PUT schema reponse"
sparatala Aug 30, 2022
d68f6ad
Update keyVaultUrl property to readOnly true
sparatala Aug 30, 2022
7de6196
Removed read-only and annotated to x-ms-mutability
sparatala Sep 1, 2022
cdd5003
Update Workspaces_Get property to x-ms-mutability
sparatala Sep 1, 2022
e4b92bd
Updated SqlPoolSecurityAlertPolicies_Get properties to x-ms-mutability
sparatala Sep 1, 2022
257de58
Update dynamicExecutorAllocation property with x-ms-mutability
sparatala Sep 1, 2022
06c79e1
Update Workspaces_Get createManagedPrivateEndpoint to x-ms-mutability
sparatala Sep 1, 2022
6323f5d
Updated workspace_Get property managedResourceGroupName to x-ms-mutab…
sparatala Sep 1, 2022
d09af65
Update SqlPools_Get property restorePointInTime to x-ms-mutability
sparatala Sep 2, 2022
595d872
Update WorkspaceManagedSqlServerBlobAuditingPolicies_Get property to …
sparatala Sep 2, 2022
8e1f026
Update SqlPools_Get collation to x-ms-mutability
sparatala Sep 5, 2022
8e1c901
Update KustoPools_Get KustoPool workspaceUID to x-ms-mutability
sparatala Sep 6, 2022
298c592
Fix model validation error
sparatala Sep 14, 2022
10739a6
Fixed review comments
sparatala Sep 15, 2022
98922b5
Merge branch 'main' into users/v-sparatala/Workspaces_Get
sparatala Sep 15, 2022
fc54535
Fix R2064 - LROStatusCodesReturnTypeSchema
sparatala Sep 15, 2022
1ec2ab9
Fix lint, model validation error
sparatala Sep 15, 2022
0868d31
Removed lro options
sparatala Sep 15, 2022
39ed591
Fix LRO lint error
sparatala Sep 15, 2022
2bc87d7
Merge branch 'main' into users/v-sparatala/sqlPool_SqlPoolSecurityAle…
sparatala Sep 16, 2022
f9328a4
Fix lint error
sparatala Sep 16, 2022
79aeb39
Fix lint error
sparatala Sep 16, 2022
64a64bb
Fix lint error
sparatala Sep 16, 2022
03e5ef1
Fix lint error
sparatala Sep 16, 2022
143a080
Fix lint error
sparatala Sep 16, 2022
ca7c706
Merge branch 'main' into users/v-sparatala/defaultDataLakeStorage_Wor…
sparatala Sep 16, 2022
e31bf74
Fix lint error
sparatala Sep 16, 2022
03d29c6
Merge branch 'main' into users/v-sparatala/managedResourceGroupName_W…
sparatala Sep 16, 2022
f51bea7
Merge branch 'main' into users/v-sparatala/sqlPool_SqlPoolSecurityAle…
sparatala Sep 16, 2022
f4cd5db
Fix lint error
sparatala Sep 16, 2022
65f0708
Fix lint error
sparatala Sep 16, 2022
8355ff9
Merge branch 'users/v-sparatala/Keys_Get' into users/v-sparatala/Merg…
sparatala Sep 16, 2022
df40a85
Merge branch 'users/v-sparatala/KustoPools_Get' into users/v-sparatal…
sparatala Sep 16, 2022
d231dd2
Merge branch 'users/v-sparatala/SqlPools_Get_Collation' into users/v-…
sparatala Sep 16, 2022
ba74717
Merge branch 'users/v-sparatala/WorkspaceManagedSqlServerBlobAuditing…
sparatala Sep 16, 2022
9eddd44
Merge branch 'users/v-sparatala/SqlPools_Get' into users/v-sparatala/…
sparatala Sep 16, 2022
71f48d8
Merge branch 'users/v-sparatala/managedResourceGroupName_Workspaces_G…
sparatala Sep 16, 2022
1665836
Merge branch 'users/v-sparatala/defaultDataLakeStorage_Workspaces_Get…
sparatala Sep 16, 2022
a53d773
Merge branch 'users/v-sparatala/BigDataPools_Get_dynamicExecutorAlloc…
sparatala Sep 16, 2022
441928b
Merge branch 'users/v-sparatala/sqlPool_SqlPoolSecurityAlertPolicies_…
sparatala Sep 16, 2022
721e5d1
Resolve conflict in workspace.json for preview, stable
sparatala Sep 16, 2022
4d93071
Resolved review comments
sparatala Sep 19, 2022
7662e36
Merge branch 'main' into users/v-sparatala/defaultDataLakeStorage_Wor…
sparatala Sep 19, 2022
58d97cc
Merge branch 'main' into users/v-sparatala/MergeAllx-ms-mutability
sparatala Sep 19, 2022
c45ce8f
Merge branch 'users/v-sparatala/defaultDataLakeStorage_Workspaces_Get…
sparatala Sep 19, 2022
0b80f7d
Fix review comments
sparatala Sep 22, 2022
9415769
Fix review comments
sparatala Sep 22, 2022
e0261ef
Resolve exception in kustoPool.json:
sparatala Sep 22, 2022
254707e
Resolve lint error
sparatala Sep 22, 2022
57b9e36
Resolve Model validation error
sparatala Sep 22, 2022
f08be61
Resolve model validation error
sparatala Sep 22, 2022
649de68
Resolve LRO error
sparatala Sep 22, 2022
a9bedc7
Resolve lint, model validation error
sparatala Sep 22, 2022
173c9e6
Resolve Model Validation error
sparatala Sep 22, 2022
727d087
Resolve model validation error
sparatala Sep 22, 2022
c3f2cf0
Resolve model validation error
sparatala Sep 22, 2022
0ed4d48
Resolve Model validation error
sparatala Sep 22, 2022
34a1432
Resolve model validation error
sparatala Sep 23, 2022
d8831c6
Resolve review comments
sparatala Sep 23, 2022
4722421
Resolve model validation error
sparatala Sep 23, 2022
afced2c
Remove header location
sparatala Sep 29, 2022
5537037
Resolve runtime exception for schema violation
sparatala Sep 29, 2022
52900df
Resolve model validation error
sparatala Sep 29, 2022
fd37ac4
Resolve schema violation exception
sparatala Sep 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
"responses": {
"200": {
"headers": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share the reason for this change?

Copy link
Contributor Author

@sparatala sparatala Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-ms-longrunning operation error was showing hence header with "location"

"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand All @@ -31,6 +34,9 @@
}
},
"201": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
},
"responses": {
"200": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand All @@ -28,6 +31,9 @@
}
},
"201": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
"responses": {
"200": {
"headers": {
"location": true
sparatala marked this conversation as resolved.
Show resolved Hide resolved
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand All @@ -36,6 +39,9 @@
}
},
"201": {
"headers": {
"location": true
sparatala marked this conversation as resolved.
Show resolved Hide resolved
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,8 @@
"type": "array",
"items": {
"$ref": "../../../../common/v1/types.json#/definitions/LibraryInfo"
}
},
"x-ms-identifiers": []
},
"sparkConfigProperties": {
"$ref": "#/definitions/SparkConfigProperties",
Expand Down Expand Up @@ -566,12 +567,20 @@
"minExecutors": {
"type": "integer",
"format": "int32",
"description": "The minimum number of executors alloted"
"description": "The minimum number of executors alloted",
"x-ms-mutability": [
"create",
"update"
sparatala marked this conversation as resolved.
Show resolved Hide resolved
]
},
"maxExecutors": {
"type": "integer",
"format": "int32",
"description": "The maximum number of executors alloted"
"description": "The maximum number of executors alloted",
"x-ms-mutability": [
"create",
"update"
]
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@
}
}
},
"201": {}
"201": {
"body": {
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1/managedIdentitySqlControlSettings/default",
"name": "default",
"properties": {
"grantSqlControlToManagedIdentity": {
"desiredState": "Enabled",
"actualState": "Enabling"
}
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
"responses": {
"200": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand All @@ -31,6 +34,9 @@
}
},
"202": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
},
"responses": {
"200": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand All @@ -28,6 +31,9 @@
}
},
"202": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
},
"responses": {
"200": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand All @@ -39,6 +42,9 @@
}
},
"202": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,11 @@
},
"keyVaultUrl": {
"type": "string",
"description": "The Key Vault Url of the workspace key."
"description": "The Key Vault Url of the workspace key.",
"x-ms-mutability": [
"create",
"read"
]
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2619,7 +2619,11 @@
},
"workspaceUID": {
"type": "string",
"description": "The workspace unique identifier."
"description": "The workspace unique identifier.",
"x-ms-mutability": [
"create",
"read"
]
}
},
"description": "Class representing the Kusto pool properties."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5468,7 +5468,11 @@
},
"collation": {
"type": "string",
"description": "Collation mode"
"description": "Collation mode",
"x-ms-mutability": [
"create",
"read"
]
},
"sourceDatabaseId": {
"type": "string",
Expand All @@ -5494,7 +5498,11 @@
"restorePointInTime": {
"type": "string",
"description": "Snapshot time to restore",
"format": "date-time"
"format": "date-time",
"x-ms-mutability": [
"create",
"read"
]
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -5550,6 +5558,7 @@
],
"properties": {
"properties": {
"type": "object",
"title": "Metadata Sync Config properties",
"description": "Metadata Sync Config properties",
"properties": {
Expand Down Expand Up @@ -6170,6 +6179,7 @@
}
},
"TransparentDataEncryptionProperties": {
"type": "object",
"properties": {
"status": {
"type": "string",
Expand All @@ -6186,6 +6196,7 @@
"description": "Represents the properties of a database transparent data encryption."
},
"TransparentDataEncryption": {
"type": "object",
"properties": {
"location": {
"type": "string",
Expand Down Expand Up @@ -6432,6 +6443,7 @@
}
},
"SqlPoolUsage": {
"type": "object",
sparatala marked this conversation as resolved.
Show resolved Hide resolved
"properties": {
"name": {
"readOnly": true,
Expand Down Expand Up @@ -6475,6 +6487,7 @@
"description": "The Sql pool usages."
},
"SqlPoolUsageListResult": {
"type": "object",
"properties": {
"value": {
"type": "array",
Expand Down Expand Up @@ -7033,14 +7046,22 @@
"type": "array",
"items": {
"type": "string"
}
},
"x-ms-mutability": [
"create",
"read"
]
},
"emailAddresses": {
"description": "Specifies an array of e-mail addresses to which the alert is sent.",
"type": "array",
"items": {
"type": "string"
}
},
"x-ms-mutability": [
"create",
"read"
]
},
"emailAccountAdmins": {
"description": "Specifies that the alert is sent to the account administrators.",
Expand Down Expand Up @@ -7347,6 +7368,7 @@
}
},
"DataMaskingPolicyProperties": {
"type": "object",
"properties": {
"dataMaskingState": {
"type": "string",
Expand Down Expand Up @@ -7386,6 +7408,7 @@
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ProxyResource"
}
],
"type": "object",
"properties": {
"properties": {
"x-ms-client-flatten": true,
Expand Down Expand Up @@ -7512,6 +7535,7 @@
}
},
"DataMaskingRule": {
"type": "object",
"properties": {
"properties": {
"x-ms-client-flatten": true,
Expand All @@ -7537,6 +7561,7 @@
"description": "Represents a Sql pool data masking rule."
},
"DataMaskingRuleProperties": {
"type": "object",
"properties": {
"id": {
"type": "string",
Expand Down Expand Up @@ -7617,6 +7642,7 @@
"description": "The properties of a Sql pool data masking rule."
},
"DataMaskingRuleListResult": {
"type": "object",
"properties": {
"value": {
"type": "array",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1404,19 +1404,31 @@
"retentionDays": {
"format": "int32",
"description": "Specifies the number of days to keep in the audit logs in the storage account.",
"type": "integer"
"type": "integer",
"x-ms-mutability": [
"create",
"read"
]
},
"auditActionsAndGroups": {
"description": "Specifies the Actions-Groups and Actions to audit.\r\n\r\nThe recommended set of action groups to use is the following combination - this will audit all the queries and stored procedures executed against the database, as well as successful and failed logins:\r\n\r\nBATCH_COMPLETED_GROUP,\r\nSUCCESSFUL_DATABASE_AUTHENTICATION_GROUP,\r\nFAILED_DATABASE_AUTHENTICATION_GROUP.\r\n\r\nThis above combination is also the set that is configured by default when enabling auditing from the Azure portal.\r\n\r\nThe supported action groups to audit are (note: choose only specific groups that cover your auditing needs. Using unnecessary groups could lead to very large quantities of audit records):\r\n\r\nAPPLICATION_ROLE_CHANGE_PASSWORD_GROUP\r\nBACKUP_RESTORE_GROUP\r\nDATABASE_LOGOUT_GROUP\r\nDATABASE_OBJECT_CHANGE_GROUP\r\nDATABASE_OBJECT_OWNERSHIP_CHANGE_GROUP\r\nDATABASE_OBJECT_PERMISSION_CHANGE_GROUP\r\nDATABASE_OPERATION_GROUP\r\nDATABASE_PERMISSION_CHANGE_GROUP\r\nDATABASE_PRINCIPAL_CHANGE_GROUP\r\nDATABASE_PRINCIPAL_IMPERSONATION_GROUP\r\nDATABASE_ROLE_MEMBER_CHANGE_GROUP\r\nFAILED_DATABASE_AUTHENTICATION_GROUP\r\nSCHEMA_OBJECT_ACCESS_GROUP\r\nSCHEMA_OBJECT_CHANGE_GROUP\r\nSCHEMA_OBJECT_OWNERSHIP_CHANGE_GROUP\r\nSCHEMA_OBJECT_PERMISSION_CHANGE_GROUP\r\nSUCCESSFUL_DATABASE_AUTHENTICATION_GROUP\r\nUSER_CHANGE_PASSWORD_GROUP\r\nBATCH_STARTED_GROUP\r\nBATCH_COMPLETED_GROUP\r\n\r\nThese are groups that cover all sql statements and stored procedures executed against the database, and should not be used in combination with other groups as this will result in duplicate audit logs.\r\n\r\nFor more information, see [Database-Level Audit Action Groups](https://docs.microsoft.com/en-us/sql/relational-databases/security/auditing/sql-server-audit-action-groups-and-actions#database-level-audit-action-groups).\r\n\r\nFor Database auditing policy, specific Actions can also be specified (note that Actions cannot be specified for Server auditing policy). The supported actions to audit are:\r\nSELECT\r\nUPDATE\r\nINSERT\r\nDELETE\r\nEXECUTE\r\nRECEIVE\r\nREFERENCES\r\n\r\nThe general form for defining an action to be audited is:\r\n{action} ON {object} BY {principal}\r\n\r\nNote that <object> in the above format can refer to an object like a table, view, or stored procedure, or an entire database or schema. For the latter cases, the forms DATABASE::{db_name} and SCHEMA::{schema_name} are used, respectively.\r\n\r\nFor example:\r\nSELECT on dbo.myTable by public\r\nSELECT on DATABASE::myDatabase by public\r\nSELECT on SCHEMA::mySchema by public\r\n\r\nFor more information, see [Database-Level Audit Actions](https://docs.microsoft.com/en-us/sql/relational-databases/security/auditing/sql-server-audit-action-groups-and-actions#database-level-audit-actions)",
"type": "array",
"items": {
"type": "string"
}
},
"x-ms-mutability": [
"create",
"read"
]
},
"storageAccountSubscriptionId": {
"format": "uuid",
"description": "Specifies the blob storage subscription Id.",
"type": "string"
"type": "string",
"x-ms-mutability": [
"create",
"read"
]
},
"isStorageSecondaryKeyInUse": {
"description": "Specifies whether storageAccountAccessKey value is the storage's secondary key.",
Expand Down
Loading