Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users/v sparatala/merge allx ms mutability #20749

Merged
merged 65 commits into from
Oct 3, 2022
Merged

Users/v sparatala/merge allx ms mutability #20749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
de3fcd0
Remove "keyVaultUrl" in PUT schema reponse
sparatala Aug 30, 2022
8b6d8c2
Revert "Remove "keyVaultUrl" in PUT schema reponse"
sparatala Aug 30, 2022
d68f6ad
Update keyVaultUrl property to readOnly true
sparatala Aug 30, 2022
7de6196
Removed read-only and annotated to x-ms-mutability
sparatala Sep 1, 2022
cdd5003
Update Workspaces_Get property to x-ms-mutability
sparatala Sep 1, 2022
e4b92bd
Updated SqlPoolSecurityAlertPolicies_Get properties to x-ms-mutability
sparatala Sep 1, 2022
257de58
Update dynamicExecutorAllocation property with x-ms-mutability
sparatala Sep 1, 2022
06c79e1
Update Workspaces_Get createManagedPrivateEndpoint to x-ms-mutability
sparatala Sep 1, 2022
6323f5d
Updated workspace_Get property managedResourceGroupName to x-ms-mutab…
sparatala Sep 1, 2022
d09af65
Update SqlPools_Get property restorePointInTime to x-ms-mutability
sparatala Sep 2, 2022
595d872
Update WorkspaceManagedSqlServerBlobAuditingPolicies_Get property to …
sparatala Sep 2, 2022
8e1f026
Update SqlPools_Get collation to x-ms-mutability
sparatala Sep 5, 2022
8e1c901
Update KustoPools_Get KustoPool workspaceUID to x-ms-mutability
sparatala Sep 6, 2022
298c592
Fix model validation error
sparatala Sep 14, 2022
10739a6
Fixed review comments
sparatala Sep 15, 2022
98922b5
Merge branch 'main' into users/v-sparatala/Workspaces_Get
sparatala Sep 15, 2022
fc54535
Fix R2064 - LROStatusCodesReturnTypeSchema
sparatala Sep 15, 2022
1ec2ab9
Fix lint, model validation error
sparatala Sep 15, 2022
0868d31
Removed lro options
sparatala Sep 15, 2022
39ed591
Fix LRO lint error
sparatala Sep 15, 2022
2bc87d7
Merge branch 'main' into users/v-sparatala/sqlPool_SqlPoolSecurityAle…
sparatala Sep 16, 2022
f9328a4
Fix lint error
sparatala Sep 16, 2022
79aeb39
Fix lint error
sparatala Sep 16, 2022
64a64bb
Fix lint error
sparatala Sep 16, 2022
03e5ef1
Fix lint error
sparatala Sep 16, 2022
143a080
Fix lint error
sparatala Sep 16, 2022
ca7c706
Merge branch 'main' into users/v-sparatala/defaultDataLakeStorage_Wor…
sparatala Sep 16, 2022
e31bf74
Fix lint error
sparatala Sep 16, 2022
03d29c6
Merge branch 'main' into users/v-sparatala/managedResourceGroupName_W…
sparatala Sep 16, 2022
f51bea7
Merge branch 'main' into users/v-sparatala/sqlPool_SqlPoolSecurityAle…
sparatala Sep 16, 2022
f4cd5db
Fix lint error
sparatala Sep 16, 2022
65f0708
Fix lint error
sparatala Sep 16, 2022
8355ff9
Merge branch 'users/v-sparatala/Keys_Get' into users/v-sparatala/Merg…
sparatala Sep 16, 2022
df40a85
Merge branch 'users/v-sparatala/KustoPools_Get' into users/v-sparatal…
sparatala Sep 16, 2022
d231dd2
Merge branch 'users/v-sparatala/SqlPools_Get_Collation' into users/v-…
sparatala Sep 16, 2022
ba74717
Merge branch 'users/v-sparatala/WorkspaceManagedSqlServerBlobAuditing…
sparatala Sep 16, 2022
9eddd44
Merge branch 'users/v-sparatala/SqlPools_Get' into users/v-sparatala/…
sparatala Sep 16, 2022
71f48d8
Merge branch 'users/v-sparatala/managedResourceGroupName_Workspaces_G…
sparatala Sep 16, 2022
1665836
Merge branch 'users/v-sparatala/defaultDataLakeStorage_Workspaces_Get…
sparatala Sep 16, 2022
a53d773
Merge branch 'users/v-sparatala/BigDataPools_Get_dynamicExecutorAlloc…
sparatala Sep 16, 2022
441928b
Merge branch 'users/v-sparatala/sqlPool_SqlPoolSecurityAlertPolicies_…
sparatala Sep 16, 2022
721e5d1
Resolve conflict in workspace.json for preview, stable
sparatala Sep 16, 2022
4d93071
Resolved review comments
sparatala Sep 19, 2022
7662e36
Merge branch 'main' into users/v-sparatala/defaultDataLakeStorage_Wor…
sparatala Sep 19, 2022
58d97cc
Merge branch 'main' into users/v-sparatala/MergeAllx-ms-mutability
sparatala Sep 19, 2022
c45ce8f
Merge branch 'users/v-sparatala/defaultDataLakeStorage_Workspaces_Get…
sparatala Sep 19, 2022
0b80f7d
Fix review comments
sparatala Sep 22, 2022
9415769
Fix review comments
sparatala Sep 22, 2022
e0261ef
Resolve exception in kustoPool.json:
sparatala Sep 22, 2022
254707e
Resolve lint error
sparatala Sep 22, 2022
57b9e36
Resolve Model validation error
sparatala Sep 22, 2022
f08be61
Resolve model validation error
sparatala Sep 22, 2022
649de68
Resolve LRO error
sparatala Sep 22, 2022
a9bedc7
Resolve lint, model validation error
sparatala Sep 22, 2022
173c9e6
Resolve Model Validation error
sparatala Sep 22, 2022
727d087
Resolve model validation error
sparatala Sep 22, 2022
c3f2cf0
Resolve model validation error
sparatala Sep 22, 2022
0ed4d48
Resolve Model validation error
sparatala Sep 22, 2022
34a1432
Resolve model validation error
sparatala Sep 23, 2022
d8831c6
Resolve review comments
sparatala Sep 23, 2022
4722421
Resolve model validation error
sparatala Sep 23, 2022
afced2c
Remove header location
sparatala Sep 29, 2022
5537037
Resolve runtime exception for schema violation
sparatala Sep 29, 2022
52900df
Resolve model validation error
sparatala Sep 29, 2022
fd37ac4
Resolve schema violation exception
sparatala Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...Microsoft.Synapse/preview/2021-04-01-preview/examples/KustoPoolDataConnectionsUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
"responses": {
"200": {
"headers": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share the reason for this change?

Copy link
Contributor Author

@sparatala sparatala Sep 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-ms-longrunning operation error was showing hence header with "location"

"location": "West US"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand All @@ -31,6 +34,9 @@
}
},
"201": {
"headers": {
"location": "West US"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand Down
6 changes: 6 additions & 0 deletions ...nager/Microsoft.Synapse/preview/2021-04-01-preview/examples/KustoPoolDatabasesUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
},
"responses": {
"200": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand All @@ -28,6 +31,9 @@
}
},
"201": {
"headers": {
"location": true
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand Down
6 changes: 6 additions & 0 deletions ...ource-manager/Microsoft.Synapse/preview/2021-04-01-preview/examples/KustoPoolsUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
"responses": {
"200": {
"headers": {
"location": "West US"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand All @@ -36,6 +39,9 @@
}
},
"201": {
"headers": {
"location": "West US"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand Down
21 changes: 15 additions & 6 deletions ...on/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,15 +253,15 @@
"responses": {
"200": {
"schema": {
"type": "object"
"$ref": "#/definitions/BigDataPoolResourceInfo"
},
"description": "OK"
},
"202": {
"schema": {
"type": "object"
"$ref": "#/definitions/BigDataPoolResourceInfo"
},
"description": ""
"description": "Created"
},
"204": {
"description": ""
Expand Down Expand Up @@ -457,7 +457,8 @@
"type": "array",
"items": {
"$ref": "../../../../common/v1/types.json#/definitions/LibraryInfo"
}
},
"x-ms-identifiers": []
},
"sparkConfigProperties": {
"$ref": "#/definitions/SparkConfigProperties",
Expand Down Expand Up @@ -566,12 +567,20 @@
"minExecutors": {
"type": "integer",
"format": "int32",
"description": "The minimum number of executors alloted"
"description": "The minimum number of executors alloted",
"x-ms-mutability": [
"create",
"update"
sparatala marked this conversation as resolved.
Show resolved Hide resolved
]
},
"maxExecutors": {
"type": "integer",
"format": "int32",
"description": "The maximum number of executors alloted"
"description": "The maximum number of executors alloted",
"x-ms-mutability": [
"create",
"update"
]
}
}
},
Expand Down
13 changes: 12 additions & 1 deletion .../preview/2021-06-01-preview/examples/CreateOrUpdateManagedIdentitySqlControlSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@
}
}
},
"201": {}
"201": {
"body": {
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/resourceGroup1/providers/Microsoft.Synapse/workspaces/workspace1/managedIdentitySqlControlSettings/default",
"name": "default",
"properties": {
"grantSqlControlToManagedIdentity": {
"desiredState": "Enabled",
"actualState": "Enabling"
}
}
}
}
}
}
1 change: 0 additions & 1 deletion ...ager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DataWarehouseQueriesSteps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"id": "/subscriptions/cde3513f-fbc4-414d-abc2-c4b2ad011bd8/resourceGroups/kedodd2021synrg1/providers/Microsoft.Synapse/workspaces/kedoddsynprodws/sqlPools/kedoddsqlpool1/dataWarehouseQueries/QID683040/steps/0",
"type": "Microsoft.Synapse/workspaces/sqlPools/dataWarehouseQueries/steps",
"name": "0",
"location": "null",
"properties": {
"queryId": "QID683040",
"startTime": "2022-08-01T02:27:39.36",
Expand Down
6 changes: 6 additions & 0 deletions ...urce-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteBigDataPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"responses": {
"204": {},
"200": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/bigDataPools/ExamplePool",
"type": "Microsoft.Synapse/workspaces/bigDataPools",
Expand Down Expand Up @@ -43,6 +46,9 @@
}
},
"202": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/bigDataPools/ExamplePool",
"type": "Microsoft.Synapse/workspaces/bigDataPools",
Expand Down
6 changes: 6 additions & 0 deletions ...resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/DeleteSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
},
"responses": {
"200": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/sqlPools/ExampleSqlPool",
"name": "ExampleSqlPool",
Expand All @@ -20,6 +23,9 @@
}
},
"202": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/01234567-89ab-4def-0123-456789abcdef/resourceGroups/ExampleResourceGroup/providers/Microsoft.Synapse/workspaces/ExampleWorkspace/sqlPools/ExampleSqlPool",
"name": "ExampleSqlPool",
Expand Down
3 changes: 1 addition & 2 deletions ...anager/Microsoft.Synapse/preview/2021-06-01-preview/examples/GetDatawareHouseQueries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"id": "/subscriptions/cde3513f-fbc4-414d-abc2-c4b2ad011bd8/resourceGroups/kedodd2021synrg1/providers/Microsoft.Synapse/workspaces/kedoddsynprodws/sqlPools/kedoddsqlpool1/datawarehousequeries/QID683040",
"type": "Microsoft.Synapse/workspaces/sqlPools/dataWarehouseQueries",
"name": "QID683040",
"location": "null",
"properties": {
"queryId": "QID683040",
"startTime": "2022-08-01T02:27:39.36",
Expand All @@ -30,7 +29,7 @@
"login": "System",
"progress": 100,
"sessionId": "SID41961",
"resourceClass": "N/A",
"resourceClass": "smallrc",
"concurrencySlots": "N/A"
}
}
Expand Down
14 changes: 2 additions & 12 deletions ...osoft.Synapse/preview/2021-06-01-preview/examples/GetLocationHeaderResultWithSqlPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,11 @@
"200": {
"body": {
"sku": {},
"kind": "v12.0,user,datawarehouse,gen2",
"properties": {
"collation": "SQL_Latin1_General_CP1_CI_AS",
"maxSizeBytes": 263882790666240,
"status": "Paused",
"databaseId": "00000000-1111-2222-3333-444444444444",
"creationDate": "2022-08-25T09:22:46.68Z",
"currentServiceObjectiveName": "DW100c",
"defaultSecondaryLocation": "westus",
"catalogCollation": "SQL_Latin1_General_CP1_CI_AS"
"creationDate": "2022-08-25T09:22:46.68Z"
},
"location": "eastus",
"tags": {},
Expand All @@ -32,16 +27,11 @@
"202": {
"body": {
"sku": {},
"kind": "v12.0,user,datawarehouse,gen2",
"properties": {
"collation": "SQL_Latin1_General_CP1_CI_AS",
"maxSizeBytes": 263882790666240,
"status": "Paused",
"databaseId": "00000000-1111-2222-3333-444444444444",
"creationDate": "2022-08-25T09:22:46.68Z",
"currentServiceObjectiveName": "DW100c",
"defaultSecondaryLocation": "westus",
"catalogCollation": "SQL_Latin1_General_CP1_CI_AS"
"creationDate": "2022-08-25T09:22:46.68Z"
},
"location": "eastus",
"tags": {},
Expand Down
6 changes: 6 additions & 0 deletions ...Microsoft.Synapse/preview/2021-06-01-preview/examples/KustoPoolDataConnectionsUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
},
"responses": {
"200": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand All @@ -31,6 +34,9 @@
}
},
"202": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8/DataConnections/DataConnections8",
"name": "KustoClusterRPTest4/KustoDatabase8/DataConnections8",
Expand Down
6 changes: 6 additions & 0 deletions ...nager/Microsoft.Synapse/preview/2021-06-01-preview/examples/KustoPoolDatabasesUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
},
"responses": {
"200": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand All @@ -28,6 +31,9 @@
}
},
"202": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4/Databases/KustoDatabase8",
"name": "KustoClusterRPTest4/KustoDatabase8",
Expand Down
6 changes: 6 additions & 0 deletions ...ource-manager/Microsoft.Synapse/preview/2021-06-01-preview/examples/KustoPoolsUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
},
"responses": {
"200": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand All @@ -39,6 +42,9 @@
}
},
"202": {
"headers": {
"azure-asyncoperation": "https://ms.web.azuresynapse.net"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-123456789098/resourceGroups/kustorptest/providers/Microsoft.Synapse/workspaces/synapseWorkspaceName/kustopools/KustoClusterRPTest4",
"name": "KustoClusterRPTest4",
Expand Down
6 changes: 5 additions & 1 deletion ...ification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,11 @@
},
"keyVaultUrl": {
"type": "string",
"description": "The Key Vault Url of the workspace key."
"description": "The Key Vault Url of the workspace key.",
"x-ms-mutability": [
"create",
"read"
]
}
}
}
Expand Down
Loading