Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redis Cache] New API Version 2022-06-01 with some extra linked server properties added for server role update/failover support #20869

Merged
merged 8 commits into from
Sep 30, 2022
Merged

[Redis Cache] New API Version 2022-06-01 with some extra linked server properties added for server role update/failover support #20869

merged 8 commits into from
Sep 30, 2022

Conversation

rohanand-MS
Copy link
Contributor

@rohanand-MS rohanand-MS commented Sep 26, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @rohanand-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 26, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 27 Warnings warning [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    redis.json 2022-06-01(d75799d) 2022-05-01(main)
    redis.json 2022-06-01(d75799d) 2019-07-01(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listUpgradeNotifications' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L103:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L155:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L354:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/Redis' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L394:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listKeys' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L427:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/regenerateKey' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L471:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/forceReboot' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L524:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/import' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L577:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/export' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L634:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L691:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules/{ruleName}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L739:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/patchSchedules' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L906:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/patchSchedules/{default}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L954:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers/{linkedServerName}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1142:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1304:5
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L61:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L106:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1969:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1969:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1969:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1969:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1976:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1976:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1976:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1976:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L1972:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1485:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Cache/stable/2022-06-01/redis.json#L2257:5
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1708:5
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-06 package-2022-06(d75799d) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L73
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2425
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L37
    ❌ R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L1856
    ❌ R4037 - MissingTypeObject The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L1896
    ❌ R4037 - MissingTypeObject The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2033
    ❌ R4037 - MissingTypeObject The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2065
    ❌ R4037 - MissingTypeObject The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2080
    ❌ R4037 - MissingTypeObject The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2163
    ❌ R4037 - MissingTypeObject The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2203
    ❌ R4037 - MissingTypeObject The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2224
    ❌ R4037 - MissingTypeObject The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2239
    ❌ R4037 - MissingTypeObject The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2265
    ❌ R4037 - MissingTypeObject The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2282
    ❌ R4037 - MissingTypeObject The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2299
    ❌ R4037 - MissingTypeObject The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2328
    ❌ R4037 - MissingTypeObject The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2366
    ❌ R4037 - MissingTypeObject The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2383
    ❌ R4037 - MissingTypeObject The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2403
    ❌ R4037 - MissingTypeObject The schema 'ExportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2433
    ❌ R4037 - MissingTypeObject The schema 'ImportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2458
    ❌ R4037 - MissingTypeObject The schema 'ScheduleEntry' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2481
    ❌ R4037 - MissingTypeObject The schema 'ScheduleEntries' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2519
    ❌ R4037 - MissingTypeObject The schema 'RedisPatchSchedule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2536
    ❌ R4037 - MissingTypeObject The schema 'RedisPatchScheduleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2559
    ❌ R4037 - MissingTypeObject The schema 'RedisForceRebootResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2576
    ❌ R4037 - MissingTypeObject The schema 'RedisLinkedServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2586
    ❌ R4037 - MissingTypeObject The schema 'RedisLinkedServerWithProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2596
    ❌ R4037 - MissingTypeObject The schema 'RedisLinkedServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2611
    ❌ R4037 - MissingTypeObject The schema 'RedisLinkedServerWithPropertiesList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2022-06-01/redis.json#L2626
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 55 Errors, 0 Warnings failed [Detail]

    Tag package-2022-06; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 32, untested: 0, failed: 28, passed: 4

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ CLIENT_ERROR "statusCode: 400,
    errorCode: ResourceTypeNotSupportAvailabilityZones,
    errorMessage: The resource type 'Redis' does not support availability zones at location 'westcentralus' and api-version '2022-06-01'."
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 400"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Cache/Redis/nametbglli' under resource group 'apiTest-YTfwgB-20869' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'cachenamelww1ud' not found."
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'cachenamelww1ud' not found."
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ❌ CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'cachenamelww1ud' not found."
    ❌ ASSERTION_ERROR "expected response code to be 2XX but found 404"
    ️⚠️~[Staging] TrafficValidation: 1 Warnings warning [Detail]

    restlerResult: Request coverage (successful / total): 4 / 32 Attempted requests: 12 / 32
    Traffic validation failed. Check pipeline artifact for restler output and detail report.

    Rule Message
    ⚠️ Traffic validation result. "Starting task Test...\nUsing python: 'python3' (Python 3.10.5)\nRequest coverage (successful / total): 4 / 32\nAttempted requests: 12 / 32\nNo bugs were found.\nTask Test succeeded.\nCollecting logs...\n"
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️❌SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/d75799db51854d9ec0ce692a80c8b31cfceb2009/specification/redis/resource-manager/readme.md#tag-package-2022-06">redis/resource-manager/readme.md#package-2022-06
    The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ PreCheck/DuplicateSchema "readme":"redis/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:251" => "#/components/schemas/schemas:463"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    ❌ "readme":"redis/resource-manager/readme.md",
    "tag":"package-2022-06",
    "details":"Error: 1 errors occured -- cannot continue."
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 26, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ec278eb. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Redis [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ec278eb. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.19.2` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redis [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model RedisLinkedServerCreateParameters has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerCreateParameters has a new parameter primary_host_name
info	[Changelog]   - Model RedisLinkedServerCreateProperties has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerCreateProperties has a new parameter primary_host_name
info	[Changelog]   - Model RedisLinkedServerProperties has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerProperties has a new parameter primary_host_name
info	[Changelog]   - Model RedisLinkedServerWithProperties has a new parameter geo_replicated_primary_host_name
info	[Changelog]   - Model RedisLinkedServerWithProperties has a new parameter primary_host_name
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ec278eb. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/redis/armredis [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `CommonProperties` has been removed
info	[Changelog] - Struct `CreateProperties` has been removed
info	[Changelog] - Struct `OperationStatus` has been removed
info	[Changelog] - Struct `Properties` has been removed
info	[Changelog] - Struct `UpdateProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `PrimaryHostName` in struct `LinkedServerCreateProperties`
info	[Changelog] - New field `GeoReplicatedPrimaryHostName` in struct `LinkedServerCreateProperties`
info	[Changelog] - New field `PrimaryHostName` in struct `LinkedServerProperties`
info	[Changelog] - New field `GeoReplicatedPrimaryHostName` in struct `LinkedServerProperties`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 2 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ec278eb. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-rediscache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Interface RedisLinkedServerCreateParameters has a new optional parameter geoReplicatedPrimaryHostName
info	[Changelog]   - Interface RedisLinkedServerCreateParameters has a new optional parameter primaryHostName
info	[Changelog]   - Interface RedisLinkedServerCreateProperties has a new optional parameter geoReplicatedPrimaryHostName
info	[Changelog]   - Interface RedisLinkedServerCreateProperties has a new optional parameter primaryHostName
info	[Changelog]   - Interface RedisLinkedServerWithProperties has a new optional parameter geoReplicatedPrimaryHostName
info	[Changelog]   - Interface RedisLinkedServerWithProperties has a new optional parameter primaryHostName
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Operation PatchSchedules.createOrUpdate has a new signature
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ec278eb. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ec278eb. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Redis [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Redis Cache label Sep 26, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 26, 2022 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/redis/armredis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-redis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-redis-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Redis Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-rediscache Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @azure-sdk azure-sdk mentioned this pull request Sep 26, 2022
    Closed
    @rohanand-MS rohanand-MS marked this pull request as ready for review September 26, 2022 10:36
    This was referenced Sep 26, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request Sep 26, 2022
    Closed
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @rohanand-MS your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @rohanand-MS
    Copy link
    Contributor Author

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @rohanand-MS rohanand-MS changed the title [Hub Generated] Review request for Microsoft.Cache to add version stable/2022-06-01 [Redis Cache] New API Version 2022-06-01 with some extra linked server properties added for server role update/failover support Sep 26, 2022
    @AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Sep 26, 2022
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi @rohanand-MS, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @TimLovellSmith
    Copy link
    Member

    @rohanand-MS I see the PR #20348 just got merged and adds a new 'latest stable version'. It would probably be good to redo your PR based on the new latest stable version.

    @rohanand-MS
    Copy link
    Contributor Author

    @TimLovellSmith 2022-05-01 Stable version was already existing and the newer api version 2022-06-01 in current PR is based on top of it only. The latest merged PR has a one line description update for rdb-backup-frequency which I have incorporated in the newer version as well.

    TimLovellSmith
    TimLovellSmith approved these changes Sep 30, 2022
    View reviewed changes
    Copy link
    Member

    @TimLovellSmith TimLovellSmith left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM, thanks for iterating on this!

    @rohanand-MS rohanand-MS added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 30, 2022
    @rohanand-MS
    Copy link
    Contributor Author

    @ArcturusZhang Please help in the merge of this PR.

    @tianxchen-ms tianxchen-ms merged commit ec278eb into Azure:main Sep 30, 2022
    This was referenced Sep 30, 2022
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 30, 2022
    [ReleasePR redis] [Redis Cache] New API Version 2022-06-01 with some …
    82aeb69 
    …extra linked server properties added for server role update/failover support (#2584)

Create to sync Azure/azure-rest-api-specs#20869
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/redis?expand=1)
    @austintolani austintolani mentioned this pull request Oct 13, 2022
    Merged
    This was referenced Oct 26, 2022
    Merged
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @TimLovellSmith TimLovellSmith TimLovellSmith approved these changes

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test Redis Cache resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @rohanand-MS @TimLovellSmith @tianxchen-ms @ArcturusZhang @AzureRestAPISpecReview