Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventGrid - AzureHealthcareApis swagger update for GA #20918
EventGrid - AzureHealthcareApis swagger update for GA #20918
Changes from 1 commit
87b7f58
d561b16
94ac34f
d7c665a
91e1da8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the sequence purely a service concept? i.e. is not called out in the DICOM spec? Is this different than the Sequence defined here - https://dicom.nema.org/medical/Dicom/2016c/output/chtml/part03/sect_5.2.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I called this sequence based on your comment in the private PR. It was previously called
changefeedId
.Its not the same sequence from that link. Its essentially the sequence number for changes occurred in the dicom service. Each dicom service keeps a change log. When any image is added or deleted from the service, that change gets added to the change log with a new sequence number. This change log is exposed through our Change Feed API https://github.com/microsoft/dicom-server/blob/main/docs/concepts/change-feed.md , which is specific to our service and not part of the DICOM standard.
I like the change to
sequence
because it is more generic, however I don't want to get it confused with this kind of Sequence https://dicom.nema.org/medical/Dicom/2016c/output/chtml/part03/sect_5.2.html . What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think SequenceNumber is a bit less ambiguous even aside from the Dicom naming conflict. Is the Change Feed API already GA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the Changefeed API is GA in our service, it was included in the initial GA release of the DICOM service in March.
I will go ahead and change to property to
sequenceNumber