[CDN] 2022-11-01-preview #20979
Merged
[CDN] 2022-11-01-preview #20979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenglongLiu
requested review from
jorinmejia,
yunheMsft and
t-bzhan
as code owners
|
Hi, @ChenglongLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.1)] | new version | base version |
|---|---|---|
| afdx.json | 2022-11-01-preview(98c0bbc) | 2021-06-01(main) |
| afdx.json | 2022-11-01-preview(98c0bbc) | 2022-05-01-preview(main) |
| cdn.json | 2022-11-01-preview(98c0bbc) | 2021-06-01(main) |
| cdn.json | 2022-11-01-preview(98c0bbc) | 2022-05-01-preview(main) |
| cdnwebapplicationfirewall.json | 2022-11-01-preview(98c0bbc) | 2021-06-01(main) |
| cdnwebapplicationfirewall.json | 2022-11-01-preview(98c0bbc) | 2022-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/validateSecret' removed or restructured? Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L3242:5 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5732:9 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5487:9 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5752:15 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5503:15 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5965:9 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5712:9 |
|
The new version adds a x-ms-enum extension. New: Microsoft.Cdn/preview/2022-11-01-preview/afdx.json#L5985:15 Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5728:15 |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-11 | package-preview-2022-11(98c0bbc) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3695 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3695 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3695 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3741 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3741 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3741 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3772 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3772 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3772 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3794 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3794 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3794 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3847 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3847 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3847 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3904 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3904 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3904 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3957 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3957 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L3957 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4014 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4014 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4014 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4067 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4067 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4067 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4073 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4073 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L4073 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/cdn/resource-manager/readme.md json: Microsoft.Cdn/preview/2022-05-01-preview/afdx.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️❌ModelValidation: 52 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
|
Hi @ChenglongLiu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
SuppressionReviewRequired
WaitForARMFeedback
AzureRestAPISpecReview
added
the
ReadyForApiTest
NetRock
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@ChenglongLiu, regard to |
JeffreyRichter
added
the
Approved-BreakingChange
|
@fengzhou-msft could you help check the dotnet sdk generation failure? |
|
@msyyc Could you help check the breaking change for python? |
|
@tadelesh Could you help check the breaking change for go? |
|
@qiaozha Could you help check the breaking change for js? |
tadelesh
added
the
Approved-SdkBreakingChange-Go
|
Approved for Go breaking changes, includes: |
|
Approve for .NET breaking changes as they can be fixed by renaming configurations. |
live1206
approved these changes
Nov 8, 2022
This was referenced Nov 8, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Nov 8, 2022
This was referenced Nov 8, 2022
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
* Init 2022-11-01-preview * Fix check * Move Validate_Secret to profile * Add AFDProfiles_Upgrade * Update api version * Add msi support * Fix check issue * Fix check issue * Fix check * Fix check * Fix check * Fix check * Fix check * Merge from 2022-05-01 * Fix comments * Update description for waf * Update incorrect description * Update incorrect description * Fix comments * Fix PrettierCheck * Update * Add Type * Added negative caching setting into CacheConfiguration * Fix checker * Delete isNegativeCachingEnabled * Add headers for 202 * Format * Format * Add headers for 202 * Add headers for 202 * Add headers for 202 * Add scenarios * Add scenarios Co-authored-by: Zhuofu Deng <zhden@microsoft.com>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
* Init 2022-11-01-preview * Fix check * Move Validate_Secret to profile * Add AFDProfiles_Upgrade * Update api version * Add msi support * Fix check issue * Fix check issue * Fix check * Fix check * Fix check * Fix check * Fix check * Merge from 2022-05-01 * Fix comments * Update description for waf * Update incorrect description * Update incorrect description * Fix comments * Fix PrettierCheck * Update * Add Type * Added negative caching setting into CacheConfiguration * Fix checker * Delete isNegativeCachingEnabled * Add headers for 202 * Format * Format * Add headers for 202 * Add headers for 202 * Add headers for 202 * Add scenarios * Add scenarios Co-authored-by: Zhuofu Deng <zhden@microsoft.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.