[Hub Generated] Publish private branch 'appplatform/release/s212' #21467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/9496 |
zhoufenqin
requested review from
Wzb123456789 and
ArcturusZhang
as code owners
|
Hi, @zhoufenqin Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.1)] | new version | base version |
|---|---|---|
| appplatform.json | 2022-11-01-preview(00f3dcc) | 2022-04-01(main) |
| appplatform.json | 2022-11-01-preview(00f3dcc) | 2022-09-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The read only property has changed from 'false' to 'true'. New: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L9439:9 Old: Microsoft.AppPlatform/stable/2022-04-01/appplatform.json#L6228:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 34 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-11 | package-preview-2022-11(00f3dcc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L8427 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L8556 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L11533 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12162 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12286 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12532 |
||
| The operation 'CustomizedAccelerators_Validate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L7076 |
||
| The child tracked resource, 'applicationLiveViews' with immediate parent 'ServiceResource', must have a list by immediate parent operation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L8418 |
||
| The child tracked resource, 'DevToolPortals' with immediate parent 'ServiceResource', must have a list by immediate parent operation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L8547 |
||
| The child tracked resource, 'applicationAccelerators' with immediate parent 'ServiceResource', must have a list by immediate parent operation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12153 |
||
| The child tracked resource, 'customizedAccelerators' with immediate parent 'ApplicationAcceleratorResource', must have a list by immediate parent operation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12277 |
||
| The child tracked resource, 'predefinedAccelerators' with immediate parent 'ApplicationAcceleratorResource', must have a list by immediate parent operation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12523 |
||
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: public Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L8596 |
||
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: ssoEnabled Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L11810 |
||
| 'ApplicationAcceleratorComponent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12205 |
||
| 'name' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12208 |
||
| 'instances' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12215 |
||
| 'ApplicationAcceleratorResourceRequests' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12227 |
||
| 'ApplicationAcceleratorInstance' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12248 |
||
| 'CustomizedAcceleratorResourceCollection' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12263 |
||
| 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12266 |
||
| 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12272 |
||
| 'displayName' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12318 |
||
| 'description' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12321 |
||
| 'iconUrl' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12324 |
||
| 'acceleratorTags' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12327 |
||
| 'AcceleratorGitRepository' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12338 |
||
| 'PredefinedAcceleratorResourceCollection' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12509 |
||
| 'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12512 |
||
| 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AppPlatform/preview/2022-11-01-preview/appplatform.json#L12518 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Hi @zhoufenqin, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Nov 8, 2022
|
This pull request is composed of several children pr and all the breaking changes have been approved previously in private repo. |
xiaoxuqi-ms
approved these changes
Nov 8, 2022
xiaoxuqi-ms
deleted the
published/Azure/azure-rest-api-specs-pr/appplatform/release/s212
branch
This was referenced Nov 8, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Nov 8, 2022
…atform/release/s212' (#2656) Create to sync Azure/azure-rest-api-specs#21467 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/appplatform?expand=1)
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…ure#21467) * [AutoSync] cad511c2e Merge remote-tracking branch 'origin/master' into release/s212 * fix typo Co-authored-by: swagger-automation <swagger@microsoft.com> Co-authored-by: Yuwei Zhou <yuwzho@microsoft.com>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
…ure#21467) * [AutoSync] cad511c2e Merge remote-tracking branch 'origin/master' into release/s212 * fix typo Co-authored-by: swagger-automation <swagger@microsoft.com> Co-authored-by: Yuwei Zhou <yuwzho@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.