Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Face PersonDirectory argument type mismatch fix #21572

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Face PersonDirectory argument type mismatch fix #21572

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf584aa
Fix Face PersonDirectory argument type mismatch
msyache Nov 11, 2022
0e32458
Fix person request type
msyache Nov 18, 2022
c58cb72
Fix AddPersonFace missing url in json
msyache Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 42 additions & 12 deletions specification/cognitiveservices/data-plane/Face/preview/v1.0-preview/Face.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2542,6 +2542,7 @@
{
"in": "query",
"name": "start",
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -2591,7 +2592,7 @@
"name": "body",
"required": true,
"schema": {
"$ref": "#/definitions/EnrolledPerson"
"$ref": "#/definitions/EnrollmentRequest"
}
}
],
Expand Down Expand Up @@ -2640,6 +2641,7 @@
"in": "path",
"name": "personId",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -2682,6 +2684,7 @@
"in": "path",
"name": "personId",
"required": true,
"format": "uuid",
"type": "string"
}
],
Expand Down Expand Up @@ -2723,6 +2726,7 @@
"name": "personId",
"description": "Person id.",
"required": true,
"format": "uuid",
"type": "string"
}
],
Expand Down Expand Up @@ -2753,7 +2757,7 @@
"PersonDirectory"
],
"summary": "Add a new face to person.",
"operationId": "PersonDirectory_AddPersonFace",
"operationId": "PersonDirectory_AddPersonFaceFromUrl",
"produces": [
"application/json"
],
Expand All @@ -2763,6 +2767,7 @@
"name": "personId",
"description": "Person id.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand All @@ -2789,6 +2794,9 @@
"name": "targetFace",
"description": "Target face.",
"type": "string"
},
{
"$ref": "../../../Common/Parameters.json#/parameters/ImageUrl"
}
],
"responses": {
Expand Down Expand Up @@ -2832,6 +2840,7 @@
"name": "personId",
"description": "Target person to get persistedFaceIds from.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -2879,6 +2888,7 @@
"name": "personId",
"description": "Person id.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand All @@ -2893,6 +2903,7 @@
"name": "persistedFaceId",
"description": "Persisted face id to delete.",
"required": true,
"format": "uuid",
"type": "string"
}
],
Expand Down Expand Up @@ -2934,6 +2945,7 @@
"name": "personId",
"description": "Target person to get face from.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand All @@ -2948,6 +2960,7 @@
"name": "persistedFaceId",
"description": "Target person face id to get.",
"required": true,
"format": "uuid",
"type": "string"
}
],
Expand Down Expand Up @@ -2989,6 +3002,7 @@
"name": "personId",
"description": "Target person to update face from.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand All @@ -3003,6 +3017,7 @@
"name": "persistedFaceId",
"description": "PersistedFaceId created from Person Face Create",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -3245,6 +3260,7 @@
"in": "query",
"name": "start",
"description": "List persons from the least personId greater than the \"start\". It contains no more than 64 characters. Default is empty.",
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -3339,6 +3355,7 @@
"name": "personId",
"description": "Valid PersonId created from Person Create.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -3694,6 +3711,7 @@
"name": "personId",
"description": "Person id.",
"required": true,
"format": "uuid",
"type": "string"
},
{
Expand Down Expand Up @@ -5218,7 +5236,8 @@
"properties": {
"personId": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
Copy link
Member

@jhendrixMSFT jhendrixMSFT Nov 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since x-nullable:false is the default, can you please remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to explicitly add it in order for AutoRest to generate a property without nullable--we needed type Guid instead of Guid? there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. No need to block on this then but that seems weird.

@mikekistler do you know if this is a bug in the C# codegen?

},
"name": {
"type": "string"
Expand All @@ -5233,7 +5252,8 @@
"properties": {
"personId": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
},
"name": {
"type": "string"
Expand All @@ -5248,7 +5268,8 @@
"properties": {
"personId": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
}
}
},
Expand All @@ -5268,7 +5289,8 @@
"properties": {
"persistedFaceId": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
},
"recognitionModel": {
"type": "string"
Expand All @@ -5283,13 +5305,15 @@
"properties": {
"personId": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
},
"persistedFaceIds": {
"type": "array",
"items": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
}
},
"name": {
Expand Down Expand Up @@ -5342,7 +5366,9 @@
"addPersonIds": {
"type": "array",
"items": {
"type": "string"
"format": "uuid",
"type": "string",
"x-nullable": false
}
}
}
Expand All @@ -5365,7 +5391,9 @@
"addPersonIds": {
"type": "array",
"items": {
"type": "string"
"format": "uuid",
"type": "string",
"x-nullable": false
}
}
}
Expand All @@ -5391,7 +5419,8 @@
"type": "array",
"items": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
}
}
}
Expand All @@ -5401,7 +5430,8 @@
"properties": {
"personId": {
"format": "uuid",
"type": "string"
"type": "string",
"x-nullable": false
},
"dynamicPersonGroupIds": {
"type": "array",
Expand Down