-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cadl dpg add convenience api #21575
Merged
catalinaperalta
merged 2 commits into
feature/anomaly-detector-cadl
from
cadl-dpg-add-convenience-api
Nov 17, 2022
Merged
Cadl dpg add convenience api #21575
catalinaperalta
merged 2 commits into
feature/anomaly-detector-cadl
from
cadl-dpg-add-convenience-api
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Hi, @weidongxu-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
ghost
added
the
Cognitive Services
label
Nov 16, 2022
Swagger Validation Report
|
Rule | Message |
---|---|
MissingExamplesDirectory |
"details":"The 'examples' directory is missing in the cadl folder specification/cognitiveservices/data-plane/AnomalyDetector/stable/v1.1/cadl, please ensure the 'examples' is added in the PR." |
SwaggerNotExistInPR |
"details":"the generated swagger file v1.1/openapi.json from cadl specification/cognitiveservices/data-plane/AnomalyDetector/stable/v1.1/cadl is not in the PR, please make sure it presents into the PR." |
The ModelProperty named 'x-ms-error' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/univariate/models.cadl#L180 |
|
The ModelProperty named 'body' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/univariate/routes.cadl#L21 |
|
The ModelProperty named 'body' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/univariate/routes.cadl#L33 |
|
The ModelProperty named 'body' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/univariate/routes.cadl#L42 |
|
The Model named 'ErrorResponse' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L80 |
|
The Model named 'AnomalyState' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L142 |
|
The Model named 'AnomalyValue' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L151 |
|
The Model named 'AnomalyInterpretation' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L173 |
|
The Model named 'CorrelationChanges' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L185 |
|
The ModelProperty named 'variableStates' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L267 |
|
The Model named 'LastDetectionRequest' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L332 |
|
The Model named 'LastDetectionResult' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L358 |
|
The ModelProperty named 'results' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/models.cadl#L360 |
|
The ModelProperty named 'resultId' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/routes.cadl#L19 |
|
The ModelProperty named 'body' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/routes.cadl#L38 |
|
Operation 'ListMultivariateModels' should be defined using a signature from the Azure.Core namespace. Location: v1.1/cadl/multivariate/routes.cadl#L46 |
|
Operation 'GetMultivariateModel' should be defined using a signature from the Azure.Core namespace. Location: v1.1/cadl/multivariate/routes.cadl#L77 |
|
The ModelProperty named 'body' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/routes.cadl#L106 |
|
The names of Property types must use camelCase Location: v1.1/cadl/multivariate/routes.cadl#L111 |
|
The ModelProperty named 'body' should have a documentation or description, please use decorator @doc to add it. Location: v1.1/cadl/multivariate/routes.cadl#L129 |
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
weidongxu-microsoft
force-pushed
the
cadl-dpg-add-convenience-api
branch
from
November 16, 2022 05:02
fdc276b
to
85135e8
Compare
catalinaperalta
changed the base branch from
main
to
feature/anomaly-detector-cadl
November 16, 2022 17:48
lmazuel
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge please
lmazuel
approved these changes
Nov 17, 2022
catalinaperalta
approved these changes
Nov 17, 2022
lmazuel
added a commit
that referenced
this pull request
Dec 3, 2022
…21525) * add univariate cadl definitions * add cadl project yaml and main cadl * add package.json * add initial multivariate cadl definitions * update cadl-project.yaml and package.json * update route names * add univariate azure core operation defs * update multivariate models for correctness * update routes to reflect service instead of using cadl azure operation signatures * update multivariate models for correctness with original swagger * a note about errors * decorate request and response bodies with body decorator * update package.json to point to next package versions * fix routes to match swagger names * add client.cadl * remove client.cadl * fix GetBatchDetectionResult def * add namespace for univariate models * Version AD (#21497) * Update main.cadl * fix versioning * leave api version as required Co-authored-by: Catalina Peralta <catalinaperaltah@hotmail.com> * add extensible api version enum * update cadl-project.yaml with python config * update sdk version * clean up routes * clean up cadl-project.yaml * clean up models * update package.json to ref latest deps * add newline * add more models docs * fix error response models * rename get multivariate batch result * Cadl dpg add convenience api (#21575) * add @convenienceAPI * move @convenienceAPI to client.cadl * add placeholder examples file * add generated openapi spec * delete older swaggers * update cadl-project.yaml * update package.json * Add cadl-csharp parameters for AnomalyDetector (#21647) * Change cadl-project * Add .net parameters * Fix * update error header uvad * Make model-namespace false for .net (#21686) * [AnomalyDetector] Archboard feedback (#21680) * rename to train only * archboard naming feedback * rename response to result * archboard renames mvad requests to options * rename uvad request to options * rename model * rename model on operations * more mvad renames * update body naming * update body param naming to not use a reserved keyword * restructure cadl files * move generated cadl * update client.cadl * update swagger output * Update specification/cognitiveservices/AnomalyDetector/univariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/univariate/routes.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/routes.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * make data schema enum extensible * make errors on ModelInfo readonly * update swagger * update readme swagger refs * add apiview to custom-words.txt * update more refs in readme * move existing examples up with CADL files * configure swagger file name in emmiter * format examples * point to examples dir in cadl-project.yaml * add generated swagger and examples Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com> Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com>
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…zure#21525) * add univariate cadl definitions * add cadl project yaml and main cadl * add package.json * add initial multivariate cadl definitions * update cadl-project.yaml and package.json * update route names * add univariate azure core operation defs * update multivariate models for correctness * update routes to reflect service instead of using cadl azure operation signatures * update multivariate models for correctness with original swagger * a note about errors * decorate request and response bodies with body decorator * update package.json to point to next package versions * fix routes to match swagger names * add client.cadl * remove client.cadl * fix GetBatchDetectionResult def * add namespace for univariate models * Version AD (Azure#21497) * Update main.cadl * fix versioning * leave api version as required Co-authored-by: Catalina Peralta <catalinaperaltah@hotmail.com> * add extensible api version enum * update cadl-project.yaml with python config * update sdk version * clean up routes * clean up cadl-project.yaml * clean up models * update package.json to ref latest deps * add newline * add more models docs * fix error response models * rename get multivariate batch result * Cadl dpg add convenience api (Azure#21575) * add @convenienceAPI * move @convenienceAPI to client.cadl * add placeholder examples file * add generated openapi spec * delete older swaggers * update cadl-project.yaml * update package.json * Add cadl-csharp parameters for AnomalyDetector (Azure#21647) * Change cadl-project * Add .net parameters * Fix * update error header uvad * Make model-namespace false for .net (Azure#21686) * [AnomalyDetector] Archboard feedback (Azure#21680) * rename to train only * archboard naming feedback * rename response to result * archboard renames mvad requests to options * rename uvad request to options * rename model * rename model on operations * more mvad renames * update body naming * update body param naming to not use a reserved keyword * restructure cadl files * move generated cadl * update client.cadl * update swagger output * Update specification/cognitiveservices/AnomalyDetector/univariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/univariate/routes.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/routes.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * make data schema enum extensible * make errors on ModelInfo readonly * update swagger * update readme swagger refs * add apiview to custom-words.txt * update more refs in readme * move existing examples up with CADL files * configure swagger file name in emmiter * format examples * point to examples dir in cadl-project.yaml * add generated swagger and examples Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com> Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com>
kayousef-zz
pushed a commit
to kayousef-zz/azure-rest-api-specs
that referenced
this pull request
Dec 21, 2022
…zure#21525) * add univariate cadl definitions * add cadl project yaml and main cadl * add package.json * add initial multivariate cadl definitions * update cadl-project.yaml and package.json * update route names * add univariate azure core operation defs * update multivariate models for correctness * update routes to reflect service instead of using cadl azure operation signatures * update multivariate models for correctness with original swagger * a note about errors * decorate request and response bodies with body decorator * update package.json to point to next package versions * fix routes to match swagger names * add client.cadl * remove client.cadl * fix GetBatchDetectionResult def * add namespace for univariate models * Version AD (Azure#21497) * Update main.cadl * fix versioning * leave api version as required Co-authored-by: Catalina Peralta <catalinaperaltah@hotmail.com> * add extensible api version enum * update cadl-project.yaml with python config * update sdk version * clean up routes * clean up cadl-project.yaml * clean up models * update package.json to ref latest deps * add newline * add more models docs * fix error response models * rename get multivariate batch result * Cadl dpg add convenience api (Azure#21575) * add @convenienceAPI * move @convenienceAPI to client.cadl * add placeholder examples file * add generated openapi spec * delete older swaggers * update cadl-project.yaml * update package.json * Add cadl-csharp parameters for AnomalyDetector (Azure#21647) * Change cadl-project * Add .net parameters * Fix * update error header uvad * Make model-namespace false for .net (Azure#21686) * [AnomalyDetector] Archboard feedback (Azure#21680) * rename to train only * archboard naming feedback * rename response to result * archboard renames mvad requests to options * rename uvad request to options * rename model * rename model on operations * more mvad renames * update body naming * update body param naming to not use a reserved keyword * restructure cadl files * move generated cadl * update client.cadl * update swagger output * Update specification/cognitiveservices/AnomalyDetector/univariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/univariate/routes.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/routes.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * Update specification/cognitiveservices/AnomalyDetector/multivariate/models.cadl Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com> * make data schema enum extensible * make errors on ModelInfo readonly * update swagger * update readme swagger refs * add apiview to custom-words.txt * update more refs in readme * move existing examples up with CADL files * configure swagger file name in emmiter * format examples * point to examples dir in cadl-project.yaml * add generated swagger and examples Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com> Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links