Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s360 in reservation and scheduled action APIs #21677

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

pednekarpraj
Copy link
Contributor

@pednekarpraj pednekarpraj commented Nov 28, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @pednekarpraj Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022

    Swagger Validation Report

    ️❌BreakingChange: 21 Errors, 1 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    consumption.json 2021-10-01(58fd3c4) 2021-10-01(main)
    common-types.json 2022-10-01(58fd3c4) 2022-10-01(main)
    scheduledActions.json 2022-10-01(58fd3c4) 2022-10-01(main)
    Rule Message
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L75:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L75:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L124:9
    Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L78:9
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L127:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L127:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L181:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L181:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L218:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L218:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L255:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L255:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L312:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L312:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L352:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L352:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L392:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L392:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L425:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L425:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L461:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L461:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L503:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L503:13
    1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L548:13
    Old: Microsoft.CostManagement/stable/2022-10-01/scheduledActions.json#L548:13
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3637:7
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3635:7
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3712:9
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3710:9
    1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3618:9
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3618:9
    1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3633:5
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3633:5
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'subscriptionId' renamed or removed?
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3637:7
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3635:7
    1034 - AddedRequiredProperty The new version has new required property 'scope' that was not found in the old version.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3618:9
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3618:9
    1034 - AddedRequiredProperty The new version has new required property 'scope' that was not found in the old version.
    New: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3633:5
    Old: Microsoft.Consumption/stable/2021-10-01/consumption.json#L3633:5
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'details' in response that was not found in the old version.
    New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L108:7
    Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L87:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L124:9
    Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L78:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2021-10 package-2021-10(58fd3c4) package-2021-10(main)
    package-2022-10 package-2022-10(58fd3c4) package-2022-10(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L155
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L252
    ResourceNameRestriction The resource name parameter 'budgetName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L309
    DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L430
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L473
    ResourceNameRestriction The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L629
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1113
    TrackedResourcePatchOperation Tracked resource 'ReservationRecommendationDetailsModel' must have patch operation that at least supports the update of tags.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1128
    TrackedResourcesMustHavePut The tracked resource ReservationRecommendationDetailsModel does not have a corresponding put operation.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1128
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1182
    ResourceNameRestriction The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1358
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Consumption/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1447
    ResourceNameRestriction The resource name parameter 'billingPeriodName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1512
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1842
    MissingTypeObject The schema 'MeterDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1856
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1887
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1893
    MissingTypeObject The schema 'UsageDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1935
    MissingTypeObject The schema 'LegacyUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L1973
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2058
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2064
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2070
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2076
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2197
    MissingTypeObject The schema 'ModernUsageDetailProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2246
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2257
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2356
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2372
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2378
    ValidFormats 'decimal' is not a known format.
    Location: Microsoft.Consumption/stable/2021-10-01/consumption.json#L2484
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/consumption/armconsumption - 2.0.0
    +	Field `ETag` of struct `ChargeSummary` has been removed
    +	Field `ETag` of struct `LegacyChargeSummary` has been removed
    +	Field `ETag` of struct `ModernChargeSummary` has been removed
    +	Field `Etag` of struct `CreditSummary` has been removed
    +	Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
    +	Field `Tags` of struct `CreditSummary` has been removed
    +	Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`
    azure-sdk-for-go - sdk/resourcemanager/costmanagement/armcostmanagement - 2.0.0
    +	Field `ETag` of struct `ProxyResource` has been removed
    +	Field `ETag` of struct `Resource` has been removed
    +	Field `ID` of struct `Operation` has been removed
    +	Field `Location` of struct `Resource` has been removed
    +	Field `QueryResult` of struct `ForecastClientExternalCloudProviderUsageResponse` has been removed
    +	Field `QueryResult` of struct `ForecastClientUsageResponse` has been removed
    +	Field `SKU` of struct `Resource` has been removed
    +	Field `Tags` of struct `Resource` has been removed
    +	Operation `*GenerateDetailedCostReportOperationResultsClient.Get` has been changed to LRO, use `*GenerateDetailedCostReportOperationResultsClient.BeginGet` instead.
    +	Struct `ExportExecutionProperties` has been removed
    +	Struct `ExportExecution` has been removed
    +	Type alias `ForecastTimeframeType` has been removed
    +	Type of `ExportExecutionListResult.Value` has been changed from `[]*ExportExecution` to `[]*ExportRun`
    +	Type of `ForecastDataset.Aggregation` has been changed from `map[string]*QueryAggregation` to `map[string]*ForecastAggregation`
    +	Type of `ForecastDataset.Configuration` has been changed from `*QueryDatasetConfiguration` to `*ForecastDatasetConfiguration`
    +	Type of `ForecastDataset.Filter` has been changed from `*QueryFilter` to `*ForecastFilter`
    +	Type of `ForecastDefinition.TimePeriod` has been changed from `*QueryTimePeriod` to `*ForecastTimePeriod`
    +	Type of `ForecastDefinition.Timeframe` has been changed from `*ForecastTimeframeType` to `*ForecastTimeframe`
    +	Type of `OperationListResult.Value` has been changed from `[]*Operation` to `[]*OperationForCostManagement`
    azure-sdk-for-python-track2 - track2_azure-mgmt-consumption - 10.0.0
    +	Model ChargeSummary no longer has parameter e_tag
    +	Model CreditSummary no longer has parameter etag
    +	Model CreditSummary no longer has parameter tags
    +	Model LegacyChargeSummary no longer has parameter e_tag
    +	Model LegacyChargeSummary no longer has parameter marketplace_charges
    +	Model ModernChargeSummary no longer has parameter e_tag
    +	Parameter scope of model ModernReservationRecommendation is now required
    azure-sdk-for-python-track2 - track2_azure-mgmt-costmanagement - 4.0.0b1
    +	Model Alert no longer has parameter tags
    +	Model ProxyResource no longer has parameter e_tag
    +	Model ReportConfigFilter no longer has parameter tag_key
    +	Model ReportConfigFilter no longer has parameter tag_value
    +	Model Resource no longer has parameter tags
    +	Removed operation group SettingsOperations
    azure-sdk-for-js - @azure/arm-consumption - 10.0.0
    +	Interface BudgetFilter no longer has parameter not
    +	Interface LegacyChargeSummary no longer has parameter marketplaceCharges
    +	Operation ReservationRecommendationDetails.get has a new signature
    +	Parameter scope of interface ModernReservationRecommendation is now required
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 83cde4f. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn		specification/cost-management/resource-manager/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Consumption [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 83cde4f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/consumption/armconsumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ModernReservationRecommendation.Properties` has been changed from `*ModernReservationRecommendationProperties` to `ModernReservationRecommendationPropertiesClassification`
      info	[Changelog] - Field `ETag` of struct `ChargeSummary` has been removed
      info	[Changelog] - Field `Etag` of struct `CreditSummary` has been removed
      info	[Changelog] - Field `Tags` of struct `CreditSummary` has been removed
      info	[Changelog] - Field `ETag` of struct `LegacyChargeSummary` has been removed
      info	[Changelog] - Field `MarketplaceCharges` of struct `LegacyChargeSummaryProperties` has been removed
      info	[Changelog] - Field `ETag` of struct `ModernChargeSummary` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `EventTypeCreditExpired` added to type alias `EventType`
      info	[Changelog] - New function `*ModernReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
      info	[Changelog] - New function `*ModernSharedScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
      info	[Changelog] - New function `*ModernSingleScopeReservationRecommendationProperties.GetModernReservationRecommendationProperties() *ModernReservationRecommendationProperties`
      info	[Changelog] - New struct `ModernSharedScopeReservationRecommendationProperties`
      info	[Changelog] - New struct `ModernSingleScopeReservationRecommendationProperties`
      info	[Changelog] - New field `Etag` in struct `ChargeSummary`
      info	[Changelog] - New field `Tags` in struct `ChargeSummary`
      info	[Changelog] - New field `ETag` in struct `CreditSummary`
      info	[Changelog] - New field `Etag` in struct `LegacyChargeSummary`
      info	[Changelog] - New field `Tags` in struct `LegacyChargeSummary`
      info	[Changelog] - New field `AzureMarketplaceCharges` in struct `LegacyChargeSummaryProperties`
      info	[Changelog] - New field `Etag` in struct `ModernChargeSummary`
      info	[Changelog] - New field `Tags` in struct `ModernChargeSummary`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 14 additive change(s).
    • ️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New struct `BenefitUtilizationSummariesClientListBySavingsPlanIDResponse`
      info	[Changelog] - New struct `BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse`
      info	[Changelog] - New struct `BenefitUtilizationSummariesListResult`
      info	[Changelog] - New struct `BenefitUtilizationSummaryProperties`
      info	[Changelog] - New struct `BlobInfo`
      info	[Changelog] - New struct `CheckNameAvailabilityRequest`
      info	[Changelog] - New struct `CheckNameAvailabilityResponse`
      info	[Changelog] - New struct `CostDetailsOperationResults`
      info	[Changelog] - New struct `CostDetailsTimePeriod`
      info	[Changelog] - New struct `ErrorDetailsWithNestedDetails`
      info	[Changelog] - New struct `ErrorResponseWithNestedDetails`
      info	[Changelog] - New struct `ExportRun`
      info	[Changelog] - New struct `ExportRunProperties`
      info	[Changelog] - New struct `FileDestination`
      info	[Changelog] - New struct `ForecastAggregation`
      info	[Changelog] - New struct `ForecastColumn`
      info	[Changelog] - New struct `ForecastComparisonExpression`
      info	[Changelog] - New struct `ForecastDatasetConfiguration`
      info	[Changelog] - New struct `ForecastFilter`
      info	[Changelog] - New struct `ForecastProperties`
      info	[Changelog] - New struct `ForecastResult`
      info	[Changelog] - New struct `ForecastTimePeriod`
      info	[Changelog] - New struct `GenerateCostDetailsReportClient`
      info	[Changelog] - New struct `GenerateCostDetailsReportClientCreateOperationResponse`
      info	[Changelog] - New struct `GenerateCostDetailsReportClientGetOperationResultsResponse`
      info	[Changelog] - New struct `GenerateCostDetailsReportErrorResponse`
      info	[Changelog] - New struct `GenerateCostDetailsReportRequestDefinition`
      info	[Changelog] - New struct `IncludedQuantityUtilizationSummary`
      info	[Changelog] - New struct `IncludedQuantityUtilizationSummaryProperties`
      info	[Changelog] - New struct `NotificationProperties`
      info	[Changelog] - New struct `OperationForCostManagement`
      info	[Changelog] - New struct `PriceSheetClient`
      info	[Changelog] - New struct `PriceSheetClientDownloadByBillingProfileResponse`
      info	[Changelog] - New struct `PriceSheetClientDownloadResponse`
      info	[Changelog] - New struct `ProxyResourceForCostManagement`
      info	[Changelog] - New struct `RecommendationUsageDetails`
      info	[Changelog] - New struct `ReportManifest`
      info	[Changelog] - New struct `RequestContext`
      info	[Changelog] - New struct `ResourceForCostManagement`
      info	[Changelog] - New struct `SavingsPlanUtilizationSummary`
      info	[Changelog] - New struct `SavingsPlanUtilizationSummaryProperties`
      info	[Changelog] - New struct `ScheduleProperties`
      info	[Changelog] - New struct `ScheduledAction`
      info	[Changelog] - New struct `ScheduledActionListResult`
      info	[Changelog] - New struct `ScheduledActionProperties`
      info	[Changelog] - New struct `ScheduledActionProxyResource`
      info	[Changelog] - New struct `ScheduledActionsClient`
      info	[Changelog] - New struct `ScheduledActionsClientListByScopeResponse`
      info	[Changelog] - New struct `ScheduledActionsClientListResponse`
      info	[Changelog] - New struct `SharedScopeBenefitRecommendationProperties`
      info	[Changelog] - New struct `SingleScopeBenefitRecommendationProperties`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New field `ExpiryTime` in struct `DownloadURL`
      info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientExternalCloudProviderUsageResponse`
      info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientUsageResponse`
      info	[Changelog] - New field `ActionType` in struct `Operation`
      info	[Changelog] - New field `IsDataAction` in struct `Operation`
      info	[Changelog] - New field `Origin` in struct `Operation`
      info	[Changelog]
      info	[Changelog] Total 15 breaking change(s), 243 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 83cde4f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.3
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.3>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.1.3` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model ChargeSummary has a new parameter etag
      info	[Changelog]   - Model ChargeSummary has a new parameter tags
      info	[Changelog]   - Model CreditSummary has a new parameter e_tag_properties_e_tag
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter azure_marketplace_charges
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter tags
      info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
      info	[Changelog]   - Model ModernChargeSummary has a new parameter tags
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter resource_type
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ChargeSummary no longer has parameter e_tag
      info	[Changelog]   - Model CreditSummary no longer has parameter etag
      info	[Changelog]   - Model CreditSummary no longer has parameter tags
      info	[Changelog]   - Model LegacyChargeSummary no longer has parameter e_tag
      info	[Changelog]   - Model LegacyChargeSummary no longer has parameter marketplace_charges
      info	[Changelog]   - Model ModernChargeSummary no longer has parameter e_tag
      info	[Changelog]   - Parameter scope of model ModernReservationRecommendation is now required
    • ️✔️track2_azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group BenefitRecommendationsOperations
      info	[Changelog]   - Added operation group BenefitUtilizationSummariesOperations
      info	[Changelog]   - Added operation group GenerateCostDetailsReportOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationResultsOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationStatusOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperations
      info	[Changelog]   - Added operation group PriceSheetOperations
      info	[Changelog]   - Added operation group ScheduledActionsOperations
      info	[Changelog]   - Model Alert has a new parameter e_tag
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter company_name
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter department_name
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_end_date
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_number
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_start_date
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter invoicing_threshold
      info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model CommonExportProperties has a new parameter partition_data
      info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
      info	[Changelog]   - Model Dimension has a new parameter e_tag
      info	[Changelog]   - Model Dimension has a new parameter location
      info	[Changelog]   - Model Dimension has a new parameter sku
      info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
      info	[Changelog]   - Model Export has a new parameter partition_data
      info	[Changelog]   - Model Export has a new parameter run_history
      info	[Changelog]   - Model ExportDeliveryDestination has a new parameter sas_token
      info	[Changelog]   - Model ExportDeliveryDestination has a new parameter storage_account
      info	[Changelog]   - Model ExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model ExportProperties has a new parameter partition_data
      info	[Changelog]   - Model ExportProperties has a new parameter run_history
      info	[Changelog]   - Model Operation has a new parameter action_type
      info	[Changelog]   - Model Operation has a new parameter is_data_action
      info	[Changelog]   - Model Operation has a new parameter origin
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Operation ExportsOperations.get has a new optional parameter expand
      info	[Changelog]   - Operation ExportsOperations.list has a new optional parameter expand
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model Alert no longer has parameter tags
      info	[Changelog]   - Model ProxyResource no longer has parameter e_tag
      info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_key
      info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_value
      info	[Changelog]   - Model Resource no longer has parameter tags
      info	[Changelog]   - Removed operation group SettingsOperations
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 83cde4f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 83cde4f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation LotsOperations.listByCustomer
      info	[Changelog]   - Added Interface LotsListByCustomerNextOptionalParams
      info	[Changelog]   - Added Interface LotsListByCustomerOptionalParams
      info	[Changelog]   - Added Interface ModernReservationRecommendationProperties
      info	[Changelog]   - Added Interface ModernSharedScopeReservationRecommendationProperties
      info	[Changelog]   - Added Interface ModernSingleScopeReservationRecommendationProperties
      info	[Changelog]   - Added Type Alias LotsListByCustomerNextResponse
      info	[Changelog]   - Added Type Alias LotsListByCustomerResponse
      info	[Changelog]   - Added Type Alias ModernReservationRecommendationPropertiesUnion
      info	[Changelog]   - Interface CreditSummary has a new optional parameter eTagPropertiesETag
      info	[Changelog]   - Interface LegacyChargeSummary has a new optional parameter azureMarketplaceCharges
      info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitId
      info	[Changelog]   - Interface LegacyUsageDetail has a new optional parameter benefitName
      info	[Changelog]   - Interface ModernReservationRecommendation has a new optional parameter resourceType
      info	[Changelog]   - Enum KnownEventType has a new value CreditExpired
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Operation ReservationRecommendationDetails.get has a new signature
      info	[Changelog]   - Interface BudgetFilter no longer has parameter not
      info	[Changelog]   - Interface LegacyChargeSummary no longer has parameter marketplaceCharges
      info	[Changelog]   - Parameter scope of interface ModernReservationRecommendation is now required
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 83cde4f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️consumption [View full logs
    • ️✔️cost-management [View full logs
    ️❌ azure-powershell failed [Detail]
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 83cde4f. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      warn		specification/consumption/resource-manager/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.CostManagement [View full logs]  [Release SDK Changes]
      cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 28, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/consumption/armconsumption Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/costmanagement/armcostmanagement Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-consumption Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-costmanagement Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Consumption Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-consumption Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-consumption Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure NewApiVersionRequired resource-manager labels Nov 28, 2022
    @openapi-workflow-bot
    Copy link

    Hi @pednekarpraj, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @pednekarpraj, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 29, 2022
    @pednekarpraj
    Copy link
    Contributor Author

    @changlong-liu
    Can you approve and merge this PR? I received the breaking change approval.

    There are two LintDiff errors but we need to ignore them.
    Here is the explanation for each of them

    Rule GuidUsage :
    In this PR, I am updating the existing production documentation version 2021-10-01 to resolve s360 item. Property 'subscriptionId' with format uuid/Guid is an existing property.
    The property was simply rearranged after making the property #/definitions/ModernReservationRecommendationProperties/properties/scope a discriminator property.
    If scope=single, then the API code returns property subscriptionId in the response. If scope=shared, then subscriptionId is not applicable and is not part of the response. Swagger was not updated accurately to reflect existing API behavior. Hence s360 item got created due to a live traffic validation check.

    Rule XmsIdentifierValidation : The validation check is complaining and asking to add property 'id' for the API error response's details array.
    We are following ARM error response guidance. As per the documentation, 'ErrorDetail' object doesn't contain 'id'

    image

    @changlong-liu
    Copy link
    Member

    @changlong-liu Can you approve and merge this PR? I received the breaking change approval.

    There are two LintDiff errors but we need to ignore them. Here is the explanation for each of them

    Rule GuidUsage : In this PR, I am updating the existing production documentation version 2021-10-01 to resolve s360 item. Property 'subscriptionId' with format uuid/Guid is an existing property. The property was simply rearranged after making the property #/definitions/ModernReservationRecommendationProperties/properties/scope a discriminator property. If scope=single, then the API code returns property subscriptionId in the response. If scope=shared, then subscriptionId is not applicable and is not part of the response. Swagger was not updated accurately to reflect existing API behavior. Hence s360 item got created due to a live traffic validation check.

    Rule XmsIdentifierValidation : The validation check is complaining and asking to add property 'id' for the API error response's details array. We are following ARM error response guidance. As per the documentation, 'ErrorDetail' object doesn't contain 'id'

    image

    Hi @pednekarpraj , for the XmsIdentifierValidation, the fix is described at https://github.com/Azure/azure-openapi-validator/blob/main/docs/xms-identifier-validation.md#how-to-fix-the-violation. May need to define "x-ms-identifiers" as empty like here: https://github.com/malincrist/azure-rest-api-specs/blob/b7aae047337e628a2dfef3e840259098d0382b2c/specification/consumption/resource-manager/Microsoft.Consumption/stable/2021-10-01/consumption.json#L3338

    @changlong-liu
    Copy link
    Member

    Hi @qiaozha , @ArcturusZhang , would you help check whether the JS/Golang breaking changes block this PR?

    @jianyexi
    Copy link
    Contributor

    @pednekarpraj could u add a suppression for the 'GuidUsage' error, by following https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process

    @openapi-workflow-bot
    Copy link

    Hi @pednekarpraj, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    @pednekarpraj
    Copy link
    Contributor Author

    @pednekarpraj could u add a suppression for the 'GuidUsage' error, by following https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process

    @jianyexi, I added the suppression for the 'GuidUsage' error in the readme.md
    Also submitted swagger suppression request by filling the form.
    Could you please unblock the PR?

    @changlong-liu changlong-liu merged commit 83cde4f into Azure:main Dec 2, 2022
    This was referenced Dec 2, 2022
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    * Fix s360 in reservation and scheduled action APIs
    
    * Fix lint errors
    
    * Fix linter error in RI recommendation example
    
    * Fix lint errors
    
    * Review comment - changed suppression rule name
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    * Fix s360 in reservation and scheduled action APIs
    
    * Fix lint errors
    
    * Fix linter error in RI recommendation example
    
    * Fix lint errors
    
    * Review comment - changed suppression rule name
    @Alancere Alancere mentioned this pull request Aug 16, 2024
    8 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript FixS360 NewApiVersionRequired resource-manager SuppressionReviewRequired
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants