Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release microsoft.network 2022 09 01 #21909

Closed
wants to merge 10 commits into from

Conversation

htippanaboya
Copy link
Contributor

@htippanaboya htippanaboya commented Dec 15, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @htippanaboya Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 15, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 4 Errors, 74 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    applicationGateway.json 2022-09-01(4924b59) 2022-07-01(main)
    applicationGatewayWafDynamicManifests.json 2022-09-01(4924b59) 2022-07-01(main)
    applicationSecurityGroup.json 2022-09-01(4924b59) 2022-07-01(main)
    availableDelegations.json 2022-09-01(4924b59) 2022-07-01(main)
    availableServiceAliases.json 2022-09-01(4924b59) 2022-07-01(main)
    azureFirewall.json 2022-09-01(4924b59) 2022-07-01(main)
    azureFirewallFqdnTag.json 2022-09-01(4924b59) 2022-07-01(main)
    azureWebCategory.json 2022-09-01(4924b59) 2022-07-01(main)
    bastionHost.json 2022-09-01(4924b59) 2022-07-01(main)
    checkDnsAvailability.json 2022-09-01(4924b59) 2022-07-01(main)
    cloudServiceNetworkInterface.json 2022-09-01(4924b59) 2022-07-01(main)
    cloudServicePublicIpAddress.json 2022-09-01(4924b59) 2022-07-01(main)
    cloudServiceSwap.json 2022-09-01(4924b59) 2022-07-01(main)
    customIpPrefix.json 2022-09-01(4924b59) 2022-07-01(main)
    ddosCustomPolicy.json 2022-09-01(4924b59) 2022-07-01(main)
    ddosProtectionPlan.json 2022-09-01(4924b59) 2022-07-01(main)
    dscpConfiguration.json 2022-09-01(4924b59) 2022-07-01(main)
    endpointService.json 2022-09-01(4924b59) 2022-07-01(main)
    expressRouteCircuit.json 2022-09-01(4924b59) 2022-07-01(main)
    expressRouteCrossConnection.json 2022-09-01(4924b59) 2022-07-01(main)
    expressRoutePort.json 2022-09-01(4924b59) 2022-07-01(main)
    expressRouteProviderPort.json 2022-09-01(4924b59) 2022-07-01(main)
    firewallPolicy.json 2022-09-01(4924b59) 2022-07-01(main)
    ipAllocation.json 2022-09-01(4924b59) 2022-07-01(main)
    ipGroups.json 2022-09-01(4924b59) 2022-07-01(main)
    loadBalancer.json 2022-09-01(4924b59) 2022-07-01(main)
    natGateway.json 2022-09-01(4924b59) 2022-07-01(main)
    network.json 2022-09-01(4924b59) 2022-07-01(main)
    network.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkInterface.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManager.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManager.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerActiveConfiguration.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerActiveConfiguration.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerConnection.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerConnection.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerConnectivityConfiguration.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerConnectivityConfiguration.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerEffectiveConfiguration.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerEffectiveConfiguration.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerGroup.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerGroup.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerScopeConnection.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerScopeConnection.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkManagerSecurityAdminConfiguration.json 2022-09-01(4924b59) 2022-07-01(main)
    networkManagerSecurityAdminConfiguration.json 2022-09-01(4924b59) 2022-04-01-preview(main)
    networkProfile.json 2022-09-01(4924b59) 2022-07-01(main)
    networkSecurityGroup.json 2022-09-01(4924b59) 2022-07-01(main)
    networkVirtualAppliance.json 2022-09-01(4924b59) 2022-07-01(main)
    networkWatcher.json 2022-09-01(4924b59) 2022-07-01(main)
    operation.json 2022-09-01(4924b59) 2022-07-01(main)
    privateEndpoint.json 2022-09-01(4924b59) 2022-07-01(main)
    privateLinkService.json 2022-09-01(4924b59) 2022-07-01(main)
    publicIpAddress.json 2022-09-01(4924b59) 2022-07-01(main)
    publicIpPrefix.json 2022-09-01(4924b59) 2022-07-01(main)
    routeFilter.json 2022-09-01(4924b59) 2022-07-01(main)
    routeTable.json 2022-09-01(4924b59) 2022-07-01(main)
    securityPartnerProvider.json 2022-09-01(4924b59) 2022-07-01(main)
    serviceCommunity.json 2022-09-01(4924b59) 2022-07-01(main)
    serviceEndpointPolicy.json 2022-09-01(4924b59) 2022-07-01(main)
    serviceTags.json 2022-09-01(4924b59) 2022-07-01(main)
    usage.json 2022-09-01(4924b59) 2022-07-01(main)
    virtualNetwork.json 2022-09-01(4924b59) 2022-07-01(main)
    virtualNetworkGateway.json 2022-09-01(4924b59) 2022-07-01(main)
    virtualNetworkTap.json 2022-09-01(4924b59) 2022-07-01(main)
    virtualRouter.json 2022-09-01(4924b59) 2022-07-01(main)
    virtualWan.json 2022-09-01(4924b59) 2022-07-01(main)
    vmssNetworkInterface.json 2022-09-01(4924b59) 2022-07-01(main)
    vmssPublicIpAddress.json 2022-09-01(4924b59) 2022-07-01(main)
    webapplicationfirewall.json 2022-09-01(4924b59) 2022-07-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Standard_Basic' from the old version.
    New: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1285:9
    Old: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1285:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Standard_Basic' from the old version.
    New: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1302:9
    Old: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1303:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Standard_Basic' from the old version.
    New: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1285:9
    Old: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1285:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Standard_Basic' from the old version.
    New: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1302:9
    Old: Microsoft.Network/stable/2022-07-01/applicationGateway.json#L1303:9


    The following breaking changes are detected by comparison with the latest preview version:

    Only 13 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listEffectiveVirtualNetworks' removed or restructured?
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L418:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listActiveSecurityUserRules' removed or restructured?
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L143:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}/listEffectiveVirtualNetworks' removed or restructured?
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L240:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EffectiveVirtualNetworksParameter' removed or renamed?
    New: Microsoft.Network/stable/2022-09-01/networkManager.json#L422:3
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L476:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ActiveSecurityUserRule' removed or renamed?
    New: Microsoft.Network/stable/2022-09-01/networkManagerActiveConfiguration.json#L150:3
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ActiveDefaultSecurityUserRule' removed or renamed?
    New: Microsoft.Network/stable/2022-09-01/networkManagerActiveConfiguration.json#L150:3
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DefaultUserRulePropertiesFormat' removed or renamed?
    New: Microsoft.Network/stable/2022-09-01/networkManagerActiveConfiguration.json#L150:3
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'UserRulePropertiesFormat' removed or renamed?
    New: Microsoft.Network/stable/2022-09-01/networkManagerActiveConfiguration.json#L150:3
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'SecurityUser' from the old version.
    New: Microsoft.Network/stable/2022-09-01/networkManager.json#L504:11
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L558:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'SecurityUser' from the old version.
    New: Microsoft.Network/stable/2022-09-01/networkManager.json#L571:9
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L625:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'SecurityUser' from the old version.
    New: Microsoft.Network/stable/2022-09-01/networkManager.json#L608:11
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L661:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'SecurityUser' from the old version.
    New: Microsoft.Network/stable/2022-09-01/networkManager.json#L671:9
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L724:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'SecurityUser' from the old version.
    New: Microsoft.Network/stable/2022-09-01/networkManager.json#L682:5
    Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L735:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️🔄LintDiff inProgress [Detail]
    ️❌Avocado: 2 Errors, 6 Warnings failed [Detail]
    Rule Message
    INCONSISTENT_API_VERSION The API version of the swagger is inconsistent with its file path.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/vmssNetworkInterface.json
    INCONSISTENT_API_VERSION The API version of the swagger is inconsistent with its file path.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/vmssPublicIpAddress.json
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/virtualNetworkTap.json
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/networkSecurityGroup.json
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/networkWatcher.json
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/privateLinkService.json
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/virtualNetwork.json
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/network/resource-manager/readme.md
    json: Microsoft.Network/stable/2022-09-01/virtualNetworkGateway.json
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 566 Errors, 0 Warnings failed [Detail]

    Only 13 items are listed, please refer to log for more details.

    Rule Message
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1400:42
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L22:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1599:41
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L32:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1658:50
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L41:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1702:39
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L51:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1769:45
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L59:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1876:46
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L74:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L2089:39
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L85:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L2414:45
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L103:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L3204:27
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayList.json#L11:11
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1400:42
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayListAll.json#L21:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1599:41
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayListAll.json#L31:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1658:50
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayListAll.json#L40:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Network/stable/2022-09-01/applicationGateway.json#L1702:39
    ExampleUrl: stable/2022-09-01/examples/ApplicationGatewayListAll.json#L50:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️❌SpellCheck: 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    HowToFix Unknown word (Overprovisioning), please fix the error or add words to ./custom-words.txt
    path: Microsoft.Network/stable/2022-09-01/expressRouteProviderPort.json#L150:27
    HowToFix Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt
    path: Microsoft.Network/stable/2022-09-01/virtualNetwork.json#L664:25
    HowToFix Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt
    path: Microsoft.Network/stable/2022-09-01/virtualNetwork.json#L705:29
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 15, 2022

    Swagger Generation Artifacts

    ️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=345633&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 1 "
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-js - @azure/arm-network - 31.0.0
    +	Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken
    +	Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top
    +	Interface AdminRulesListNextOptionalParams no longer has parameter skipToken
    +	Interface AdminRulesListNextOptionalParams no longer has parameter top
    +	Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken
    +	Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top
    +	Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
    +	Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
    +	Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken
    +	Interface NetworkGroupsListNextOptionalParams no longer has parameter top
    +	Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand
    +	Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken
    +	Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top
    +	Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken
    +	Interface NetworkManagersListNextOptionalParams no longer has parameter top
    +	Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken
    +	Interface ScopeConnectionsListNextOptionalParams no longer has parameter top
    +	Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken
    +	Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top
    +	Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes
    +	Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName
    +	Interface StaticMembersListNextOptionalParams no longer has parameter skipToken
    +	Interface StaticMembersListNextOptionalParams no longer has parameter top
    +	Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
    +	Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
    +	Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken
    +	Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top

    ️❌ azure-sdk-for-net failed [Detail]
    • Code Generator Failed [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.Network [View full logs]  [Preview SDK Changes]
      cmderr	[msbuild] The command could not be loaded, possibly because:
      cmderr	[msbuild]   * You intended to execute a .NET application:
      cmderr	[msbuild]       The application 'msbuild' does not exist.
      cmderr	[msbuild]   * You intended to execute a .NET SDK command:
      cmderr	[msbuild]       A compatible .NET SDK was not found.
      cmderr	[msbuild] Requested SDK version: 7.0.101
      cmderr	[msbuild] global.json file: /mnt/vss/_work/1/s/azure-sdk-for-net/global.json
      cmderr	[msbuild] Installed SDKs:
      cmderr	[msbuild] Install the [7.0.101] .NET SDK or update [/mnt/vss/_work/1/s/azure-sdk-for-net/global.json] to match an installed SDK.
      cmderr	[msbuild] Learn about SDK resolution:
      cmderr	[msbuild] https://aka.ms/dotnet/sdk-not-found
      error	Script return with result [failed] code [145] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Network [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-network [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model NspAccessRule has a new parameter email_addresses
      info	[Changelog]   - Model NspAccessRule has a new parameter phone_numbers
      info	[Changelog]   - Model NspLink has a new parameter remote_perimeter_location
      info	[Changelog]   - Model NspLinkReference has a new parameter remote_perimeter_location
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-network-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ApplicationGatewayCustomErrorStatusCodeHTTPStatus400`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus404`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus405`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus408`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus499`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus500`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus503`, `ApplicationGatewayCustomErrorStatusCodeHTTPStatus504` added to type alias `ApplicationGatewayCustomErrorStatusCode`
      info	[Changelog] - New type alias `WebApplicationFirewallState` with values `WebApplicationFirewallStateDisabled`, `WebApplicationFirewallStateEnabled`
      info	[Changelog] - New field `AuthorizationStatus` in struct `ExpressRouteCircuitPropertiesFormat`
      info	[Changelog] - New field `IPConfigurationID` in struct `VPNGatewaysClientBeginResetOptions`
      info	[Changelog] - New field `FlowLogs` in struct `VirtualNetworkPropertiesFormat`
      info	[Changelog] - New field `State` in struct `WebApplicationFirewallCustomRule`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 15 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias WebApplicationFirewallState
      info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter authorizationStatus
      info	[Changelog]   - Interface VirtualNetwork has a new optional parameter flowLogs
      info	[Changelog]   - Interface VpnGatewaysResetOptionalParams has a new optional parameter ipConfigurationId
      info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter state
      info	[Changelog]   - Added Enum KnownWebApplicationFirewallState
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus400
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus404
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus405
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus408
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus499
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus500
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus503
      info	[Changelog]   - Enum KnownApplicationGatewayCustomErrorStatusCode has a new value HttpStatus504
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface AdminRulesListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface AdminRulesListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface NetworkGroupsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface NetworkManagersListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface ScopeConnectionsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes
      info	[Changelog]   - Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName
      info	[Changelog]   - Interface StaticMembersListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface StaticMembersListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from cf606edb552fe90b04ddeaf29798617406fc310e. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.network [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 15, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/20e75979170145dc8dd0e8fe658f8e6f
    Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/b4d8d69833d147e2834574d2bf36003f
    .Net Azure.ResourceManager.Network There is no API change compared with the previous version
    JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/e94696133ebe47f38c93e95fabd09a49

    @openapi-workflow-bot
    Copy link

    Hi @htippanaboya, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @htippanaboya, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @raych1
    Copy link
    Member

    raych1 commented Dec 19, 2022

    @htippanaboya ,
    1).can someone fix the modelvalidation errors and spellcheck errors?

    Release microsoft.network 2022 09 01 by htippanaboya · Pull Request #21909 · Azure/azure-rest-api-specs (github.com)

    2).apiReadiness check error:

    the resource type 'operations' could not be found in the namespace 'Microsoft.Network' for api version '2022-09-01.

    Have 2022-09-01 arm manifest deployed?

    @raych1
    Copy link
    Member

    raych1 commented Dec 19, 2022

    Approved model validation as all the errors reported are carried over from last api version
    #21400

    Synced with @htippanaboya offline and he will follow up with partner team to fix swagger examples separately.

    @ghost
    Copy link

    ghost commented Jan 8, 2023

    Hi, @htippanaboya. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jan 11, 2023
    @openapi-workflow-bot
    Copy link

    Hi @htippanaboya, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @raych1
    Copy link
    Member

    raych1 commented Jan 13, 2023

    @htippanaboya , can you check on the detected cross version breaking changes?

    utbarn-ms and others added 4 commits February 1, 2023 11:20
    * make auth status read only
    
    * fixing model validation
    
    * prettier fix
    * Add new status code for application gateway custom error page
    
    * Fix prettier
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-Avocado Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript CI-FixRequiredOnFailure CI-MissingBaseCommit Network new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    10 participants