Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S360 swagger error, certificateId not required #22339

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

najian
Copy link
Member

@najian najian commented Jan 29, 2023

Fix S360 swagger error, certificateId not required per service behavior

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • [* ] update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

Fix S360 swagger error, certificateId not required per service behavior
@openapi-workflow-bot
Copy link

Hi, @najian Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 29, 2023

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    ContainerApps.json 2022-01-01-preview(1fbc450) 2022-01-01-preview(main)
    ContainerApps.json 2022-06-01-preview(1fbc450) 2022-06-01-preview(main)
    ContainerApps.json 2022-03-01(1fbc450) 2022-03-01(main)
    ContainerApps.json 2022-10-01(1fbc450) 2022-10-01(main)
    Rule Message
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L742:7
    Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L743:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L865:7
    Old: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L866:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.App/stable/2022-03-01/ContainerApps.json#L746:7
    Old: Microsoft.App/stable/2022-03-01/ContainerApps.json#L747:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.App/stable/2022-10-01/ContainerApps.json#L887:7
    Old: Microsoft.App/stable/2022-10-01/ContainerApps.json#L888:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-03 package-2022-03(1fbc450) package-2022-03(main)
    package-2022-01-01-preview package-2022-01-01-preview(1fbc450) package-2022-01-01-preview(main)
    package-2022-10 package-2022-10(1fbc450) package-2022-10(main)
    package-preview-2022-06 package-preview-2022-06(1fbc450) package-preview-2022-06(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L148
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L209
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L238
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L279
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L313
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L99
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L148
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L212
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L241
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L282
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L282
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L282
    PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L287
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L302
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L320
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L372
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L418
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L99
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L148
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L209
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L238
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L279
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L279
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L279
    PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L284
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L299
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L317
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L372
    ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/stable/2022-10-01/ContainerApps.json#L99
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/stable/2022-10-01/ContainerApps.json#L148
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 29, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 2.0.0
    +	Field `ID` of struct `CustomHostnameAnalysisResult` has been removed
    +	Field `Name` of struct `CustomHostnameAnalysisResult` has been removed
    +	Field `Properties` of struct `CustomHostnameAnalysisResult` has been removed
    +	Field `SystemData` of struct `CustomHostnameAnalysisResult` has been removed
    +	Field `Type` of struct `CustomHostnameAnalysisResult` has been removed
    +	Struct `CustomHostnameAnalysisResultProperties` has been removed
    +	Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`
    azure-sdk-for-python-track2 - track2_azure-mgmt-appcontainers - 2.0.0b2
    +	Model CustomHostnameAnalysisResult no longer has parameter id
    +	Model CustomHostnameAnalysisResult no longer has parameter name
    +	Model CustomHostnameAnalysisResult no longer has parameter system_data
    +	Model CustomHostnameAnalysisResult no longer has parameter type
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 638734a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appcontainers [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation ContainerAppsOperations.get_auth_token
      info	[Changelog]   - Added operation ManagedEnvironmentsOperations.get_auth_token
      info	[Changelog]   - Added operation ManagedEnvironmentsOperations.list_workload_profile_states
      info	[Changelog]   - Added operation group AvailableWorkloadProfilesOperations
      info	[Changelog]   - Added operation group BillingMetersOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsCertificatesOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsDaprComponentsOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsOperations
      info	[Changelog]   - Added operation group ConnectedEnvironmentsStoragesOperations
      info	[Changelog]   - Added operation group ContainerAppsDiagnosticsOperations
      info	[Changelog]   - Added operation group ManagedEnvironmentDiagnosticsOperations
      info	[Changelog]   - Added operation group ManagedEnvironmentsDiagnosticsOperations
      info	[Changelog]   - Model CertificateProperties has a new parameter subject_alternative_names
      info	[Changelog]   - Model Configuration has a new parameter max_inactive_revisions
      info	[Changelog]   - Model ContainerApp has a new parameter environment_id
      info	[Changelog]   - Model ContainerApp has a new parameter event_stream_endpoint
      info	[Changelog]   - Model ContainerApp has a new parameter extended_location
      info	[Changelog]   - Model ContainerApp has a new parameter latest_ready_revision_name
      info	[Changelog]   - Model ContainerApp has a new parameter workload_profile_type
      info	[Changelog]   - Model CustomHostnameAnalysisResult has a new parameter conflict_with_environment_custom_domain
      info	[Changelog]   - Model Dapr has a new parameter enable_api_logging
      info	[Changelog]   - Model Dapr has a new parameter http_max_request_size
      info	[Changelog]   - Model Dapr has a new parameter http_read_buffer_size
      info	[Changelog]   - Model Dapr has a new parameter log_level
      info	[Changelog]   - Model DaprComponent has a new parameter secret_store_component
      info	[Changelog]   - Model Ingress has a new parameter client_certificate_mode
      info	[Changelog]   - Model Ingress has a new parameter cors_policy
      info	[Changelog]   - Model Ingress has a new parameter exposed_port
      info	[Changelog]   - Model Ingress has a new parameter ip_security_restrictions
      info	[Changelog]   - Model ManagedEnvironment has a new parameter custom_domain_configuration
      info	[Changelog]   - Model ManagedEnvironment has a new parameter event_stream_endpoint
      info	[Changelog]   - Model ManagedEnvironment has a new parameter kind
      info	[Changelog]   - Model ManagedEnvironment has a new parameter sku
      info	[Changelog]   - Model ManagedEnvironment has a new parameter workload_profiles
      info	[Changelog]   - Model ReplicaContainer has a new parameter exec_endpoint
      info	[Changelog]   - Model ReplicaContainer has a new parameter log_stream_endpoint
      info	[Changelog]   - Model Revision has a new parameter last_active_time
      info	[Changelog]   - Model ScaleRule has a new parameter tcp
      info	[Changelog]   - Model Template has a new parameter init_containers
      info	[Changelog]   - Model VnetConfiguration has a new parameter outbound_settings
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter id
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter name
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter system_data
      info	[Changelog]   - Model CustomHostnameAnalysisResult no longer has parameter type
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 638734a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-appcontainers [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 638734a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New function `*ContainerAppsDiagnosticsClient.GetRevision(context.Context, string, string, string, *ContainerAppsDiagnosticsClientGetRevisionOptions) (ContainerAppsDiagnosticsClientGetRevisionResponse, error)`
      info	[Changelog] - New function `*ContainerAppsDiagnosticsClient.GetRoot(context.Context, string, string, *ContainerAppsDiagnosticsClientGetRootOptions) (ContainerAppsDiagnosticsClientGetRootResponse, error)`
      info	[Changelog] - New function `*ContainerAppsDiagnosticsClient.NewListDetectorsPager(string, string, *ContainerAppsDiagnosticsClientListDetectorsOptions) *runtime.Pager[ContainerAppsDiagnosticsClientListDetectorsResponse]`
      info	[Changelog] - New function `*ContainerAppsDiagnosticsClient.NewListRevisionsPager(string, string, *ContainerAppsDiagnosticsClientListRevisionsOptions) *runtime.Pager[ContainerAppsDiagnosticsClientListRevisionsResponse]`
      info	[Changelog] - New function `NewManagedEnvironmentDiagnosticsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedEnvironmentDiagnosticsClient, error)`
      info	[Changelog] - New function `*ManagedEnvironmentDiagnosticsClient.GetDetector(context.Context, string, string, string, *ManagedEnvironmentDiagnosticsClientGetDetectorOptions) (ManagedEnvironmentDiagnosticsClientGetDetectorResponse, error)`
      info	[Changelog] - New function `*ManagedEnvironmentDiagnosticsClient.ListDetectors(context.Context, string, string, *ManagedEnvironmentDiagnosticsClientListDetectorsOptions) (ManagedEnvironmentDiagnosticsClientListDetectorsResponse, error)`
      info	[Changelog] - New function `*ManagedEnvironmentsClient.GetAuthToken(context.Context, string, string, *ManagedEnvironmentsClientGetAuthTokenOptions) (ManagedEnvironmentsClientGetAuthTokenResponse, error)`
      info	[Changelog] - New function `*ManagedEnvironmentsClient.NewListWorkloadProfileStatesPager(string, string, *ManagedEnvironmentsClientListWorkloadProfileStatesOptions) *runtime.Pager[ManagedEnvironmentsClientListWorkloadProfileStatesResponse]`
      info	[Changelog] - New function `NewManagedEnvironmentsDiagnosticsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedEnvironmentsDiagnosticsClient, error)`
      info	[Changelog] - New function `*ManagedEnvironmentsDiagnosticsClient.GetRoot(context.Context, string, string, *ManagedEnvironmentsDiagnosticsClientGetRootOptions) (ManagedEnvironmentsDiagnosticsClientGetRootResponse, error)`
      info	[Changelog] - New struct `AvailableWorkloadProfile`
      info	[Changelog] - New struct `AvailableWorkloadProfileProperties`
      info	[Changelog] - New struct `AvailableWorkloadProfilesClient`
      info	[Changelog] - New struct `AvailableWorkloadProfilesClientGetResponse`
      info	[Changelog] - New struct `AvailableWorkloadProfilesCollection`
      info	[Changelog] - New struct `BaseContainer`
      info	[Changelog] - New struct `BillingMeter`
      info	[Changelog] - New struct `BillingMeterCollection`
      info	[Changelog] - New struct `BillingMeterProperties`
      info	[Changelog] - New struct `BillingMetersClient`
      info	[Changelog] - New struct `ConnectedEnvironment`
      info	[Changelog] - New struct `ConnectedEnvironmentCollection`
      info	[Changelog] - New struct `ConnectedEnvironmentProperties`
      info	[Changelog] - New struct `ConnectedEnvironmentStorage`
      info	[Changelog] - New struct `ConnectedEnvironmentStorageProperties`
      info	[Changelog] - New struct `ConnectedEnvironmentStoragesCollection`
      info	[Changelog] - New struct `ConnectedEnvironmentsCertificatesClient`
      info	[Changelog] - New struct `ConnectedEnvironmentsCertificatesClientListResponse`
      info	[Changelog] - New struct `ConnectedEnvironmentsClient`
      info	[Changelog] - New struct `ConnectedEnvironmentsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ConnectedEnvironmentsClientDeleteResponse`
      info	[Changelog] - New struct `ConnectedEnvironmentsClientListByResourceGroupResponse`
      info	[Changelog] - New struct `ConnectedEnvironmentsClientListBySubscriptionResponse`
      info	[Changelog] - New struct `ConnectedEnvironmentsDaprComponentsClient`
      info	[Changelog] - New struct `ConnectedEnvironmentsDaprComponentsClientListResponse`
      info	[Changelog] - New struct `ConnectedEnvironmentsStoragesClient`
      info	[Changelog] - New struct `ContainerAppAuthToken`
      info	[Changelog] - New struct `ContainerAppAuthTokenProperties`
      info	[Changelog] - New struct `ContainerAppsDiagnosticsClient`
      info	[Changelog] - New struct `ContainerAppsDiagnosticsClientListDetectorsResponse`
      info	[Changelog] - New struct `ContainerAppsDiagnosticsClientListRevisionsResponse`
      info	[Changelog] - New struct `CorsPolicy`
      info	[Changelog] - New struct `CustomDomainConfiguration`
      info	[Changelog] - New struct `CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo`
      info	[Changelog] - New struct `CustomHostnameAnalysisResultCustomDomainVerificationFailureInfoDetailsItem`
      info	[Changelog] - New struct `DaprSecret`
      info	[Changelog] - New struct `DiagnosticDataProviderMetadata`
      info	[Changelog] - New struct `DiagnosticDataProviderMetadataPropertyBagItem`
      info	[Changelog] - New struct `DiagnosticDataTableResponseColumn`
      info	[Changelog] - New struct `DiagnosticDataTableResponseObject`
      info	[Changelog] - New struct `DiagnosticRendering`
      info	[Changelog] - New struct `DiagnosticSupportTopic`
      info	[Changelog] - New struct `Diagnostics`
      info	[Changelog] - New struct `DiagnosticsCollection`
      info	[Changelog] - New struct `DiagnosticsDataAPIResponse`
      info	[Changelog] - New struct `DiagnosticsDefinition`
      info	[Changelog] - New struct `DiagnosticsProperties`
      info	[Changelog] - New struct `DiagnosticsStatus`
      info	[Changelog] - New struct `EnvironmentAuthToken`
      info	[Changelog] - New struct `EnvironmentAuthTokenProperties`
      info	[Changelog] - New struct `EnvironmentSKUProperties`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog] - New struct `ExtendedLocation`
      info	[Changelog] - New struct `IPSecurityRestrictionRule`
      info	[Changelog] - New struct `InitContainer`
      info	[Changelog] - New struct `ManagedEnvironmentDiagnosticsClient`
      info	[Changelog] - New struct `ManagedEnvironmentOutboundSettings`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListWorkloadProfileStatesResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsDiagnosticsClient`
      info	[Changelog] - New struct `TCPScaleRule`
      info	[Changelog] - New struct `WorkloadProfile`
      info	[Changelog] - New struct `WorkloadProfileStates`
      info	[Changelog] - New struct `WorkloadProfileStatesCollection`
      info	[Changelog] - New struct `WorkloadProfileStatesProperties`
      info	[Changelog] - New field `SubjectAlternativeNames` in struct `CertificateProperties`
      info	[Changelog] - New field `MaxInactiveRevisions` in struct `Configuration`
      info	[Changelog] - New field `ExtendedLocation` in struct `ContainerApp`
      info	[Changelog] - New field `EnvironmentID` in struct `ContainerAppProperties`
      info	[Changelog] - New field `EventStreamEndpoint` in struct `ContainerAppProperties`
      info	[Changelog] - New field `LatestReadyRevisionName` in struct `ContainerAppProperties`
      info	[Changelog] - New field `WorkloadProfileType` in struct `ContainerAppProperties`
      info	[Changelog] - New anonymous field `ContainerApp` in struct `ContainerAppsClientUpdateResponse`
      info	[Changelog] - New field `ARecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `AlternateCNameRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `AlternateTxtRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `CNameRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `ConflictWithEnvironmentCustomDomain` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `ConflictingContainerAppResourceID` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `CustomDomainVerificationFailureInfo` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `CustomDomainVerificationTest` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `HasConflictOnManagedEnvironment` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `HostName` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `IsHostnameAlreadyVerified` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `TxtRecords` in struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New field `EnableAPILogging` in struct `Dapr`
      info	[Changelog] - New field `HTTPMaxRequestSize` in struct `Dapr`
      info	[Changelog] - New field `HTTPReadBufferSize` in struct `Dapr`
      info	[Changelog] - New field `LogLevel` in struct `Dapr`
      info	[Changelog] - New field `SecretStoreComponent` in struct `DaprComponentProperties`
      info	[Changelog] - New field `ClientCertificateMode` in struct `Ingress`
      info	[Changelog] - New field `CorsPolicy` in struct `Ingress`
      info	[Changelog] - New field `ExposedPort` in struct `Ingress`
      info	[Changelog] - New field `IPSecurityRestrictions` in struct `Ingress`
      info	[Changelog] - New field `Kind` in struct `ManagedEnvironment`
      info	[Changelog] - New field `SKU` in struct `ManagedEnvironment`
      info	[Changelog] - New field `CustomDomainConfiguration` in struct `ManagedEnvironmentProperties`
      info	[Changelog] - New field `EventStreamEndpoint` in struct `ManagedEnvironmentProperties`
      info	[Changelog] - New field `WorkloadProfiles` in struct `ManagedEnvironmentProperties`
      info	[Changelog] - New anonymous field `ManagedEnvironment` in struct `ManagedEnvironmentsClientUpdateResponse`
      info	[Changelog] - New field `ExecEndpoint` in struct `ReplicaContainer`
      info	[Changelog] - New field `LogStreamEndpoint` in struct `ReplicaContainer`
      info	[Changelog] - New field `LastActiveTime` in struct `RevisionProperties`
      info	[Changelog] - New field `TCP` in struct `ScaleRule`
      info	[Changelog] - New field `InitContainers` in struct `Template`
      info	[Changelog] - New field `OutboundSettings` in struct `VnetConfiguration`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 230 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 638734a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appcontainers [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface DiagnosticsDataApiResponse
      info	[Changelog]   - Added Interface DiagnosticsDefinition
      info	[Changelog]   - Added Interface DiagnosticsProperties
      info	[Changelog]   - Added Interface DiagnosticsStatus
      info	[Changelog]   - Added Interface DiagnosticSupportTopic
      info	[Changelog]   - Added Interface EnvironmentAuthToken
      info	[Changelog]   - Added Interface EnvironmentSkuProperties
      info	[Changelog]   - Added Interface ErrorAdditionalInfo
      info	[Changelog]   - Added Interface ErrorDetail
      info	[Changelog]   - Added Interface ErrorResponse
      info	[Changelog]   - Added Interface ExtendedLocation
      info	[Changelog]   - Added Interface InitContainer
      info	[Changelog]   - Added Interface IpSecurityRestrictionRule
      info	[Changelog]   - Added Interface ManagedEnvironmentDiagnosticsGetDetectorOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentDiagnosticsListDetectorsOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentOutboundSettings
      info	[Changelog]   - Added Interface ManagedEnvironmentsDiagnosticsGetRootOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentsGetAuthTokenOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentsListWorkloadProfileStatesNextOptionalParams
      info	[Changelog]   - Added Interface ManagedEnvironmentsListWorkloadProfileStatesOptionalParams
      info	[Changelog]   - Added Interface TcpScaleRule
      info	[Changelog]   - Added Interface WorkloadProfile
      info	[Changelog]   - Added Interface WorkloadProfileStates
      info	[Changelog]   - Added Interface WorkloadProfileStatesCollection
      info	[Changelog]   - Added Interface WorkloadProfileStatesProperties
      info	[Changelog]   - Added Type Alias Action
      info	[Changelog]   - Added Type Alias Applicability
      info	[Changelog]   - Added Type Alias AvailableWorkloadProfilesGetNextResponse
      info	[Changelog]   - Added Type Alias AvailableWorkloadProfilesGetResponse
      info	[Changelog]   - Added Type Alias BillingMetersGetResponse
      info	[Changelog]   - Added Type Alias Category
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentProvisioningState
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCheckNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListSecretsResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesListResponse
      info	[Changelog]   - Added Type Alias ConnectedEnvironmentsUpdateResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
      info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
      info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
      info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
      info	[Changelog]   - Added Type Alias ExtendedLocationTypes
      info	[Changelog]   - Added Type Alias IngressClientCertificateMode
      info	[Changelog]   - Added Type Alias LogLevel
      info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentOutBoundType
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
      info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
      info	[Changelog]   - Added Type Alias SkuName
      info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
      info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
      info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
      info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
      info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
      info	[Changelog]   - Interface ContainerApp has a new optional parameter latestReadyRevisionName
      info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileType
      info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
      info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
      info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
      info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
      info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
      info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
      info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
      info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
      info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
      info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter sku
      info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
      info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
      info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
      info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
      info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
      info	[Changelog]   - Interface Template has a new optional parameter initContainers
      info	[Changelog]   - Interface VnetConfiguration has a new optional parameter outboundSettings
      info	[Changelog]   - Added Enum KnownAction
      info	[Changelog]   - Added Enum KnownApplicability
      info	[Changelog]   - Added Enum KnownCategory
      info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
      info	[Changelog]   - Added Enum KnownExtendedLocationTypes
      info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
      info	[Changelog]   - Added Enum KnownLogLevel
      info	[Changelog]   - Added Enum KnownManagedEnvironmentOutBoundType
      info	[Changelog]   - Added Enum KnownSkuName
      info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
      info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
      info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 638734a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 638734a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.ContainerAppsApi [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 29, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/appcontainers/armappcontainers https://apiview.dev/Assemblies/Review/0a68ec2ec1de4849962f5aa8d39e6f1a
    Java azure-resourcemanager-appcontainers Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/b7f0b0fe583f409985fd44828750ce48

    @najian najian requested a review from Juliehzl January 29, 2023 02:43
    @najian
    Copy link
    Member Author

    najian commented Jan 29, 2023

    @openapi-workflow-bot
    Copy link

    Hi @najian, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-JavaScript FixS360 resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants