update typescript.md in dataprotection #22350

kazrael2119 · 2023-01-30T09:07:24Z

according to this https://github.com/Azure/sdk-release-request/issues/3629#issuecomment-1407346361

openapi-workflow-bot · 2023-01-30T09:07:28Z

Hi, @kazrael2119 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-01-30T09:07:30Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.0.0)	new version	base version
default	default(13c5f0c)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]

️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-30T09:07:30Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/dataprotection/armdataprotection - 2.0.0

-	Type of `ErrorAdditionalInfo.Info` has been changed from `interface{}` to `any`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-dataprotection - 1.0.0b4

+	Model ResourceGuardResource no longer has parameter identity
+	Removed operation group BackupInstancesExtensionRoutingOperations
+	Removed operation group DppResourceGuardProxyOperations
+	Renamed operation BackupVaultsOperations.delete to BackupVaultsOperations.begin_delete

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8c9a6bd. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.DataProtectionBackup [View full logs] [Release SDK Changes]
- Azure.ResourceManager.DataProtectionBackup.1.2.0-alpha.20230203.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 8c9a6bd. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.4.1` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-dataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model AzureBackupDiscreteRecoveryPoint has a new parameter expiry_time
info	[Changelog]   - Model BackupVault has a new parameter feature_settings
info	[Changelog]   - Model PatchBackupVaultInput has a new parameter feature_settings
info	[Changelog]   - Model TargetDetails has a new parameter target_resource_arm_id
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ResourceGuardResource no longer has parameter identity
info	[Changelog]   - Removed operation group BackupInstancesExtensionRoutingOperations
info	[Changelog]   - Removed operation group DppResourceGuardProxyOperations
info	[Changelog]   - Renamed operation BackupVaultsOperations.delete to BackupVaultsOperations.begin_delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 8c9a6bd. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-dataprotection [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8c9a6bd. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/dataprotection/armdataprotection [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*ResourceGuardsClient.Patch` parameter(s) have been changed from `(context.Context, string, string, PatchResourceRequestInput, *ResourceGuardsClientPatchOptions)` to `(context.Context, string, string, PatchResourceGuardInput, *ResourceGuardsClientPatchOptions)`
info	[Changelog] - Const `StorageSettingStoreTypesSnapshotStore` from type alias `StorageSettingStoreTypes` has been removed
info	[Changelog] - Operation `*BackupVaultsClient.Delete` has been changed to LRO, use `*BackupVaultsClient.BeginDelete` instead.
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog] - Field `Identity` of struct `ResourceGuardResource` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `SourceDataStoreTypeOperationalStore` added to type alias `SourceDataStoreType`
info	[Changelog] - New value `StorageSettingStoreTypesOperationalStore` added to type alias `StorageSettingStoreTypes`
info	[Changelog] - New value `StorageSettingTypesZoneRedundant` added to type alias `StorageSettingTypes`
info	[Changelog] - New type alias `CrossSubscriptionRestoreState` with values `CrossSubscriptionRestoreStateDisabled`, `CrossSubscriptionRestoreStateEnabled`, `CrossSubscriptionRestoreStatePermanentlyDisabled`
info	[Changelog] - New type alias `ExistingResourcePolicy` with values `ExistingResourcePolicyPatch`, `ExistingResourcePolicySkip`
info	[Changelog] - New type alias `ImmutabilityState` with values `ImmutabilityStateDisabled`, `ImmutabilityStateLocked`, `ImmutabilityStateUnlocked`
info	[Changelog] - New type alias `PersistentVolumeRestoreMode` with values `PersistentVolumeRestoreModeRestoreWithVolumeData`, `PersistentVolumeRestoreModeRestoreWithoutVolumeData`
info	[Changelog] - New type alias `SoftDeleteState` with values `SoftDeleteStateAlwaysOn`, `SoftDeleteStateOff`, `SoftDeleteStateOn`
info	[Changelog] - New function `*BackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
info	[Changelog] - New function `*BlobBackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
info	[Changelog] - New function `NewDeletedBackupInstancesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DeletedBackupInstancesClient, error)`
info	[Changelog] - New function `*DeletedBackupInstancesClient.Get(context.Context, string, string, string, *DeletedBackupInstancesClientGetOptions) (DeletedBackupInstancesClientGetResponse, error)`
info	[Changelog] - New function `*DeletedBackupInstancesClient.NewListPager(string, string, *DeletedBackupInstancesClientListOptions) *runtime.Pager[DeletedBackupInstancesClientListResponse]`
info	[Changelog] - New function `*DeletedBackupInstancesClient.BeginUndelete(context.Context, string, string, string, *DeletedBackupInstancesClientBeginUndeleteOptions) (*runtime.Poller[DeletedBackupInstancesClientUndeleteResponse], error)`
info	[Changelog] - New function `*ItemPathBasedRestoreCriteria.GetItemLevelRestoreCriteria() *ItemLevelRestoreCriteria`
info	[Changelog] - New function `*KubernetesClusterBackupDatasourceParameters.GetBackupDatasourceParameters() *BackupDatasourceParameters`
info	[Changelog] - New function `*KubernetesClusterRestoreCriteria.GetItemLevelRestoreCriteria() *ItemLevelRestoreCriteria`
info	[Changelog] - New struct `BlobBackupDatasourceParameters`
info	[Changelog] - New struct `CrossSubscriptionRestoreSettings`
info	[Changelog] - New struct `DeletedBackupInstance`
info	[Changelog] - New struct `DeletedBackupInstanceResource`
info	[Changelog] - New struct `DeletedBackupInstanceResourceList`
info	[Changelog] - New struct `DeletedBackupInstancesClient`
info	[Changelog] - New struct `DeletedBackupInstancesClientListResponse`
info	[Changelog] - New struct `DeletedBackupInstancesClientUndeleteResponse`
info	[Changelog] - New struct `DeletionInfo`
info	[Changelog] - New struct `DppBaseTrackedResource`
info	[Changelog] - New struct `DppProxyResource`
info	[Changelog] - New struct `FeatureSettings`
info	[Changelog] - New struct `ImmutabilitySettings`
info	[Changelog] - New struct `ItemPathBasedRestoreCriteria`
info	[Changelog] - New struct `KubernetesClusterBackupDatasourceParameters`
info	[Changelog] - New struct `KubernetesClusterRestoreCriteria`
info	[Changelog] - New struct `PatchResourceGuardInput`
info	[Changelog] - New struct `SecuritySettings`
info	[Changelog] - New struct `SoftDeleteSettings`
info	[Changelog] - New field `ExpiryTime` in struct `AzureBackupDiscreteRecoveryPoint`
info	[Changelog] - New field `Tags` in struct `BackupInstanceResource`
info	[Changelog] - New field `FeatureSettings` in struct `BackupVault`
info	[Changelog] - New field `IsVaultProtectedByResourceGuard` in struct `BackupVault`
info	[Changelog] - New field `SecuritySettings` in struct `BackupVault`
info	[Changelog] - New field `FeatureSettings` in struct `PatchBackupVaultInput`
info	[Changelog] - New field `SecuritySettings` in struct `PatchBackupVaultInput`
info	[Changelog] - New field `BackupDatasourceParametersList` in struct `PolicyParameters`
info	[Changelog] - New field `TargetResourceArmID` in struct `TargetDetails`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 75 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8c9a6bd. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-dataprotection [View full logs] [Release SDK Changes]
- azure-arm-dataprotection-1.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 8c9a6bd. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.dataprotection [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-01-30T09:07:31Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/dataprotection/armdataprotection	https://apiview.dev/Assemblies/Review/156cb39bad5449af9c37da302d955204
Java	azure-resourcemanager-dataprotection	https://apiview.dev/Assemblies/Review/370d15356cb94922af2c4a4cd2b0eb8a
.Net	Azure.ResourceManager.DataProtectionBackup	https://apiview.dev/Assemblies/Review/55bf82aad53e475494fdc4d2575c5d99
JavaScript	@azure/arm-dataprotection	https://apiview.dev/Assemblies/Review/fa5bdf57410648e587b2f1f5aed0bb7e

MaryGao

LGTM

xiaoxuqi-ms · 2023-01-31T02:20:51Z

/azp run

azure-pipelines · 2023-01-31T02:21:01Z

Azure Pipelines successfully started running 1 pipeline(s).

xiaoxuqi-ms · 2023-01-31T02:52:28Z

Hi @tadelesh , could you help to take a look at the go generation failure?

tadelesh · 2023-01-31T02:54:14Z

Hi @tadelesh , could you help to take a look at the go generation failure?

It seems the pipeline has some problems. Ruoxuan is working on it.

qiaozha · 2023-01-31T08:55:48Z

/azp run

azure-pipelines · 2023-01-31T08:55:58Z

Azure Pipelines successfully started running 1 pipeline(s).

update typescript.md in dataprotection

13c5f0c

kazrael2119 requested a review from MaryGao January 30, 2023 09:07

kazrael2119 requested a review from qiaozha as a code owner January 30, 2023 09:07

openapi-assignment-bot bot assigned xiaoxuqi-ms Jan 30, 2023

azure-sdk mentioned this pull request Jan 30, 2023

[AutoPR sdk/resourcemanager/dataprotection/armdataprotection] update typescript.md in dataprotection azure-sdk/azure-sdk-for-go#4131

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 30, 2023

AzureRestAPISpecReview added the resource-manager label Jan 30, 2023

azure-sdk mentioned this pull request Jan 30, 2023

[AutoPR track2_azure-mgmt-dataprotection] update typescript.md in dataprotection azure-sdk/azure-sdk-for-python#2633

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Jan 30, 2023

MaryGao approved these changes Jan 30, 2023

View reviewed changes

qiaozha approved these changes Jan 31, 2023

View reviewed changes

xiaoxuqi-ms approved these changes Jan 31, 2023

View reviewed changes

xiaoxuqi-ms removed the CI-BreakingChange-Go label Jan 31, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 31, 2023

qiaozha merged commit 8c9a6bd into main Feb 3, 2023

qiaozha deleted the update-typescript.md branch February 3, 2023 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update typescript.md in dataprotection #22350

update typescript.md in dataprotection #22350

kazrael2119 commented Jan 30, 2023 •

edited by MaryGao

Loading

openapi-workflow-bot bot commented Jan 30, 2023

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

MaryGao left a comment

xiaoxuqi-ms commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

xiaoxuqi-ms commented Jan 31, 2023

tadelesh commented Jan 31, 2023

qiaozha commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

update typescript.md in dataprotection #22350

update typescript.md in dataprotection #22350

Conversation

kazrael2119 commented Jan 30, 2023 • edited by MaryGao Loading

openapi-workflow-bot bot commented Jan 30, 2023

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jan 30, 2023 • edited Loading

Generated ApiView

MaryGao left a comment

Choose a reason for hiding this comment

xiaoxuqi-ms commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

xiaoxuqi-ms commented Jan 31, 2023

tadelesh commented Jan 31, 2023

qiaozha commented Jan 31, 2023

azure-pipelines bot commented Jan 31, 2023

kazrael2119 commented Jan 30, 2023 •

edited by MaryGao

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jan 30, 2023 •

edited

Loading