-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BillingRP AssociatedTenants and BillingRequests #22538
BillingRP AssociatedTenants and BillingRequests #22538
Conversation
Hi, @bradenwatkins Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
types.json | 2023-04-01(5c44692) | 2021-10-01(main) |
️❌
LintDiff: 8 Errors, 2 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2023-04 | package-2023-04(5c44692) | package-2023-04(billing/2023-04-01) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Billing/stable/2023-04-01/associatedTenant.json#L57 |
|
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Billing/stable/2023-04-01/associatedTenant.json#L114 |
|
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Billing/stable/2023-04-01/associatedTenant.json#L114 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Billing/stable/2023-04-01/associatedTenant.json#L173 |
|
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Billing/stable/2023-04-01/billingRequest.json#L322 |
|
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Billing/stable/2023-04-01/billingRequest.json#L322 |
|
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Billing/stable/2023-04-01/billingRequest.json#L378 |
|
TopLevelResourcesListBySubscription |
The top-level resource 'BillingRequest' does not have list by subscription operation, please add it. Location: Microsoft.Billing/stable/2023-04-01/billingRequest.json#L458 |
RPC-Get-V1-05 |
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Billing/stable/2023-04-01/associatedTenant.json#L205 |
||
The resource BillingRequest does not have a corresponding delete operation. Location: Microsoft.Billing/stable/2023-04-01/billingRequest.json#L458 |
RPC-Delete-V1-05 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L257 |
|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L302 |
|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L347 |
|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L389 |
|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L431 |
|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L470 |
|
Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Billing/stable/2023-04-01/payments.json#L507 |
|
Use the latest version v5 of types.json. Location: Microsoft.Billing/stable/2023-04-01/types.json#L101 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Billing/stable/2023-04-01/types.json#L187 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Billing/stable/2023-04-01/types.json#L305 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
c47292d
to
81333f7
Compare
Hi @bradenwatkins, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @bradenwatkins, Your PR has some issues. Please fix the CI sequentially by following the order of
|
81333f7
to
c88b8c9
Compare
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
15 similar comments
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @bradenwatkins. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
...ification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/associatedTenant.json
Outdated
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/associatedTenant.json
Show resolved
Hide resolved
...ification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/associatedTenant.json
Show resolved
Hide resolved
specification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/billingRequest.json
Outdated
Show resolved
Hide resolved
specification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/billingRequest.json
Outdated
Show resolved
Hide resolved
specification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/billingRequest.json
Show resolved
Hide resolved
specification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/billingRequest.json
Show resolved
Hide resolved
specification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/billingRequest.json
Outdated
Show resolved
Hide resolved
specification/billing/resource-manager/Microsoft.Billing/stable/2023-04-01/billingRequest.json
Show resolved
Hide resolved
"properties": { | ||
"friendlyName": "Contoso Finance", | ||
"billingManagementState": "Active", | ||
"provisioningState": "Pending" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Wilco that having two lists of tenants would be a cleaner approach, as I mentioned this during original discussions. But I do not feel strong enough about it to push against using a single associatedTenants list to represent both.
Given that, I am okay with the current approach to have billingManagmentState and provisioningState.
e2b8bd6
to
2d16411
Compare
…est-api-specs into brwatkin/2023-04-01-multi-tenancy
b0de48a
into
Azure:billing/2023-04-01
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.