Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flush rest api specs #22628

Merged
merged 9 commits into from
Feb 22, 2023
Merged

Add flush rest api specs #22628

merged 9 commits into from
Feb 22, 2023

Conversation

revanthballa1188
Copy link
Member

@revanthballa1188 revanthballa1188 commented Feb 15, 2023 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @revanthballa1188 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    redisenterprise.json 2023-03-01-preview(0e1585d) 2022-01-01(main)
    redisenterprise.json 2023-03-01-preview(0e1585d) 2022-11-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌LintDiff: 2 Errors, 0 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-03 package-preview-2023-03(0e1585d) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1185    		 RPC-Uri-V1-05
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1185    		 RPC-Uri-V1-05


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L115
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L116
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L220
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L231
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L264
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L400
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L446
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L446
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L447
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L562
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L617
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L654
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L669
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L669
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L715
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L715
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L765
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L777
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L777
    ❌ PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L778
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L824
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L836
    ❌ ResourceNameRestriction The resource name parameter 'databaseName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L836
    ❌ PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L837
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L883
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L895
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L895
    ❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L940
    ❌ ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L940
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L984
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Cache' for api version '2023-03-01-preview'. The supported api-versions are '2022-11-01-preview,
    2022-06-01,
    2022-05-01,
    2021-06-01,
    2021-03-01,
    2021-02-01-preview,
    2020-12-01,
    2020-10-01-preview,
    2020-06-01,
    2019-07-01,
    2018-03-01,
    2017-10-01,
    2017-02-01,
    2016-04-01,
    2015-08-01,
    2015-03-01,
    2014-04-01,
    2014-04-01-preview,
    2014-04-01-alpha'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6949b0b. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.5.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redisenterprise [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation DatabasesOperations.begin_flush
info	[Changelog]   - Added operation group SkusOperations
info	[Changelog]   - Model Cluster has a new parameter encryption
info	[Changelog]   - Model Cluster has a new parameter identity
info	[Changelog]   - Model Cluster has a new parameter system_data
info	[Changelog]   - Model ClusterUpdate has a new parameter encryption
info	[Changelog]   - Model ClusterUpdate has a new parameter identity
info	[Changelog]   - Model Database has a new parameter system_data
info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model TrackedResource has a new parameter system_data
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6949b0b. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New type alias `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedIdentity`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`, `ManagedServiceIdentityTypeUserAssignedIdentity`
info	[Changelog] - New type alias `Name` with values `NameEnterpriseE10`, `NameEnterpriseE100`, `NameEnterpriseE20`, `NameEnterpriseE50`, `NameEnterpriseFlashF1500`, `NameEnterpriseFlashF300`, `NameEnterpriseFlashF700`
info	[Changelog] - New function `*DatabasesClient.BeginFlush(context.Context, string, string, string, FlushParameters, *DatabasesClientBeginFlushOptions) (*runtime.Poller[DatabasesClientFlushResponse], error)`
info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
info	[Changelog] - New function `*SKUsClient.NewListPager(string, *SKUsClientListOptions) *runtime.Pager[SKUsClientListResponse]`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `Capability`
info	[Changelog] - New struct `ClusterPropertiesEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity`
info	[Changelog] - New struct `FlushParameters`
info	[Changelog] - New struct `LocationInfo`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `RegionSKUDetail`
info	[Changelog] - New struct `RegionSKUDetails`
info	[Changelog] - New struct `SKUDetail`
info	[Changelog] - New struct `SKUsClient`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity` in struct `Cluster`
info	[Changelog] - New field `SystemData` in struct `Cluster`
info	[Changelog] - New field `Encryption` in struct `ClusterProperties`
info	[Changelog] - New field `Identity` in struct `ClusterUpdate`
info	[Changelog] - New field `SystemData` in struct `Database`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 61 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6949b0b. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-redisenterprisecache [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Skus
info	[Changelog]   - Added operation Databases.beginFlush
info	[Changelog]   - Added operation Databases.beginFlushAndWait
info	[Changelog]   - Added Interface Capability
info	[Changelog]   - Added Interface ClusterPropertiesEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity
info	[Changelog]   - Added Interface DatabasesFlushHeaders
info	[Changelog]   - Added Interface DatabasesFlushOptionalParams
info	[Changelog]   - Added Interface FlushParameters
info	[Changelog]   - Added Interface LocationInfo
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface RegionSkuDetail
info	[Changelog]   - Added Interface RegionSkuDetails
info	[Changelog]   - Added Interface SkuDetail
info	[Changelog]   - Added Interface SkusListOptionalParams
info	[Changelog]   - Added Interface SystemData
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Added Type Alias Name
info	[Changelog]   - Added Type Alias SkusListResponse
info	[Changelog]   - Interface Cluster has a new optional parameter encryption
info	[Changelog]   - Interface Cluster has a new optional parameter identity
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter encryption
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter identity
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Added Enum KnownName
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6949b0b. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️redisenterprise [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 6949b0b. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.redisenterprise [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 15, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/redisenterprise/armredisenterprise https://apiview.dev/Assemblies/Review/5cb784b7b0d04e918dcb173a7dea9025
    .Net Azure.ResourceManager.RedisEnterprise https://apiview.dev/Assemblies/Review/04c03f8a241645b8aa2d896efb8dc1f3
    Java azure-resourcemanager-redisenterprise https://apiview.dev/Assemblies/Review/1cbe69cb677541de9013147041b7177e
    JavaScript @azure/arm-redisenterprisecache https://apiview.dev/Assemblies/Review/d17f94dd3cef45e9b742d66ebc73acbf

    @revanthballa1188 revanthballa1188 changed the title Redisenterprise microsoft.cache 2023 03 01 preview v2 Add flush rest api specs Feb 15, 2023
    @revanthballa1188 revanthballa1188 marked this pull request as ready for review February 15, 2023 06:31
    This was referenced Feb 15, 2023
    Closed
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @revanthballa1188, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @revanthballa1188, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    This was referenced Feb 15, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    @revanthballa1188 revanthballa1188 force-pushed the redisenterprise-Microsoft.Cache-2023-03-01-preview-v2 branch from 67c0c5e to 8eb686b Compare February 15, 2023 17:17
    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 15, 2023
    @openapi-workflow-bot
    Copy link

    Hi @revanthballa1188, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @revanthballa1188
    Minor changes
    cc238a4
    @revanthballa1188
    fix lint error . 2. Revert parameter pattern change
    7615a23 
     Please enter the commit message for your changes. Lines starting
    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Feb 15, 2023
    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 18, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 18, 2023
    joroda
    joroda approved these changes Feb 22, 2023
    View reviewed changes
    Copy link
    Contributor

    @joroda joroda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approving changes.

    @ruowan ruowan merged commit 6949b0b into Azure:main Feb 22, 2023
    This was referenced Feb 22, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @TimLovellSmith TimLovellSmith mentioned this pull request Mar 14, 2023
    Merged
    11 tasks
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    @revanthballa1188 @aviyerMSFT
    Add flush rest api specs (Azure#22628)
    c3332ac 
    * Adds base for updating Microsoft.Cache from version preview/2022-11-01-preview to version 2023-03-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding flush rest api specs

* Add pattern for cluster and database parameters

* Minor changes

* fix lint error . 2. Revert parameter pattern change
 Please enter the commit message for your changes. Lines starting

* updating the texts

* Make the ids of the flush parameters to be optional
    @revanthballa1188 revanthballa1188 mentioned this pull request Jul 28, 2023
    Merged
    8 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @TimLovellSmith TimLovellSmith TimLovellSmith left review comments

    @joroda joroda joroda approved these changes

    @ruowan ruowan ruowan approved these changes

    Assignees

    @ruowan ruowan

    Labels
    Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @revanthballa1188 @TimLovellSmith @joroda @ruowan @rkmanda @AzureRestAPISpecReview