Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Insights to add version preview/2023-03-15-preview #22993

Merged

Conversation

meydand
Copy link
Contributor

@meydand meydand commented Mar 9, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @meydand Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 9, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 1 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    scheduledQueryRule_API.json 2023-03-15-preview(1293c9f) 2022-06-15(main)
    scheduledQueryRule_API.json 2023-03-15-preview(1293c9f) 2022-08-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'publicNetworkAccess' renamed or removed?
    New: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L358:7
    Old: Microsoft.Insights/preview/2022-08-01-preview/scheduledQueryRule_API.json#L350:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-04 package-preview-2023-04(1293c9f) package-preview-2023-04(main)
    package-preview-2023-03 package-preview-2023-03(1293c9f) package-preview-2023-03(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ResourceNameRestriction The resource name parameter 'ruleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L118
    ResourceNameRestriction The resource name parameter 'ruleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L118
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L345
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L345
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L364
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L364
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L393
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L393
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L440
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L440
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L445
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L445
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L449
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L449
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L453
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-03-15-preview/scheduledQueryRule_API.json#L453
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-preview-2023-04
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 131 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2023-04; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 114, untested: 0, failed: 76, passed: 38

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/privateLinkScopes'. List of available regions for the resource type is 'global'.
    Source: runtime
    OperationId: PrivateLinkScopes_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenamsf4ciw' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenamsf4ciw' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_UpdateTags
    CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/actiongroups'. List of available regions for the resource type is 'global,swedencentral,germanywestcentral,northcentralus,southcentralus,eastus2euap,centraluseuap'.
    Source: runtime
    OperationId: ActionGroups_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_Update
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_EnableReceiver
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_EnableReceiver
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrkmlkof' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel
    CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/metricalerts'. List of available regions for the resource type is 'global,westeurope,northeurope,swedencentral,germanywestcentral,eastus2euap'.
    Source: runtime
    OperationId: MetricAlerts_CreateOrUpdate
    INVALID_FORMAT Object didn't pass validation for format duration: Pt1m
    Source: request
    OperationId: MetricAlerts_CreateOrUpdate
    INVALID_FORMAT Object didn't pass validation for format duration: Pt15m
    Source: request
    OperationId: MetricAlerts_CreateOrUpdate
    INVALID_TYPE Expected type object but found type array
    Source: request
    OperationId: MetricAlerts_CreateOrUpdate
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: MetricAlerts_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulename2att2l' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MetricAlerts_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: MetricAlerts_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulename2att2l' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MetricAlerts_Update
    INVALID_FORMAT Object didn't pass validation for format duration: Pt1m
    Source: request
    OperationId: MetricAlerts_Update
    INVALID_FORMAT Object didn't pass validation for format duration: Pt15m
    Source: request
    OperationId: MetricAlerts_Update
    INVALID_TYPE Expected type object but found type array
    Source: request
    OperationId: MetricAlerts_Update
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: MetricAlerts_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: AlertRules_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/alertrules/rulename2att2l' under resource group 'apiTest-BOcLFG-22993' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: AlertRules_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: AlertRules_Get
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 9, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/monitor/armmonitor - Approved - 0.10.0
    +	Field `PublicNetworkAccess` of struct `ScheduledQueryRuleProperties` has been removed
    +	Type alias `PublicNetworkAccess` has been removed
    azure-sdk-for-js - @azure/arm-monitor - Approved - 8.0.0-beta.5
    +	Class MonitorClient no longer has parameter metrics
    +	Enum KnownOperator no longer has value Include
    +	Enum KnownProvisioningState no longer has value Deploying
    +	Interface ActivityLogsListNextOptionalParams no longer has parameter select
    +	Interface AzureResource no longer has parameter identity
    +	Interface AzureResource no longer has parameter kind
    +	Interface PrivateEndpointConnectionListResult no longer has parameter nextLink
    +	Interface PrivateLinkResourceListResult no longer has parameter nextLink
    +	Interface ResourceAutoGenerated no longer has parameter etag
    +	Interface ResourceAutoGenerated no longer has parameter kind
    +	Interface ScheduledQueryRulesListByResourceGroupOptionalParams no longer has parameter filter
    +	Interface ScheduledQueryRulesListBySubscriptionOptionalParams no longer has parameter filter
    +	Interface TenantActivityLogsListNextOptionalParams no longer has parameter filter
    +	Interface TenantActivityLogsListNextOptionalParams no longer has parameter select
    +	Operation ActivityLogAlerts.update has a new signature
    +	Operation ScheduledQueryRules.createOrUpdate has a new signature
    +	Operation ScheduledQueryRules.update has a new signature
    +	Removed Enum KnownConditionalOperator
    +	Removed Enum KnownEnabled
    +	Removed Enum KnownMetricTriggerType
    +	Removed Enum KnownQueryType
    +	Removed operation ActionGroups.beginPostTestNotifications
    +	Removed operation ActionGroups.beginPostTestNotificationsAndWait
    +	Removed operation ActionGroups.getTestNotifications
    +	Removed operation group Metrics
    +	Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetail
    +	Type of parameter operator of interface Dimension is changed from Operator to DimensionOperator
    +	Type of parameter unit of interface Metric is changed from MetricUnit to Unit
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 529aaf1. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Monitor [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 529aaf1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-monitor [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 529aaf1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/monitor/armmonitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*PrivateEndpointConnectionsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, PrivateEndpointConnectionAutoGenerated, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions)`
      info	[Changelog] - Type of `AzureMonitorPrivateLinkScopeProperties.PrivateEndpointConnections` has been changed from `[]*PrivateEndpointConnection` to `[]*PrivateEndpointConnectionAutoGenerated`
      info	[Changelog] - Type of `DefaultErrorResponse.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
      info	[Changelog] - Type of `ErrorContract.Error` has been changed from `*ErrorResponse` to `*ErrorResponseAutoGenerated`
      info	[Changelog] - Type of `ErrorResponseCommonV2.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
      info	[Changelog] - Type of `OperationStatus.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
      info	[Changelog] - Type of `PrivateEndpointConnectionListResult.Value` has been changed from `[]*PrivateEndpointConnection` to `[]*PrivateEndpointConnectionAutoGenerated`
      info	[Changelog] - Operation `*AzureMonitorWorkspacesClient.Delete` has been changed to LRO, use `*AzureMonitorWorkspacesClient.BeginDelete` instead.
      info	[Changelog] - Field `Code`, `Message` of struct `ErrorResponse` has been removed
      info	[Changelog] - Field `Error` of struct `ErrorResponseAutoGenerated2` has been removed
      info	[Changelog] - Field `ActionType`, `IsDataAction`, `Origin` of struct `OperationAutoGenerated` has been removed
      info	[Changelog] - Field `Description` of struct `OperationDisplayAutoGenerated` has been removed
      info	[Changelog] - Field `OperationListResult` of struct `OperationsClientListResponse` has been removed
      info	[Changelog] - Field `OperationListResultAutoGenerated` of struct `OperationsForMonitorClientListResponse` has been removed
      info	[Changelog] - Field `PrivateEndpointConnection` of struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse` has been removed
      info	[Changelog] - Field `PrivateEndpointConnection` of struct `PrivateEndpointConnectionsClientGetResponse` has been removed
      info	[Changelog] - Field `Location`, `Tags` of struct `Resource` has been removed
      info	[Changelog] - Field `Location`, `Tags` of struct `ResourceAutoGenerated` has been removed
      info	[Changelog] - Field `SystemData` of struct `ResourceAutoGenerated5` has been removed
      info	[Changelog] - Field `SystemData` of struct `TrackedResourceAutoGenerated` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `PrivateEndpointAutoGenerated`
      info	[Changelog] - New struct `PrivateEndpointConnectionAutoGenerated`
      info	[Changelog] - New struct `PrivateEndpointConnectionPropertiesAutoGenerated`
      info	[Changelog] - New struct `ResourceAutoGenerated6`
      info	[Changelog] - New field `PrivateEndpointConnections`, `PublicNetworkAccess` in struct `AzureMonitorWorkspace`
      info	[Changelog] - New field `PrivateEndpointConnections`, `PublicNetworkAccess` in struct `AzureMonitorWorkspaceResourceProperties`
      info	[Changelog] - New field `Error` in struct `ErrorResponse`
      info	[Changelog] - New field `Code`, `Message` in struct `ErrorResponseAutoGenerated2`
      info	[Changelog] - New field `ActionType`, `IsDataAction`, `Origin` in struct `Operation`
      info	[Changelog] - New field `Description` in struct `OperationDisplay`
      info	[Changelog] - New anonymous field `OperationListResultAutoGenerated` in struct `OperationsClientListResponse`
      info	[Changelog] - New anonymous field `OperationListResult` in struct `OperationsForMonitorClientListResponse`
      info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
      info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New anonymous field `PrivateEndpointConnectionAutoGenerated` in struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse`
      info	[Changelog] - New anonymous field `PrivateEndpointConnectionAutoGenerated` in struct `PrivateEndpointConnectionsClientGetResponse`
      info	[Changelog] - New field `SystemData` in struct `ResourceAutoGenerated`
      info	[Changelog] - New field `SystemData` in struct `ResourceAutoGenerated2`
      info	[Changelog] - New field `Location`, `Tags` in struct `ResourceAutoGenerated3`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 20 breaking change(s), 24 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 529aaf1. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias ScheduledQueryRulesListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ScheduledQueryRulesListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias TenantActionGroupsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias TenantActionGroupsGetResponse
      info	[Changelog]   - Added Type Alias TenantActionGroupsListByManagementGroupIdResponse
      info	[Changelog]   - Added Type Alias TenantActionGroupsUpdateResponse
      info	[Changelog]   - Added Type Alias TimeAggregation
      info	[Changelog]   - Added Type Alias Unit
      info	[Changelog]   - Interface AutoscaleSettingResourcePatch has a new optional parameter predictiveAutoscalePolicy
      info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter failoverConfiguration
      info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter metricsIngestion
      info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter privateLinkScopedResources
      info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter failoverConfiguration
      info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter identity
      info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter metricsIngestion
      info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter privateLinkScopedResources
      info	[Changelog]   - Interface DataCollectionRule has a new optional parameter dataCollectionEndpointId
      info	[Changelog]   - Interface DataCollectionRule has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRule has a new optional parameter streamDeclarations
      info	[Changelog]   - Interface DataCollectionRuleAssociation has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRuleAssociationProxyOnlyResource has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter dataCollectionEndpointId
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter identity
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter streamDeclarations
      info	[Changelog]   - Interface DataFlow has a new optional parameter builtInTransform
      info	[Changelog]   - Interface DataFlow has a new optional parameter outputStream
      info	[Changelog]   - Interface DataFlow has a new optional parameter transformKql
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter dataImports
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter iisLogs
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter logFiles
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter platformTelemetry
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter prometheusForwarder
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter windowsFirewallLogs
      info	[Changelog]   - Interface DestinationsSpec has a new optional parameter eventHubs
      info	[Changelog]   - Interface DestinationsSpec has a new optional parameter eventHubsDirect
      info	[Changelog]   - Interface DestinationsSpec has a new optional parameter monitoringAccounts
      info	[Changelog]   - Interface DestinationsSpec has a new optional parameter storageAccounts
      info	[Changelog]   - Interface DestinationsSpec has a new optional parameter storageBlobsDirect
      info	[Changelog]   - Interface DestinationsSpec has a new optional parameter storageTablesDirect
      info	[Changelog]   - Interface ErrorResponse has a new optional parameter error
      info	[Changelog]   - Interface LogSettings has a new optional parameter categoryGroup
      info	[Changelog]   - Interface MetricsListOptionalParams has a new optional parameter autoAdjustTimegrain
      info	[Changelog]   - Interface MetricsListOptionalParams has a new optional parameter validateDimensions
      info	[Changelog]   - Interface Operation has a new optional parameter actionType
      info	[Changelog]   - Interface Operation has a new optional parameter isDataAction
      info	[Changelog]   - Interface Operation has a new optional parameter origin
      info	[Changelog]   - Interface OperationDisplay has a new optional parameter description
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Interface ResourceAutoGenerated has a new optional parameter systemData
      info	[Changelog]   - Interface ResourceForUpdate has a new optional parameter identity
      info	[Changelog]   - Added Enum KnownAccessMode
      info	[Changelog]   - Added Enum KnownActionType
      info	[Changelog]   - Added Enum KnownCategoryType
      info	[Changelog]   - Added Enum KnownDimensionOperator
      info	[Changelog]   - Added Enum KnownKind
      info	[Changelog]   - Added Enum KnownKnownColumnDefinitionType
      info	[Changelog]   - Added Enum KnownKnownLocationSpecProvisioningStatus
      info	[Changelog]   - Added Enum KnownKnownLogFilesDataSourceFormat
      info	[Changelog]   - Added Enum KnownKnownLogFileTextSettingsRecordStartTimestampFormat
      info	[Changelog]   - Added Enum KnownKnownPrometheusForwarderDataSourceStreams
      info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
      info	[Changelog]   - Added Enum KnownMetricAggregationType
      info	[Changelog]   - Added Enum KnownMetricResultType
      info	[Changelog]   - Added Enum KnownOrigin
      info	[Changelog]   - Added Enum KnownPrivateEndpointConnectionProvisioningState
      info	[Changelog]   - Added Enum KnownPrivateEndpointServiceConnectionStatus
      info	[Changelog]   - Added Enum KnownPublicNetworkAccess
      info	[Changelog]   - Added Enum KnownTimeAggregation
      info	[Changelog]   - Enum KnownKnownDataCollectionEndpointProvisioningState has a new value Canceled
      info	[Changelog]   - Enum KnownKnownDataCollectionRuleAssociationProvisioningState has a new value Canceled
      info	[Changelog]   - Enum KnownKnownDataCollectionRuleProvisioningState has a new value Canceled
      info	[Changelog]   - Enum KnownKnownPublicNetworkAccessOptions has a new value SecuredByPerimeter
      info	[Changelog]   - Enum KnownProvisioningState has a new value Creating
      info	[Changelog]   - Enum KnownProvisioningState has a new value Deleting
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group Metrics
      info	[Changelog]   - Removed operation ActionGroups.beginPostTestNotifications
      info	[Changelog]   - Removed operation ActionGroups.beginPostTestNotificationsAndWait
      info	[Changelog]   - Removed operation ActionGroups.getTestNotifications
      info	[Changelog]   - Operation ActivityLogAlerts.update has a new signature
      info	[Changelog]   - Operation PrivateEndpointConnections.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation PrivateEndpointConnections.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Operation ScheduledQueryRules.createOrUpdate has a new signature
      info	[Changelog]   - Operation ScheduledQueryRules.update has a new signature
      info	[Changelog]   - Interface ActivityLogsListNextOptionalParams no longer has parameter select
      info	[Changelog]   - Interface AzureResource no longer has parameter identity
      info	[Changelog]   - Interface AzureResource no longer has parameter kind
      info	[Changelog]   - Interface ErrorResponse no longer has parameter code
      info	[Changelog]   - Interface ErrorResponse no longer has parameter message
      info	[Changelog]   - Interface PrivateEndpointConnectionListResult no longer has parameter nextLink
      info	[Changelog]   - Interface PrivateLinkResourceListResult no longer has parameter nextLink
      info	[Changelog]   - Interface Resource no longer has parameter location
      info	[Changelog]   - Interface Resource no longer has parameter tags
      info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter etag
      info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter kind
      info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter location
      info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter tags
      info	[Changelog]   - Interface ScheduledQueryRulesListByResourceGroupOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ScheduledQueryRulesListBySubscriptionOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter select
      info	[Changelog]   - Type of parameter operator of interface Dimension is changed from Operator to DimensionOperator
      info	[Changelog]   - Type of parameter error of interface ErrorContract is changed from ErrorResponse to ErrorResponseAutoGenerated
      info	[Changelog]   - Type of parameter error of interface ErrorResponseCommonV2 is changed from ErrorDetail to ErrorDetailAutoGenerated
      info	[Changelog]   - Type of parameter unit of interface Metric is changed from MetricUnit to Unit
      info	[Changelog]   - Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetailAutoGenerated
      info	[Changelog]   - Type of parameter value of interface PrivateEndpointConnectionListResult is changed from PrivateEndpointConnection[] to PrivateEndpointConnectionAutoGenerated[]
      info	[Changelog]   - Class MonitorClient no longer has parameter metrics
      info	[Changelog]   - Removed Enum KnownConditionalOperator
      info	[Changelog]   - Removed Enum KnownEnabled
      info	[Changelog]   - Removed Enum KnownMetricTriggerType
      info	[Changelog]   - Removed Enum KnownQueryType
      info	[Changelog]   - Enum KnownOperator no longer has value Include
      info	[Changelog]   - Enum KnownProvisioningState no longer has value Deploying
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 529aaf1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
    • ️✔️monitor [View full logs]  [Release Schema Changes]
    • ️✔️monitor [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		monitor
      error		monitor
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 529aaf1. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.monitor.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.monitor.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 9, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/monitor/armmonitor https://apiview.dev/Assemblies/Review/2b17005db30f4969a49f052885d9f60b
    Java azure-resourcemanager-monitor-generated https://apiview.dev/Assemblies/Review/148274c459634abb97023720467889e9
    .Net Azure.ResourceManager.Monitor There is no API change compared with the previous version
    JavaScript @azure/arm-monitor https://apiview.dev/Assemblies/Review/8c7bc083b891402eba235a8f4dac6237

    @openapi-workflow-bot
    Copy link

    Hi, @meydand your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 9, 2023
    @mentat9 mentat9 added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Mar 10, 2023
    @openapi-workflow-bot
    Copy link

    Hi @meydand, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 10, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 10, 2023
    @mikekistler mikekistler removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Mar 29, 2023
    @ghost
    Copy link

    ghost commented Apr 16, 2023

    Hi, @meydand. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @meydand
    Copy link
    Contributor Author

    meydand commented Apr 20, 2023

    @ArcturusZhang - I fixed the autorest file.
    Can we complete this PR?

    @meydand meydand removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 27, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 27, 2023
    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 27, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 27, 2023
    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 4, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript Monitor Monitor, Monitor Ingestion, Monitor Query new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    10 participants