Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventGrid Typespec] Move @internal to client.tsp #23538

Merged
merged 1 commit into from
Apr 13, 2023
Merged

[EventGrid Typespec] Move @internal to client.tsp #23538

merged 1 commit into from
Apr 13, 2023

Conversation

l0lawrence
Copy link
Member

No description provided.

@openapi-workflow-bot
Copy link

Hi, @l0lawrence Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @ghost ghost added the Event Grid label Apr 13, 2023
    @l0lawrence l0lawrence changed the base branch from main to feature/eventgrid/typespec April 13, 2023 01:51
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    3 similar comments
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @l0lawrence l0lawrence marked this pull request as ready for review April 13, 2023 16:33
    lmazuel
    lmazuel approved these changes Apr 13, 2023
    View reviewed changes
    Copy link
    Member

    @lmazuel lmazuel left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is moving the TCGC part into the client.tsp, which is correct

    @lmazuel lmazuel merged commit 5d21632 into Azure:feature/eventgrid/typespec Apr 13, 2023
    lmazuel added a commit that referenced this pull request May 22, 2023
    @l0lawrence @lmazuel
    @JoshLove-msft @ahamad-MS
    EventGridv2 TypeSpec Api Preview (#23204)
    f6f647a 
    * start typespec

* adding eventgrid typespec for api w/ TODOs

* update eventgrid typespec with latest eventgrid v2 operations

* don't require content-type if there is no body

* Update specification/eventgrid/typespec/main.tsp

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* Update specification/eventgrid/typespec/main.tsp

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* changing naming of cloudevent and added in data_base64

* openapi.json

* Update specification/eventgrid/typespec/main.tsp

Co-authored-by: Libba Lawrence <llawrence@microsoft.com>

* Update specification/eventgrid/typespec/main.tsp

Co-authored-by: Libba Lawrence <llawrence@microsoft.com>

* Update specification/eventgrid/typespec/main.tsp

Co-authored-by: Libba Lawrence <llawrence@microsoft.com>

* lockTokens format, updated json, optional? params

* address code review comments

* name_change

* add @internal for python

* Update specification/eventgrid/Azure.Messaging.EventGrid/main.tsp

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* move @internal to client.tsp (#23538)

* rename (#23565)

* [EventGrid Typespec] breaking changes with april release of typespec (#23539)

* breaking changes with april release of typespec

* unknown type

* [EG Typespec] Update Release behavior (#23699)

* update behavior

* just behavior

* Add tspconfig and remove AAD auth (#23717)

* add tspconfig

* add namespace

* remove oauth

* [EG TypeSpec] Archboard Comments (#23696)

* refactoring off of apiview

* keep as int

* no duration

* aligning ack and release

* remove behavioral change

* ack to release

* initial naming changes

* Update ReleaseResult doc

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* Update AckResult doc

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* versioning twice-- remove one instance

---------

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* Address couple of stewardship team feedback. These include: 1. Rename CloudEventEvent to simply CloudEvent, 2. Add more description to the operations including the possible erorr codes, 3. Add PublishResult with empty Json object as successful response for the Publish operation, 4. Others.

* Add support for missing Reject operation + adding deliveryAttemptCount to BrokerProperties + Adding query parameter for release operation for deliveryDelayInSeconds

* Update failedTokens/SuccessfulTokens Description to address code review comments

* Update to match service behavior (#23754)

* Update to match service behavior

* remove locktoken

* [EGv2] Editing unused variables (#23917)

* event delivery delay not in preview

* remove from url comment

* [EGv2] Version dependency on Azure.Core  (#23936)

* verioning fix

* spacing mishap?

* [EventGrid] Deliveryattempt change (#23960)

* deliveryCount 5/1

* small typo

* [EventGrid] Remove internal (#23995)

* remove internal

* remove client.tsp

* remove waitWaitTime (#24078)

* move location of json file (#24076)

* [Egv2] Encode param (#24080)

* encode

* remove num default on duration

---------

Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>

* [EGv2] Fix pipeline (#24098)

* regen off new commit for encode

* reference preview tag

* ignore word

* update readme to have both apis

* update with next autorest

* change format to int32

---------

Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: Ashraf Hamad <ahamad-MS@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lmazuel lmazuel lmazuel approved these changes

    @Kishp01 Kishp01 Awaiting requested review from Kishp01

    @ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

    Assignees
    No one assigned
    Labels
    Event Grid
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @l0lawrence @lmazuel