Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'nickdepinet-devcenter-Microsoft.DevCenter-2023-04-01' #23695

Conversation

nickdepinet
Copy link
Member

@nickdepinet nickdepinet commented Apr 24, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      Publish approved + merged api spec from private branch to public
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    Already deployed to public regions
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    ASAP
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@nickdepinet
Copy link
Member Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/11737

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 24, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
commonDefinitions.json 2023-04-01(8c1c7c2) 2023-01-01-preview(main)
devcenter.json 2023-04-01(8c1c7c2) 2023-01-01-preview(main)
vdi.json 2023-04-01(8c1c7c2) 2023-01-01-preview(main)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) new version base version
package-2023-04 package-2023-04(8c1c7c2) default(main)

The following errors/warnings exist before current PR submission:

Rule Message
⚠️ LroExtension Operations with a 202 response should specify x-ms-long-running-operation: true.
Location: Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L2592
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L3185
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.DevCenter/stable/2023-04-01/devcenter.json#L3705
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.DevCenter/stable/2023-04-01/vdi.json#L1152
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 54 Errors, 0 Warnings failed [Detail]

Tag package-2023-04; Prod region: Deployed

Test run on region: westeurope; Operation coverage: total: 78, untested: 0, failed: 51, passed: 27

Service API Readiness Test failed. Check pipeline artifact for detail report.

Only 30 items are listed, please refer to log for more details.

Rule Message
CLIENT_ERROR statusCode: 400,
errorCode: ValidationError,
errorMessage: The request is not valid.
Source: runtime
OperationId: Projects_CreateOrUpdate
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: additionalInfo
Source: response
OperationId: Projects_CreateOrUpdate
CLIENT_ERROR statusCode: 404,
errorCode: ResourceNotFound,
errorMessage: The Resource 'Microsoft.DevCenter/projects/projectn1db3ob' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
Source: runtime
OperationId: Projects_Get
CLIENT_ERROR statusCode: 404,
errorCode: ResourceNotFound,
errorMessage: The Resource 'Microsoft.DevCenter/projects/projectn1db3ob' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
Source: runtime
OperationId: Projects_Update
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: Pools_CreateOrUpdate
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: Pools_ListByProject
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: Pools_Get
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: Pools_Update
CLIENT_ERROR statusCode: 404,
errorCode: ResourceNotFound,
errorMessage: The Resource 'Microsoft.DevCenter/projects/projectn1db3ob/pools/poolnameyuupus' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
Source: runtime
OperationId: Pools_RunHealthChecks
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_CreateOrUpdate
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_ListBySubscription
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_ListHealthDetails
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_ListOutboundNetworkDependenciesEndpoints
CLIENT_ERROR statusCode: 404,
errorCode: ParentResourceNotFound,
errorMessage: Can not perform requested operation on nested resource. Parent resource 'networkczcvglg' not found.
Source: runtime
OperationId: NetworkConnections_GetHealthDetails
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_ListByResourceGroup
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_Get
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: NetworkConnections_Update
CLIENT_ERROR statusCode: 404,
errorCode: ResourceNotFound,
errorMessage: The Resource 'Microsoft.DevCenter/networkconnections/networkczcvglg' under resource group 'apiTest-OpewvM-23695' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
Source: runtime
OperationId: NetworkConnections_RunHealthChecks
CLIENT_ERROR statusCode: 400,
errorCode: ValidationError,
errorMessage: The request is not valid.
Source: runtime
OperationId: Galleries_CreateOrUpdate
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: additionalInfo
Source: response
OperationId: Galleries_CreateOrUpdate
CLIENT_ERROR statusCode: 404,
errorCode: ResourceNotFound,
errorMessage: The resource 'Microsoft.DevCenter/devcenters/devcenteafh2fw/galleries/galleryn0rnwfr' could not be found.
Source: runtime
OperationId: Galleries_Get
CLIENT_ERROR statusCode: 403,
errorCode: LinkedAuthorizationFailed,
errorMessage: The client has permission to perform action 'Microsoft.Authorization/roleAssignments/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-OpewvM-23695/providers/Microsoft.DevCenter/projects/projectn1db3ob/environmentTypes/environm40e1uy', however the linked subscription '00000000-0000-0000-0000-000000000000' was not found.
Source: runtime
OperationId: ProjectEnvironmentTypes_CreateOrUpdate
CLIENT_ERROR statusCode: 404,
errorCode: ParentResourceNotFound,
errorMessage: Can not perform requested operation on nested resource. Parent resource 'projectn1db3ob' not found.
Source: runtime
OperationId: ProjectEnvironmentTypes_List
CLIENT_ERROR statusCode: 404,
errorCode: ParentResourceNotFound,
errorMessage: Can not perform requested operation on nested resource. Parent resource 'projectn1db3ob' not found.
Source: runtime
OperationId: ProjectEnvironmentTypes_Get
CLIENT_ERROR statusCode: 403,
errorCode: LinkedAuthorizationFailed,
errorMessage: The client has permission to perform action 'Microsoft.Authorization/roleAssignments/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-OpewvM-23695/providers/Microsoft.DevCenter/projects/projectn1db3ob/environmentTypes/environm40e1uy', however the linked subscription '00000000-0000-0000-0000-000000000000' was not found.
Source: runtime
OperationId: ProjectEnvironmentTypes_Update
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: DevBoxDefinitions_CreateOrUpdate
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: DevBoxDefinitions_ListByDevCenter
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: DevBoxDefinitions_ListByProject
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: DevBoxDefinitions_GetByProject
CLIENT_ERROR statusCode: 400,
errorCode: MissingApiVersionParameter,
errorMessage: The api-version query parameter (?api-version=) is required for all requests.
Source: runtime
OperationId: DevBoxDefinitions_Get
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @nickdepinet Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 24, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python - track2_azure-mgmt-devcenter - Approved - 1.0.0b4
    -	Removed operation group UsagesOperations
    azure-sdk-for-go - sdk/resourcemanager/devcenter/armdevcenter - Approved - 1.0.0
    +	Enum `EnableStatus` has been removed
    +	Field `Offer`, `Publisher`, `SKU` of struct `ImageReference` has been removed
    +	Type of `ProjectEnvironmentTypeProperties.Status` has been changed from `*EnableStatus` to `*EnvironmentTypeEnableStatus`
    +	Type of `ProjectEnvironmentTypeUpdateProperties.Status` has been changed from `*EnableStatus` to `*EnvironmentTypeEnableStatus`
    +	Type of `ScheduleProperties.State` has been changed from `*EnableStatus` to `*ScheduleEnableStatus`
    +	Type of `ScheduleUpdateProperties.State` has been changed from `*EnableStatus` to `*ScheduleEnableStatus`
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4f6418d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-devcenter [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation NetworkConnectionsOperations.list_outbound_network_dependencies_endpoints
      info	[Changelog]   - Added operation PoolsOperations.begin_run_health_checks
      info	[Changelog]   - Model Image has a new parameter hibernate_support
      info	[Changelog]   - Model Pool has a new parameter health_status
      info	[Changelog]   - Model Pool has a new parameter health_status_details
      info	[Changelog]   - Model Pool has a new parameter stop_on_disconnect
      info	[Changelog]   - Model PoolProperties has a new parameter health_status
      info	[Changelog]   - Model PoolProperties has a new parameter health_status_details
      info	[Changelog]   - Model PoolProperties has a new parameter stop_on_disconnect
      info	[Changelog]   - Model PoolUpdate has a new parameter stop_on_disconnect
      info	[Changelog]   - Model PoolUpdateProperties has a new parameter stop_on_disconnect
      info	[Changelog]   - Model Project has a new parameter max_dev_boxes_per_user
      info	[Changelog]   - Model ProjectProperties has a new parameter max_dev_boxes_per_user
      info	[Changelog]   - Model ProjectUpdate has a new parameter max_dev_boxes_per_user
      info	[Changelog]   - Model ProjectUpdateProperties has a new parameter max_dev_boxes_per_user
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ImageReference no longer has parameter offer
      info	[Changelog]   - Model ImageReference no longer has parameter publisher
      info	[Changelog]   - Model ImageReference no longer has parameter sku
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4f6418d. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-devcenter [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4f6418d. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-devcenter [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4f6418d. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/devcenter/armdevcenter [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ProjectEnvironmentTypeProperties.Status` has been changed from `*EnableStatus` to `*EnvironmentTypeEnableStatus`
      info	[Changelog] - Type of `ProjectEnvironmentTypeUpdateProperties.Status` has been changed from `*EnableStatus` to `*EnvironmentTypeEnableStatus`
      info	[Changelog] - Type of `ScheduleProperties.State` has been changed from `*EnableStatus` to `*ScheduleEnableStatus`
      info	[Changelog] - Type of `ScheduleUpdateProperties.State` has been changed from `*EnableStatus` to `*ScheduleEnableStatus`
      info	[Changelog] - Enum `EnableStatus` has been removed
      info	[Changelog] - Field `Offer`, `Publisher`, `SKU` of struct `ImageReference` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `EnvironmentTypeEnableStatus` with values `EnvironmentTypeEnableStatusDisabled`, `EnvironmentTypeEnableStatusEnabled`
      info	[Changelog] - New enum type `HealthStatus` with values `HealthStatusHealthy`, `HealthStatusPending`, `HealthStatusUnhealthy`, `HealthStatusUnknown`, `HealthStatusWarning`
      info	[Changelog] - New enum type `ScheduleEnableStatus` with values `ScheduleEnableStatusDisabled`, `ScheduleEnableStatusEnabled`
      info	[Changelog] - New enum type `StopOnDisconnectEnableStatus` with values `StopOnDisconnectEnableStatusDisabled`, `StopOnDisconnectEnableStatusEnabled`
      info	[Changelog] - New function `*PoolsClient.BeginRunHealthChecks(context.Context, string, string, string, *PoolsClientBeginRunHealthChecksOptions) (*runtime.Poller[PoolsClientRunHealthChecksResponse], error)`
      info	[Changelog] - New function `*NetworkConnectionsClient.NewListOutboundNetworkDependenciesEndpointsPager(string, string, *NetworkConnectionsClientListOutboundNetworkDependenciesEndpointsOptions) *runtime.Pager[NetworkConnectionsClientListOutboundNetworkDependenciesEndpointsResponse]`
      info	[Changelog] - New struct `EndpointDependency`
      info	[Changelog] - New struct `EndpointDetail`
      info	[Changelog] - New struct `HealthStatusDetail`
      info	[Changelog] - New struct `OutboundEnvironmentEndpoint`
      info	[Changelog] - New struct `OutboundEnvironmentEndpointCollection`
      info	[Changelog] - New struct `StopOnDisconnectConfiguration`
      info	[Changelog] - New field `HibernateSupport` in struct `ImageProperties`
      info	[Changelog] - New field `HealthStatus`, `HealthStatusDetails`, `StopOnDisconnect` in struct `PoolProperties`
      info	[Changelog] - New field `StopOnDisconnect` in struct `PoolUpdateProperties`
      info	[Changelog] - New field `MaxDevBoxesPerUser` in struct `ProjectProperties`
      info	[Changelog] - New field `MaxDevBoxesPerUser` in struct `ProjectUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 34 additive change(s).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 24, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/devcenter/armdevcenter https://apiview.dev/Assemblies/Review/4f7bc93446054a38acefcc57fbebf798
    Java azure-resourcemanager-devcenter Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-devcenter https://apiview.dev/Assemblies/Review/b86bac824d3e4d72823181d12fdba78b

    @nickdepinet
    Copy link
    Member Author

    This is a publish-only pr of previously approved and merged api version from private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/11737

    @v-jiaodi
    Copy link
    Member

    @nickdepinet Please fill in the correct checkboxes in the first comment so we can get a quick overview of what's going on with this PR and make sure you've understood the relevant linked docs.

    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 25, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 25, 2023
    @nickdepinet
    Copy link
    Member Author

    @nickdepinet Please fill in the correct checkboxes in the first comment so we can get a quick overview of what's going on with this PR and make sure you've understood the relevant linked docs.

    @v-jiaodi - completed the checklist. This api version is already deployed to public, we're only merging from private repo to public repo.

    @v-jiaodi
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Commenter does not have sufficient privileges for PR 23695 in repo Azure/azure-rest-api-specs

    @v-jiaodi
    Copy link
    Member

    @msyyc Could you help to take a look at the SDK BreakingChange in this PR? Thanks

    @msyyc
    Copy link
    Member

    msyyc commented Apr 25, 2023

    approved for python SDK breaking

    @@ -97,7 +108,6 @@ swagger-to-sdk:
    - repo: azure-sdk-for-python
    - repo: azure-sdk-for-java
    - repo: azure-sdk-for-js
    - repo: azure-sdk-for-go
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Is there a reason that we removed this job here?

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @ArcturusZhang - I think this happened on the preview version of this API too (2023-01-01-preview) - I think there is some difference between the public/private branches that is causing this - do you want me to manually re-add?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes please add this back

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @ArcturusZhang - re-added

    re-add azure-sdk-for-go
    @v-jiaodi
    Copy link
    Member

    @raych1 Could you help to take a look at the SDK BreakingChange in this PR? Thanks

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 4, 2023
    @tadelesh
    Copy link
    Member

    tadelesh commented May 4, 2023

    Approved for Go SDK breaking changes as it is first stable version of devcenter.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants