Changing code of ErrorDetails object back to a string #23734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @MattEberhart-MSFTE Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| common-types.json | 2023-03-01(8058bdb) | 2022-10-01(main) |
| common-types.json | 2023-03-01(8058bdb) | 2022-10-05-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version has a different format than the previous one. New: Microsoft.CostManagement/stable/2023-03-01/common-types.json#L88:9 Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9 |
|
The new version has a different format than the previous one. New: Microsoft.CostManagement/stable/2023-03-01/common-types.json#L88:9 Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9 |
|
The new version has a different type 'string' than the previous one 'integer'. New: Microsoft.CostManagement/stable/2023-03-01/common-types.json#L88:9 Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9 |
|
The new version has a different type 'string' than the previous one 'integer'. New: Microsoft.CostManagement/stable/2023-03-01/common-types.json#L88:9 Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9 |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a client parameter that was found in the old version. Was 'apiVersionParameter' removed or renamed? New: Microsoft.CostManagement/stable/2023-03-01/common-types.json#L213:3 Old: Microsoft.CostManagement/preview/2022-10-05-preview/common-types.json#L62:3 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2023-03 | package-2023-03(8058bdb) | package-2023-03(dev-cost-management-Microsoft.CostManagement-2023-03-01-stable) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @MattEberhart-MSFTE, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Apr 26, 2023
pilor
added
the
ARMSignedOff
saipv
approved these changes
Apr 26, 2023
MattEberhart-MSFTE
merged commit 00f032e
into
dev-cost-management-Microsoft.CostManagement-2023-03-01-stable
MattEberhart-MSFTE
added a commit
that referenced
this pull request
May 9, 2023
* Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Benefit Summaries Async (#22497) * Added benefit utilizaiton summaries APIs to costmanagement.benefits.json and appropriate examples. * Added report schema and secondary url * Prettier check and spelling error fix * Addressed BenefitKind / Kind in the csv schema and changed parameter name to benefitAsyncOperationIdParameter * Replacing included quantity * Alphabetized the parameters * Changing request body BenefitKind property to Kind * Adding 200 repsonse to generate api and fixing linter warnings * Adding examples to generate api * Making status optional for running scenario * Changing to completed to have all properties in generate examples and adding long running operation tag to error response * LRO Error response * LRO lint diff error still present. * Found all diffs in 2022-10-01 version added since branching (#23590) * Found all diffs in 2022-10-01 version added since branching * Fixing examples ruined by updating. Pulled straight from 2022-10-01 * Changed enum name (#23605) * Changing code of ErrorDetails object back to a string (#23734) * cost details report operation results example needs string error code (#23742) * Cherry picked commit causing conflict in readme (#23817) Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com> --------- Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com>
MattEberhart-MSFTE
added a commit
that referenced
this pull request
May 9, 2023
* Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Benefit Summaries Async (#22497) * Added benefit utilizaiton summaries APIs to costmanagement.benefits.json and appropriate examples. * Added report schema and secondary url * Prettier check and spelling error fix * Addressed BenefitKind / Kind in the csv schema and changed parameter name to benefitAsyncOperationIdParameter * Replacing included quantity * Alphabetized the parameters * Changing request body BenefitKind property to Kind * Adding 200 repsonse to generate api and fixing linter warnings * Adding examples to generate api * Making status optional for running scenario * Changing to completed to have all properties in generate examples and adding long running operation tag to error response * LRO Error response * LRO lint diff error still present. * Found all diffs in 2022-10-01 version added since branching (#23590) * Found all diffs in 2022-10-01 version added since branching * Fixing examples ruined by updating. Pulled straight from 2022-10-01 * Changed enum name (#23605) * Changing code of ErrorDetails object back to a string (#23734) * cost details report operation results example needs string error code (#23742) * Cherry picked commit causing conflict in readme (#23817) Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com> --------- Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com>
ArcturusZhang
pushed a commit
that referenced
this pull request
May 16, 2023
…rsion stable/2023-03-01 (#23892) * Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Matteberhart/merging main for readme (#23886) * Adds base for updating Microsoft.CostManagement from version stable/2022-10-01 to version 2023-03-01 * Updates readme * Updates API version in new specs and examples * Benefit Summaries Async (#22497) * Added benefit utilizaiton summaries APIs to costmanagement.benefits.json and appropriate examples. * Added report schema and secondary url * Prettier check and spelling error fix * Addressed BenefitKind / Kind in the csv schema and changed parameter name to benefitAsyncOperationIdParameter * Replacing included quantity * Alphabetized the parameters * Changing request body BenefitKind property to Kind * Adding 200 repsonse to generate api and fixing linter warnings * Adding examples to generate api * Making status optional for running scenario * Changing to completed to have all properties in generate examples and adding long running operation tag to error response * LRO Error response * LRO lint diff error still present. * Found all diffs in 2022-10-01 version added since branching (#23590) * Found all diffs in 2022-10-01 version added since branching * Fixing examples ruined by updating. Pulled straight from 2022-10-01 * Changed enum name (#23605) * Changing code of ErrorDetails object back to a string (#23734) * cost details report operation results example needs string error code (#23742) * Cherry picked commit causing conflict in readme (#23817) Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com> --------- Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com> * Adding x-ms-secret to the report urls (#23934) * Remove operation results (#23938) * Remove operation results * Removing examples * Using commony type error response (#23955) --------- Co-authored-by: alprosms <92699124+alprosms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.