[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-03-01 #23914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @pthippeswamy Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| consumption_pricesheet.json | 2023-03-01(b48c7ef) | 2023-03-01(main) |
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Consumption/stable/2023-03-01/consumption_pricesheet.json#L37:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-03 | package-2023-03(b48c7ef) | package-2023-03(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Consumption/stable/2023-03-01/consumption_pricesheet.json#L37 |
RPC-Uri-V1-07 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 34 Errors, 0 Warnings failed [Detail]
Tag package-2023-03; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 32, untested: 0, failed: 31, passed: 1
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 404, errorCode: SubscriptionNotFound, errorMessage: The subscription '00000000-0000-0000-0000-000000000000' could not be found. Source: runtime OperationId: Budgets_CreateOrUpdate |
|
statusCode: 404, errorCode: SubscriptionNotFound, errorMessage: The subscription '00000000-0000-0000-0000-000000000000' could not be found. Source: runtime OperationId: Budgets_List |
|
statusCode: 404, errorCode: SubscriptionNotFound, errorMessage: The subscription '00000000-0000-0000-0000-000000000000' could not be found. Source: runtime OperationId: Budgets_Get |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id '489ed80a-9494-4e5f-abf4-fb247e544c96' for follow-up. Source: runtime OperationId: Balances_GetForBillingPeriodByBillingAccount |
|
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Consumption/pricesheets/action' over scope '/providers/Microsoft.Billing/billingAccounts/billingamvngr7/billingPeriods/billingpmc8fkl/providers/Microsoft.Consumption/pricesheets/download' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: PriceSheet_DownloadByBillingAccountPeriod |
|
String does not match pattern ^[0-9]*$: billingpmc8fkl Source: request OperationId: PriceSheet_DownloadByBillingAccountPeriod |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id '772110b3-01ad-4127-84f6-2773dc745442' for follow-up. Source: runtime OperationId: Credits_Get |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id '085b3c8a-cbdf-46a5-b12b-8f48ac0af91a' for follow-up. Source: runtime OperationId: Events_ListByBillingProfile |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id 'bb1eebab-b656-46a9-8721-d43acce03f40' for follow-up. Source: runtime OperationId: Lots_ListByBillingProfile |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationTransactions_ListByBillingProfile |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id 'f0ec8d81-226d-47ee-b67a-eeb7b95f06b0' for follow-up. Source: runtime OperationId: Lots_ListByCustomer |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id '20283cb3-cdbb-48c2-a4b6-aa108de60ef5' for follow-up. Source: runtime OperationId: Balances_GetByBillingAccount |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id 'fc63672f-39f0-4490-980b-148cef671f4c' for follow-up. Source: runtime OperationId: Events_ListByBillingAccount |
|
statusCode: 500, errorCode: 500, errorMessage: An exception occurred during processing the request. Use this request id '68fcdcf8-a54f-4106-bfce-aef5fa25c80e' for follow-up. Source: runtime OperationId: Lots_ListByBillingAccount |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationTransactions_List |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationsDetails_ListByReservationOrder |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationsSummaries_ListByReservationOrder |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationsDetails_ListByReservationOrderAndReservation |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationsSummaries_ListByReservationOrderAndReservation |
|
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Consumption/aggregatedCost/read' over scope '/providers/Microsoft.Management/managementGroups/managemewbjgs4/providers/Microsoft.Billing/billingPeriods/billingpmc8fkl/providers/Microsoft.Consumption' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: AggregatedCost_GetForBillingPeriodByManagementGroup |
|
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Consumption/aggregatedcost/read' over scope '/providers/Microsoft.Management/managementGroups/managemewbjgs4/providers/Microsoft.Consumption' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: AggregatedCost_GetByManagementGroup |
|
statusCode: 404, errorCode: 404, errorMessage: Cost management data is not supported for subscription(s) db5eb68e-73e2-4fa8-b18a-46cd1be4cce5 in the provided api-version. Please use api-version 2019-10-01 or later. (Request ID: 731d37ff-bbf3-48c8-baac-775f5928e040) Source: runtime OperationId: PriceSheet_GetByBillingPeriod |
|
statusCode: 404, errorCode: 404, errorMessage: Cost management data is not supported for subscription(s) db5eb68e-73e2-4fa8-b18a-46cd1be4cce5 in the provided api-version. Please use api-version 2019-10-01 or later. (Request ID: d892d008-0bc1-46db-bdc8-d4e4c7d120eb) Source: runtime OperationId: PriceSheet_Get |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationsDetails_List |
|
statusCode: 400, errorCode: InvalidSubscriptionId, errorMessage: The provided subscription identifier '00000000-0000-0000-0000-00000000' is malformed or invalid. Source: runtime OperationId: ReservationRecommendationDetails_Get |
|
statusCode: 404, errorCode: SubscriptionNotFound, errorMessage: The subscription '00000000-0000-0000-0000-000000000000' could not be found. Source: runtime OperationId: ReservationRecommendations_List |
|
statusCode: 401, errorCode: 401, errorMessage: Caller is not authorized Source: runtime OperationId: ReservationsSummaries_List |
|
statusCode: 401, errorCode: 401, errorMessage: No claims present for the caller in the system Source: runtime OperationId: Charges_List |
|
statusCode: 404, errorCode: SubscriptionNotFound, errorMessage: The subscription '00000000-0000-0000-0000-000000000000' could not be found. Source: runtime OperationId: Marketplaces_List |
|
statusCode: 404, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: Tags_Get |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
|
NewApiVersionRequired reason: |
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Swagger Generation Artifacts
|
This was referenced May 10, 2023
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Swagger Generation Artifacts
|
|
/azp run unifiedPipeline |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
AzureRestAPISpecReview
added
ReadyForApiTest
I have already added some directive to handle it in Go SDK. Perhaps, you could revert your change. |
Yes, I did not check in anything for the sdk-for-go error. |
tadelesh
reviewed
Jun 12, 2023
|
Hi @pthippeswamy, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
approved lint diff due to arm comment |
tadelesh
added
the
Approved-SdkBreakingChange-Go
|
Go SDK breaking changes are not introduced in this PR. Approved. |
v-jiaodi
approved these changes
Jun 13, 2023
v-jiaodi
added
the
Approved-OkToMerge
weidongxu-microsoft
deleted the
pthippeswamy-consumption-Microsoft.Consumption-2023-03-01
branch
This was referenced Jun 14, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…on stable/2023-03-01 (Azure#23914) * EA Pricesheet download documentation. * Model validation error fix * readme edit to add consumption_pricesheet.json * corrections * Proper braces * corrections * corrections * edits * corrections * edit * Removed unwanted path and example file * Added error response back * Call method correction * validating Linter error - testing * Removed errorResponse to common file * errorResponse * Adding common-types json to readme * ErrorDetail addition * Removed common-types. Edits to correct Linter issues. * removed the reference to old file * CI issues fixed * Corrections based on PR comment * rename * SDK error fix * Delete consumption.json * Revert "SDK error fix" This reverts commit e0d3154. * Suppression for Linter error * supression * supression * supression error * resolve go duplicate schema issue * Changes per - https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdev.azure.com%2Fazure-sdk%2Finternal%2F_wiki%2Fwikis%2Finternal.wiki%2F828%2FHow-to-suppress-validation-rules%3Fanchor%3Dnew-guidance-as-of-5%2F15%2F2023&data=05%7C01%7Cpthippeswamy%40microsoft.com%7C1975ac464e674af18df308db672967e8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638217199804383965%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=L6ZelM9GpeDUHthYwX%2Fgb0BCM6aBTNKxMOT548n2rNc%3D&reserved=0 * correction * correcting suppression format * revert suppression --------- Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change ADO - approved - https://msazure.visualstudio.com/One/_workitems/edit/23289060
Met with Suhas Rao to discuss about the errors seen on the PR.
Have reached out to Breaking Change team to clarify about the documentation and will update the PR once we get an approval from Breaking change team.
On the Linter error "path-for-resource-action" - This API is a tenant level API that is already in PROD and used by customers and the path cannot be modified. We are documenting the API that was missed.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.