Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python misspelling #24171

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

kfcampbell
Copy link
Contributor

Hi!

I was reading through some of these specs and caught this small misspelling present in 4 files.

@openapi-workflow-bot
Copy link

Hi, @kfcampbell Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.2) new version base version
    default default(29e55ba) default(main)
    default default(29e55ba) default(main)
    default default(29e55ba) default(main)
    default default(29e55ba) default(main)
    ️⚠️Avocado: 2 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/containerregistry/resource-manager/readme.md
    tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-01-preview
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/subscription/resource-manager/readme.md
    tag: specification/subscription/resource-manager/readme.md#tag-package-2021-10
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking











    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d413808. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerregistry/armcontainerregistry [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/mixedreality/armmixedreality [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/msi/armmsi [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️sdk/resourcemanager/subscription/armsubscription [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `Provisioning` with values `ProvisioningAccepted`, `ProvisioningPending`, `ProvisioningSucceeded`
      info	[Changelog] - New field `ProvisioningState` in struct `AcceptOwnershipStatusResponse`
      info	[Changelog] - New field `Tags`, `TenantID` in struct `Subscription`
      info	[Changelog] - New field `Country`, `CountryCode`, `DefaultDomain`, `DisplayName`, `Domains`, `TenantCategory`, `TenantType` in struct `TenantIDDescription`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 7 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d413808. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes]
      Only show 30 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias ImportPipelinesListNextResponse
      info	[Changelog]   - Added Type Alias ImportPipelinesListResponse
      info	[Changelog]   - Added Type Alias LogLevel
      info	[Changelog]   - Added Type Alias PipelineOptions
      info	[Changelog]   - Added Type Alias PipelineRunsCreateResponse
      info	[Changelog]   - Added Type Alias PipelineRunsGetResponse
      info	[Changelog]   - Added Type Alias PipelineRunsListNextResponse
      info	[Changelog]   - Added Type Alias PipelineRunsListResponse
      info	[Changelog]   - Added Type Alias PipelineRunSourceType
      info	[Changelog]   - Added Type Alias PipelineRunTargetType
      info	[Changelog]   - Added Type Alias PipelineSourceType
      info	[Changelog]   - Added Type Alias TlsStatus
      info	[Changelog]   - Interface Policies has a new optional parameter azureADAuthenticationAsArmPolicy
      info	[Changelog]   - Interface Policies has a new optional parameter softDeletePolicy
      info	[Changelog]   - Interface Registry has a new optional parameter anonymousPullEnabled
      info	[Changelog]   - Interface RegistryUpdateParameters has a new optional parameter anonymousPullEnabled
      info	[Changelog]   - Added Enum KnownActivationStatus
      info	[Changelog]   - Added Enum KnownAuditLogStatus
      info	[Changelog]   - Added Enum KnownAzureADAuthenticationAsArmPolicyStatus
      info	[Changelog]   - Added Enum KnownCertificateType
      info	[Changelog]   - Added Enum KnownConnectedRegistryMode
      info	[Changelog]   - Added Enum KnownConnectionState
      info	[Changelog]   - Added Enum KnownCredentialHealthStatus
      info	[Changelog]   - Added Enum KnownCredentialName
      info	[Changelog]   - Added Enum KnownLogLevel
      info	[Changelog]   - Added Enum KnownPipelineOptions
      info	[Changelog]   - Added Enum KnownPipelineRunSourceType
      info	[Changelog]   - Added Enum KnownPipelineRunTargetType
      info	[Changelog]   - Added Enum KnownPipelineSourceType
      info	[Changelog]   - Added Enum KnownTlsStatus
    • ️✔️@azure/arm-mixedreality [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ObjectAnchorsAccounts
      info	[Changelog]   - Added Interface ObjectAnchorsAccount
      info	[Changelog]   - Added Interface ObjectAnchorsAccountIdentity
      info	[Changelog]   - Added Interface ObjectAnchorsAccountPage
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsCreateOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsDeleteOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsGetOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsListByResourceGroupNextOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsListByResourceGroupOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsListBySubscriptionNextOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsListBySubscriptionOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsListKeysOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsRegenerateKeysOptionalParams
      info	[Changelog]   - Added Interface ObjectAnchorsAccountsUpdateOptionalParams
      info	[Changelog]   - Added Interface RemoteRenderingAccount
      info	[Changelog]   - Added Interface SpatialAnchorsAccount
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsCreateResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsGetResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsListKeysResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsRegenerateKeysResponse
      info	[Changelog]   - Added Type Alias ObjectAnchorsAccountsUpdateResponse
      info	[Changelog]   - Interface MetricDimension has a new optional parameter toBeExportedForShoebox
      info	[Changelog]   - Added function getContinuationToken
    • ️✔️@azure/arm-msi [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    • ️✔️@azure/arm-subscriptions [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d413808. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️containerregistry [View full logs
    • ️✔️mixedreality [View full logs
    • ️✔️msi [View full logs
    • ️✔️subscription [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from d413808. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.containerregistry.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.containerregistry.DefaultTag
      error		Az.mixedreality.DefaultTag
      error		Az.msi.DefaultTag
      error		Az.subscription.DefaultTag
    • Az.mixedreality.DefaultTag
    • ️✔️Az.msi.DefaultTag
    • ️✔️Az.subscription.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/containerregistry/armcontainerregistry There is no API change compared with the previous version
    Go sdk/resourcemanager/mixedreality/armmixedreality There is no API change compared with the previous version
    Go sdk/resourcemanager/msi/armmsi There is no API change compared with the previous version
    Go sdk/resourcemanager/subscription/armsubscription https://apiview.dev/Assemblies/Review/746d03ffd0e047d99bddb78c7fcf3619
    .Net Azure.ResourceManager.ContainerRegistry There is no API change compared with the previous version
    .Net Azure.ResourceManager.MixedReality There is no API change compared with the previous version
    .Net Azure.ResourceManager.Subscription There is no API change compared with the previous version
    Java azure-resourcemanager-containerregistry-generated https://apiview.dev/Assemblies/Review/f2092024059f401793db18ba6b028c20
    Java azure-resourcemanager-mixedreality https://apiview.dev/Assemblies/Review/7853fcd13df24effa4bc11aef225c6de
    Java azure-resourcemanager-msi-generated https://apiview.dev/Assemblies/Review/fefd9a2851c94a9fb9b748dee2bdba89
    JavaScript @azure/arm-containerregistry https://apiview.dev/Assemblies/Review/bc8ad2606aaf4c148de38725d05d3e45
    JavaScript @azure/arm-mixedreality https://apiview.dev/Assemblies/Review/5176610a3a7c474aaf6aa2322d42a27d
    JavaScript @azure/arm-msi https://apiview.dev/Assemblies/Review/2defdd7c4be540dab81aaa97787beb61
    JavaScript @azure/arm-subscriptions https://apiview.dev/Assemblies/Review/b19b4f231a964330a63290907933b04f

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 25, 2023
    @ghost
    Copy link

    ghost commented May 25, 2023

    Thank you for your contribution kfcampbell! We will review the pull request and get back to you soon.

    @ghost ghost added the Container Registry label May 25, 2023
    This was referenced May 25, 2023
    @kfcampbell
    Copy link
    Contributor Author

    The build failures look unrelated; unfortunately I do not have permission to retry the build.

    @Wzb123456789 Wzb123456789 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 31, 2023
    @chunyu3 chunyu3 merged commit d413808 into Azure:main May 31, 2023
    This was referenced May 31, 2023
    @kfcampbell kfcampbell deleted the fix-python-misspelling branch June 1, 2023 18:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Container Registry customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants