Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] python config #24217

Merged
merged 2 commits into from
Jun 1, 2023
Merged

[storage] python config #24217

merged 2 commits into from
Jun 1, 2023

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented May 30, 2023

@msyyc msyyc requested a review from Wzb123456789 as a code owner May 30, 2023 07:21
@msyyc msyyc self-assigned this May 30, 2023
@openapi-workflow-bot
Copy link

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label May 30, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 30, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️⌛Breaking Change(Cross-Version) pending [Detail]
    ️⌛CredScan pending [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️🔄Avocado inProgress [Detail]
    ️🔄ApiReadinessCheck inProgress [Detail]
    ️🔄~[Staging] ServiceAPIReadinessTest inProgress [Detail]
    ️🔄SwaggerAPIView inProgress [Detail]
    ️🔄CadlAPIView inProgress [Detail]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️⌛SemanticValidation pending [Detail]
    ️⌛PoliCheck pending [Detail]
    ️🔄PrettierCheck inProgress [Detail]
    ️🔄SpellCheck inProgress [Detail]
    ️🔄Lint(RPaaS) inProgress [Detail]
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️⌛PR Summary pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 30, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 30, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @msyyc, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @azure-sdk azure-sdk mentioned this pull request May 30, 2023
    Closed
    @msyyc
    Copy link
    Member Author

    msyyc commented May 30, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @msyyc
    Copy link
    Member Author

    msyyc commented Jun 1, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @msyyc
    Copy link
    Member Author

    msyyc commented Jun 1, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArthurMa1978 ArthurMa1978 merged commit b9ce503 into main Jun 1, 2023
    @ArthurMa1978 ArthurMa1978 deleted the storage-python-config branch June 1, 2023 02:47
    @azure-sdk azure-sdk mentioned this pull request Jun 1, 2023
    Closed
    weidongxu-microsoft
    weidongxu-microsoft reviewed Jun 1, 2023
    View reviewed changes
    specification/storage/resource-manager/readme.md
    - Microsoft.Storage/preview/2018-03-01-preview/storage.json
    - Microsoft.Storage/preview/2018-03-01-preview/blob.json
    - Microsoft.Storage/preview/2018-03-01-preview/managementpolicy.json
    -
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    this seems wrong.

    autorest can work on commit da0cfef, but not on latest main

    @msyyc msyyc mentioned this pull request Jun 1, 2023
    Merged
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    @msyyc @harryli0108
    [storage] python config (Azure#24217)
    57002fe
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

    @ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

    @Wzb123456789 Wzb123456789 Wzb123456789 approved these changes

    @JasonYang-MSFT JasonYang-MSFT Awaiting requested review from JasonYang-MSFT

    Assignees

    @msyyc msyyc

    Labels
    CI-FixRequiredOnFailure resource-manager Storage Storage Service (Queues, Blobs, Files)
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @msyyc @ArthurMa1978 @Wzb123456789 @weidongxu-microsoft @AzureRestAPISpecReview