Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeSpec CI] Revert formatting check and changes to eventgrid #24430

Merged
merged 2 commits into from
Jun 14, 2023
Merged

[TypeSpec CI] Revert formatting check and changes to eventgrid #24430

merged 2 commits into from
Jun 14, 2023

Conversation

mikeharder
Copy link
Member

@openapi-workflow-bot
Copy link

Hi, @mikeharder Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️🔄CredScan inProgress [Detail]
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️🔄PoliCheck inProgress [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️❌TypeSpec Validation: 2 Errors, 26 Warnings failed [Detail]
    Rule Message
    ❌ MissingExamplesDirectory "details":"The 'examples' directory is missing in the typespec folder specification/eventgrid/Azure.Messaging.EventGrid,
    please ensure the 'examples' is added in the PR."
    ❌ InConsistentSwagger "details":"The generated swagger file EventGrid.json from typespec specification/eventgrid/Azure.Messaging.EventGrid is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2017-06-15-preview/EventGrid.json' in PR,
    please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log."
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L168
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L185
    ⚠️ @azure-tools/typespec-azure-core/no-unknown Azure services must not have properties of type unknown.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L56
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Property types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L59
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Operation types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L168
    ⚠️ @azure-tools/typespec-azure-core/no-rpc-path-params Operations defined using RpcOperation should not have path parameters. Consider using ResourceAction or ResourceCollectionAction instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L168
    ⚠️ @azure-tools/typespec-azure-core/request-body-problem Request body should not be of raw array type. Consider creating a container model that can add properties over time to avoid introducing breaking changes.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L196
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Operation types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L185
    ⚠️ @azure-tools/typespec-azure-core/no-rpc-path-params Operations defined using RpcOperation should not have path parameters. Consider using ResourceAction or ResourceCollectionAction instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L185
    ⚠️ @azure-tools/typespec-azure-core/request-body-problem Request body should not be of raw array type. Consider creating a container model that can add properties over time to avoid introducing breaking changes.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L196
    ⚠️ @azure-tools/typespec-azure-core/request-body-problem Request body should not be of raw array type. Consider creating a container model that can add properties over time to avoid introducing breaking changes.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L196
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Operation types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L204
    ⚠️ @azure-tools/typespec-azure-core/no-rpc-path-params Operations defined using RpcOperation should not have path parameters. Consider using ResourceAction or ResourceCollectionAction instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L204
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Operation types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L228
    ⚠️ @azure-tools/typespec-azure-core/no-rpc-path-params Operations defined using RpcOperation should not have path parameters. Consider using ResourceAction or ResourceCollectionAction instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L228
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Operation types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L252
    ⚠️ @azure-tools/typespec-azure-core/no-rpc-path-params Operations defined using RpcOperation should not have path parameters. Consider using ResourceAction or ResourceCollectionAction instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L252
    ⚠️ @azure-tools/typespec-azure-core/casing-style The names of Operation types must use camelCase
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L275
    ⚠️ @azure-tools/typespec-azure-core/no-rpc-path-params Operations defined using RpcOperation should not have path parameters. Consider using ResourceAction or ResourceCollectionAction instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L275
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L168
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L185
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L168
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L185
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L168
    ⚠️ deprecated: Deprecated The shared option is deprecated, use the @sharedRoute decorator instead.
    Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L185
    ⚠️ MissingTypeSpecProjectConfig "details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/eventgrid/Azure.Messaging.EventGrid,
    please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a6ae55e. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.1` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️azure-eventgrid [View full logs]  [Release SDK Changes] 
      info	[Changelog] data-plan skip changelog generation temporarily
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs]Release - Generate from a6ae55e. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:145
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 145 | �[0m         �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • ❌Azure.Messaging.EventGrid.Namespaces [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Event Grid label Jun 14, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Python azure-eventgrid https://apiview.dev/Assemblies/Review/7ad27c9b83db4b72a7ff01e864a901a7

    @azure-sdk azure-sdk mentioned this pull request Jun 14, 2023
    Closed
    @mikeharder mikeharder merged commit a6ae55e into Azure:main Jun 14, 2023
    @mikeharder mikeharder deleted the tsp-format-revert branch June 14, 2023 02:57
    @mikeharder mikeharder assigned mikeharder and unassigned anuchandy Jun 14, 2023
    This was referenced Jun 14, 2023
    Closed
    Closed
    Closed
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    @mikeharder @harryli0108
    [TypeSpec CI] Revert formatting check and changes to eventgrid (Azure…
    d695ba3 
    …#24430)

- Blocked until microsoft/typespec#2060 is fixed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ckairen ckairen ckairen approved these changes

    @timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin

    @Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

    @ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

    Assignees

    @mikeharder mikeharder

    Labels
    Event Grid
    Projects
    Azure SDK EngSys 📈
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mikeharder @ckairen @anuchandy